Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for insider SDK usage, and ListViewItem/GridViewItem visual updates #3991

Merged
merged 20 commits into from
Jan 26, 2021
Merged

Adding support for insider SDK usage, and ListViewItem/GridViewItem visual updates #3991

merged 20 commits into from
Jan 26, 2021

Conversation

RBrid
Copy link
Contributor

@RBrid RBrid commented Jan 21, 2021

Description

Changing the build so that an internal Windows SDK can be used with recent Windows builds.

Adding resources/styles for ListViewItem/GridViewItem's Visual Update.

Motivation and Context

Allows internal testing of recent Windows builds.

How Has This Been Tested?

Ran MUXControlsTestApp in these configurations:

  • built with old SDK, run on 20H1
  • built with old SDK, run on 21H1
  • built with new SDK, run on 20H1
  • built with new SDK, run on 21H1
  • built with new SDK, run on 20H1, using compact resources
  • built with new SDK, run on 21H1, using compact resources

@RBrid RBrid added area-Lists ListView, GridView, ListBox, etc area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency labels Jan 21, 2021
@RBrid RBrid requested review from licanhua, jevansaks, ranjeshj and a team January 21, 2021 01:45
@RBrid RBrid self-assigned this Jan 21, 2021
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Jan 21, 2021
RBrid
RBrid commented Jan 21, 2021
View reviewed changes
SdkVersion.props Outdated Show resolved Hide resolved
licanhua
licanhua reviewed Jan 21, 2021
View reviewed changes
dev/CommonStyles/CommonStyles.vcxitems Outdated Show resolved Hide resolved
dev/CommonStyles/CommonStyles.vcxitems Outdated Show resolved Hide resolved
dev/CommonStyles/CommonStyles.vcxitems Outdated Show resolved Hide resolved
dev/CommonStyles/CommonStyles.vcxitems Outdated Show resolved Hide resolved
dev/Materials/Reveal/RevealBrush.vcxitems Outdated Show resolved Hide resolved
dev/CommonStyles/GridViewItem_themeresources.xaml Outdated Show resolved Hide resolved
dev/dll/XamlControlsResources.cpp Outdated Show resolved Hide resolved
dev/dll/Microsoft.UI.Xaml.vcxproj Outdated Show resolved Hide resolved
dev/dll/Microsoft.UI.Xaml.vcxproj Outdated Show resolved Hide resolved
@StephenLPeters StephenLPeters added team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Jan 22, 2021
@RBrid
ListViewItem/GridViewItem: moving High Contrast resources from Resour…
ec11b66 
…ceKey='AccentAAFillColorDisabledBrush' type to Color='{ThemeResource SystemColorWindowColor}' type.
licanhua
licanhua reviewed Jan 25, 2021
View reviewed changes
SdkVersion.props Outdated Show resolved Hide resolved
@RBrid
Copy link
Contributor Author

RBrid commented Jan 25, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

licanhua
licanhua reviewed Jan 25, 2021
View reviewed changes
mux.controls.props Outdated Show resolved Hide resolved
@RBrid
Copy link
Contributor Author

RBrid commented Jan 26, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

licanhua
licanhua approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@licanhua licanhua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@RBrid RBrid merged commit cd20808 into master Jan 26, 2021
@RBrid RBrid deleted the user/regisb/ListViewItemVisualUpdates2 branch January 26, 2021 18:11
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Nov 7, 2022
@Kinnara
Port microsoft/microsoft-ui-xaml#3991
cdb0592
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Nov 7, 2022
@Kinnara
Port microsoft/microsoft-ui-xaml#3991 (#524)
3cf00e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmahone kmahone kmahone left review comments

@ranjeshj ranjeshj ranjeshj left review comments

@licanhua licanhua licanhua approved these changes

@jevansaks jevansaks Awaiting requested review from jevansaks

Assignees

@RBrid RBrid

Labels
area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency area-Lists ListView, GridView, ListBox, etc team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RBrid @licanhua @jevansaks @ranjeshj @kmahone @StephenLPeters