Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few problems with the new NavigationView control on winui library #3

Closed
touseefbsb opened this issue Oct 15, 2018 · 2 comments
Closed

A few problems with the new NavigationView control on winui library #3

touseefbsb opened this issue Oct 15, 2018 · 2 comments
Assignees
@jesbis
Labels
duplicate This issue or pull request already exists

Comments

@touseefbsb
Copy link

a few problems with the new NavigationView control on winui library :

  1. No Acrylic.
  2. No way to manually set acrylic because there is no "PaneBackground" property.
  3. No way to edit its template in blend either.
@jesbis jesbis self-assigned this Oct 15, 2018
@jesbis
Copy link
Member

jesbis commented Oct 15, 2018

Hi Touseef,

  1. The default NavigationView style in WinUI matches the new style found in the Windows October 2018 Update (17763), so the current style is by design. However you can customize it as needed for your app (see 2.)

  2. You can set the background brush of a NavigationView to an AcrylicBrush as described here:
    https://docs.microsoft.com/windows/uwp/design/controls-and-patterns/navigationview#customizing-backgrounds

  3. Can you provide some additional info to help us reproduce this:

  • Are you attempting to edit directly from the design surface, from markup, or from the Document Outline?
  • Does it work in Visual Studio?
  • What version # of WinUI are you using?
  • What version of Visual Studio/Blend are you using?

Thanks!

@jesbis jesbis added the duplicate This issue or pull request already exists label Oct 15, 2018
@jesbis
Copy link
Member

jesbis commented Oct 15, 2018

Actually we just pushed a package version (2.0.181011001 ) that will cause 3. to be an issue for all apps - now tracking that here:
#4

@jesbis jesbis closed this as completed Oct 15, 2018
RBrid added a commit that referenced this issue Jan 18, 2019
@RBrid
Step #3: Fixing OS build.
03bcbbc
@RBrid RBrid mentioned this issue Jun 26, 2019
Open
@chigy chigy mentioned this issue Sep 17, 2019
Closed
This was referenced Nov 23, 2019
Open
Closed
@DmitriyKomin DmitriyKomin mentioned this issue Dec 19, 2019
Closed
@ryandemopoulos ryandemopoulos mentioned this issue Feb 7, 2020
Open
@SpencerHurd SpencerHurd mentioned this issue Feb 20, 2020
Closed
@robloo robloo mentioned this issue Apr 9, 2020
Open
@RBrid RBrid mentioned this issue Jun 8, 2020
Merged
@kmgallahan kmgallahan mentioned this issue Jul 8, 2020
Closed
@ranjeshj ranjeshj mentioned this issue Sep 8, 2020
Closed
RBrid added a commit that referenced this issue Jan 15, 2021
@RBrid
Incremental work #3 for new insider Windows SDK support
1cc0ba0
RBrid added a commit that referenced this issue Jan 26, 2021
@RBrid
Adding support for insider SDK usage, and ListViewItem/GridViewItem v…
cd20808 
…isual updates (#3991)

* ListViewItem/GridViewItem Visual Updates - Phase #1

* Incremental work for new insider Windows SDK support

* Incremental work #2 for new insider Windows SDK support

* Incremental work #3 for new insider Windows SDK support

* Incremental work #4 for new insider Windows SDK support

* Incremental work #5 for new insider Windows SDK support

* Incremental work #6 for new insider Windows SDK support

* Upgrading to insider Windows SDK version 10.0.21296.0

* Switching to use more accurate UseInternalSDK instead of UseInsiderSDK

* ListViewItem/GridViewItem: moving High Contrast resources from ResourceKey='AccentAAFillColorDisabledBrush' type to Color='{ThemeResource SystemColorWindowColor}' type.

* Simplifications: no more LatestWithVisualUpdate, LatestWithoutVisualUpdate options, _vu suffix, exception catch, RSx changes

* Deleting unneeded GridViewItem_themeresources.xaml

* Using Insider SDK again

* Using Insider SDK again

* Upgrading CustomTasks.dll version from 1.0.70 to 1.0.71 after its publication

* Also using 21h1_generic.xaml on 21H1 OS
@anawishnoff anawishnoff mentioned this issue May 13, 2021
Closed
@jeffstall jeffstall mentioned this issue Aug 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jesbis jesbis

Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@touseefbsb @jesbis