Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After updating to version 2.0.181011001, the appbarbutton reveal border only covers a part of the control #6

Closed
lhak opened this issue Oct 16, 2018 · 8 comments
Assignees
Labels
bug Something isn't working team-Controls Issue for the Controls team

Comments

@lhak
Copy link

lhak commented Oct 16, 2018

After updating the WinUI library to the version mentioned in the title, the following markup:

<CommandBar DefaultLabelPosition="Collapsed">
	<CommandBar.PrimaryCommands>
		<AppBarButton Icon="Add" Label="Add"/>
	</CommandBar.PrimaryCommands>
</CommandBar>

leads to the reveal border only partially covering the button:

image

with the previous WinUI version it looked like this:

image

This happens on Windows version 1809 (17763.55) and corresponding SDK. Please note that this styling issue also seems to appear without the WinUI library added to the project (it was fine on Windows version 1803 without WinUI) and that the older WinUI version was apparently able to fix it.

@jevansaks
Copy link
Member

Thanks for your feedback! We have a fix pending for this but it was not included in this update. We should have an update published this week with the fix.

@jevansaks jevansaks self-assigned this Oct 16, 2018
@jevansaks jevansaks added the bug Something isn't working label Oct 16, 2018
@lhak
Copy link
Author

lhak commented Oct 17, 2018

Thank you very much for the quick reply. This also seems to be an issue with the default platform styles on Windows 1809. Will it be fixed there as well?

@jevansaks
Copy link
Member

No, unfortunately the fix did not make it in to the 1809 update. The fix will be available in the MUX package so that can help you mitigate the issue.

@touseefbsb
Copy link

this is the best thing about winui library @jevansaks we can get quick fixes in the platform controls this way, also it would be even faster if community can also actively contribute to the code, would that be possible soon?

@jevansaks
Copy link
Member

We just pushed https://www.nuget.org/packages/Microsoft.UI.Xaml/2.0.181018003 with a fix. Can you try that?

@jevansaks
Copy link
Member

@touseefbsb we're excited about it too! We are working on a plan for contributions. I will share more details about it when we're ready. For now we hope to be able to at least be more responsive to community issues and requests like this. Keep it coming!

@lhak
Copy link
Author

lhak commented Oct 23, 2018

I can confirm that the update has fixed this issue. Thank you very much. Please also fix the corresponding style in Windows as soon as possible because it is a really bad developer experience if the default styles are broken.

@jevansaks
Copy link
Member

Absolutely. The fix should also be in a Windows Insider flight soon.

@jevansaks jevansaks added the team-Controls Issue for the Controls team label Nov 7, 2019
RBrid added a commit that referenced this issue Jan 26, 2021
…isual updates (#3991)

* ListViewItem/GridViewItem Visual Updates - Phase #1

* Incremental work for new insider Windows SDK support

* Incremental work #2 for new insider Windows SDK support

* Incremental work #3 for new insider Windows SDK support

* Incremental work #4 for new insider Windows SDK support

* Incremental work #5 for new insider Windows SDK support

* Incremental work #6 for new insider Windows SDK support

* Upgrading to insider Windows SDK version 10.0.21296.0

* Switching to use more accurate UseInternalSDK instead of UseInsiderSDK

* ListViewItem/GridViewItem: moving High Contrast resources from ResourceKey='AccentAAFillColorDisabledBrush' type to Color='{ThemeResource SystemColorWindowColor}' type.

* Simplifications: no more LatestWithVisualUpdate, LatestWithoutVisualUpdate options, _vu suffix, exception catch, RSx changes

* Deleting unneeded GridViewItem_themeresources.xaml

* Using Insider SDK again

* Using Insider SDK again

* Upgrading CustomTasks.dll version from 1.0.70 to 1.0.71 after its publication

* Also using 21h1_generic.xaml on 21H1 OS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

3 participants