Fix DatePicker re-rendering due to focus behavior change #6308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
…time it gained focus. (microsoft#5583)" This reverts commit 7d141f1.
KevinTCoughlin
force-pushed
the
keco/datepicker-focus
branch
from
487c5ec to
8b2c117
Compare
Member
|
@lorejoh12 can you please review this PR. This is a pretty nasty bug we'd like to fix asap. |
Contributor
|
It looks to me like the bug that my PR addressed is not an issue with this focus change, so this won't be a problem on that front! |
kenotron
approved these changes
Sep 11, 2018
micahgodbolt
approved these changes
Sep 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
It appears that
focusis behaving differently perhaps due to our<Layer>improvements in #6211. There was a<DatePicker/>focus change made in #5583 that assumed certain focus behavior that no longer applies (I think). Therefore to fix #6297 I reverted that commit.I'd like to confirm that the issue from #5583 is also fixed even with the revert cc: @kisiebel please. It appears to be from my testing, but I don't have much context.
Focus areas to test
masterand select dates.. it will aggressively re-render and maintain focus.Microsoft Reviewers: Open in CodeFlow