Mark setPortalAttribute as public to fix LayerBase runtime error #6306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Prettier had opinions about |
KevinTCoughlin
commented
Sep 10, 2018
| /** | ||
| * Identify element as a portal by setting an attribute. | ||
| * @param element Element to mark as a portal. | ||
| * @public |
Member
Author
There was a problem hiding this comment.
this is the "fix"
Member
There was a problem hiding this comment.
I'm confused how a jsdoc tag removes a runtime error? Are you sure this error wasn't due to a local build error (i.e. utilities package was out of date)? I've never seen this error while developing and testing portals and don't see it locally now.
Member
Author
There was a problem hiding this comment.
You're probably right that it was rush and my local setup. Closing this with the real focus fix in #6308
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
There's currently a runtime error thrown in
<LayerBase>due to a missing importsetPortalAttributeIt looks like the fix is to mark it
@publicso it can be properly imported?Focus areas to test
npm startin this branch<LayerBase/>such as<DatePicker/>.Microsoft Reviewers: Open in CodeFlow