Fixes a bug where the DatePicker would only open every other time it gained focus. #5583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cliffkoh
changed the title
Contributor
|
In the future, please try to not have your branch name be the PR name :) |
Contributor
Author
|
Thanks! |
KevinTCoughlin
added a commit
to KevinTCoughlin/office-ui-fabric-react
that referenced
this pull request
Sep 10, 2018
…time it gained focus. (microsoft#5583)" This reverts commit 7d141f1.
2 tasks
KevinTCoughlin
added a commit
to KevinTCoughlin/office-ui-fabric-react
that referenced
this pull request
Sep 10, 2018
…time it gained focus. (microsoft#5583)" This reverts commit 7d141f1.
micahgodbolt
pushed a commit
that referenced
this pull request
Sep 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Removes a variable that was causing the DatePicker to fail to open every other time it gained focus. I believe the variable was designed to prevent the picker from reopening when it was closed and the button regained focus. However, since focus was already inside the picker before it was closed onFocus was not getting called again when the picker was exited.
Focus areas to test
DatePicker keyboard interaction, especially focusing and closing the picker.
Microsoft Reviewers: Open in CodeFlow