Fix minor accessibility bugs in DetailsList#5278
Merged
dzearing merged 4 commits intomicrosoft:masterfrom Jun 27, 2018
Merged
Conversation
dzearing
reviewed
Jun 21, 2018
| key={column.key} | ||
| role="columnheader" | ||
| aria-sort={column.isSorted ? (column.isSortedDescending ? 'descending' : 'ascending') : 'none'} | ||
| aria-disabled={column.columnActionsMode === ColumnActionsMode.disabled} |
Member
There was a problem hiding this comment.
Don't completely understand the background. Do you know who added this and why?
Contributor
|
Hey it looks like DetailsList was recently refactored in a PR merged 4 hours ago and there is now a new file, DetailsColumn.tsx. These changes may need to be made in there instead? |
ThomasMichon
force-pushed
the
details-accessibility
branch
from
3efaffd to
b4199bd
Compare
natalieethell
approved these changes
Jun 27, 2018
ThomasMichon
added a commit
to ThomasMichon/office-ui-fabric-react
that referenced
this pull request
Jul 17, 2018
* Remove aria-disabled from column headers (fix microsoft#4142) * Increase contrast of Check (Fix microsoft#4269 and microsoft#5076) * Update snapshot output * Update change output
ThomasMichon
added a commit
to ThomasMichon/office-ui-fabric-react
that referenced
this pull request
Jul 17, 2018
* Remove aria-disabled from column headers (fix microsoft#4142) * Increase contrast of Check (Fix microsoft#4269 and microsoft#5076) * Update snapshot output * Update change output
ThomasMichon
added a commit
that referenced
this pull request
Jul 17, 2018
* Fix DetailsList accessibility and add more ARIA hooks (#5066) * Fix Narrator table navigation and support ARIA labels for column states * Update change output * Update snapshot output * Update details-accessibility_2018-06-01-20-15.json * Fix minor accessibility bugs in DetailsList (#5278) * Remove aria-disabled from column headers (fix #4142) * Increase contrast of Check (Fix #4269 and #5076) * Update snapshot output * Update change output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusted the contrast of the Check component.
Removed
aria-disabledfrom column headers.This fixes #4142, #4269, and #5076.
Microsoft Reviewers: Open in CodeFlow