Fix DetailsList accessibility and add more ARIA hooks#5066
Merged
dzearing merged 4 commits intomicrosoft:masterfrom Jun 2, 2018
Merged
Fix DetailsList accessibility and add more ARIA hooks#5066dzearing merged 4 commits intomicrosoft:masterfrom
dzearing merged 4 commits intomicrosoft:masterfrom
Conversation
dzearing
approved these changes
Jun 2, 2018
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Jun 2, 2018
* master: MessageBar: More visible HC color for dismiss and expand buttons (microsoft#5061) Fix DetailsList accessibility and add more ARIA hooks (microsoft#5066) Update jest (microsoft#5068)
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Jun 3, 2018
* master: (111 commits) Moving a variable to be defined sooner so that it is there when failures occur. Fix icon imports (microsoft#5069) MessageBar: More visible HC color for dismiss and expand buttons (microsoft#5061) Fix DetailsList accessibility and add more ARIA hooks (microsoft#5066) Update jest (microsoft#5068) Demo Page Refactor Part 1 (microsoft#5055) SplitButton: Add aria-roledescription (microsoft#5062) Add addins sketch toolkit link (microsoft#5052) Dropdown title (microsoft#4983) Allow for more control over event handling for keytips (microsoft#5064) Build time speed improvements (microsoft#4965) Coachmark: Positioning fixes (microsoft#4995) Applying package updates. Experiments/Nav component: display "show more" link only if there is atleast one hidden link (microsoft#5057) Add pointerup listener to exit keytip mode (microsoft#5051) Update PULL_REQUEST_TEMPLATE.md Update ISSUE_TEMPLATE.md Shimmer: resolve conflicts (microsoft#5034) Invalid ARIA attributes: Fix empty values (microsoft#5040) ComboBox: Correct invalid ARIA attributes. (microsoft#4873) (microsoft#5001) ...
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Jun 3, 2018
* master: Moving a variable to be defined sooner so that it is there when failures occur. Fix icon imports (microsoft#5069) MessageBar: More visible HC color for dismiss and expand buttons (microsoft#5061) Fix DetailsList accessibility and add more ARIA hooks (microsoft#5066) Update jest (microsoft#5068)
ThomasMichon
added a commit
to ThomasMichon/office-ui-fabric-react
that referenced
this pull request
Jul 17, 2018
* Fix Narrator table navigation and support ARIA labels for column states * Update change output * Update snapshot output * Update details-accessibility_2018-06-01-20-15.json
ThomasMichon
added a commit
to ThomasMichon/office-ui-fabric-react
that referenced
this pull request
Jul 17, 2018
* Fix Narrator table navigation and support ARIA labels for column states * Update change output * Update snapshot output * Update details-accessibility_2018-06-01-20-15.json
ThomasMichon
added a commit
that referenced
this pull request
Jul 17, 2018
* Fix DetailsList accessibility and add more ARIA hooks (#5066) * Fix Narrator table navigation and support ARIA labels for column states * Update change output * Update snapshot output * Update details-accessibility_2018-06-01-20-15.json * Fix minor accessibility bugs in DetailsList (#5278) * Remove aria-disabled from column headers (fix #4142) * Increase contrast of Check (Fix #4269 and #5076) * Update snapshot output * Update change output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
DetailsListrecently lost the ability to use Narrator's table scan (Ctrl+Alt+Arrows) to navigate all cells in the list. This change fixes thearia-colindexto start at1instead of0.This change also adds more ARIA labels to the status indicators in
DetailsHeadercolumns, so they can be read off by a screen reader.Microsoft Reviewers: Open in CodeFlow