Skip to content

Fix minor accessibility bugs in DetailsList #5278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 4 commits into from
Jun 27, 2018
Merged

Fix minor accessibility bugs in DetailsList #5278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2521d25
Remove aria-disabled from column headers (fix #4142)
ThomasMichon Jun 20, 2018
ce30637
Increase contrast of Check (Fix #4269 and #5076)
ThomasMichon Jun 20, 2018
d04f176
Update snapshot output
ThomasMichon Jun 20, 2018
b4199bd
Update change output
ThomasMichon Jun 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/details-accessibility_2018-06-20-22-18.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Fix minor accessibility bugs in DetailsList",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "tmichon@microsoft.com"
}
4 changes: 2 additions & 2 deletions packages/office-ui-fabric-react/src/components/Check/Check.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ $checkBoxHeight: 18px;
}

.circle {
color: $ms-color-neutralTertiaryAlt;
color: $ms-color-neutralSecondary;

@include high-contrast {
color: WindowText;
Expand All @@ -78,7 +78,7 @@ $checkBoxHeight: 18px;
}

.check {
color: $ms-color-neutralTertiaryAlt;
color: $ms-color-neutralSecondary;
font-size: 16px;
left: .5px;

Expand Down
1 change: 0 additions & 1 deletion packages/office-ui-fabric-react/src/components/DetailsList/DetailsColumn.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ export class DetailsColumn extends BaseComponent<IDetailsColumnProps> {
ref={this._root}
role={'columnheader'}
aria-sort={column.isSorted ? (column.isSortedDescending ? 'descending' : 'ascending') : 'none'}
aria-disabled={column.columnActionsMode === ColumnActionsMode.disabled}
aria-colindex={columnIndex}
className={css(
'ms-DetailsHeader-cell',
Expand Down
2 changes: 0 additions & 2 deletions ...fice-ui-fabric-react/src/components/DetailsList/__snapshots__/DetailsHeader.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@ exports[`DetailsHeader can render 1`] = `
</div>
<div
aria-colindex={2}
aria-disabled={false}
aria-sort="none"
className="ms-DetailsHeader-cell is-actionable undefined"
data-automationid="ColumnsHeaderColumn"
Expand Down Expand Up @@ -186,7 +185,6 @@ exports[`DetailsHeader can render 1`] = `
/>
<div
aria-colindex={3}
aria-disabled={false}
aria-sort="none"
className="ms-DetailsHeader-cell is-actionable undefined"
data-automationid="ColumnsHeaderColumn"
Expand Down
1 change: 0 additions & 1 deletion ...office-ui-fabric-react/src/components/DetailsList/__snapshots__/DetailsList.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,6 @@ exports[`DetailsList renders List correctly 1`] = `
</div>
<div
aria-colindex={2}
aria-disabled={false}
aria-sort="none"
className="ms-DetailsHeader-cell is-actionable undefined"
data-automationid="ColumnsHeaderColumn"
Expand Down