TeachingBubble/Coachmark: Fix TeachingBubble content wrapping to next line unnecessarily #5121
Merged
leddie24 merged 4 commits intomicrosoft:masterfrom Jun 7, 2018
leddie24:coachmarkTeachingBubbleFix
Merged
TeachingBubble/Coachmark: Fix TeachingBubble content wrapping to next line unnecessarily #5121leddie24 merged 4 commits intomicrosoft:masterfrom leddie24:coachmarkTeachingBubbleFix
leddie24 merged 4 commits intomicrosoft:masterfrom
leddie24:coachmarkTeachingBubbleFix
Conversation
…c-react into coachmarkTeachingBubbleFix # Conflicts: # packages/office-ui-fabric-react/src/components/TeachingBubble/TeachingBubbleContent.tsx
Member
|
In your after example, it looks like you lost the close X. |
Member
|
the css hack is fine with me as long as it does what you need and passes tests. I'm curious about the 'isWide' added here. Was that leftover from something else? |
Collaborator
Author
|
Not sure what you mean by that. It's a prop for TeachingBubble, which isn't used at all by TeachingBubbleContent, that is providing an inconsistent max-width. |
dzearing
reviewed
Jun 6, 2018
| max-width: 364px; | ||
| border: 0; | ||
| box-shadow: none !important; | ||
| width: calc(100% + 1px); |
Member
There was a problem hiding this comment.
I'm confused why this is needed. Why not white-space: nowrap;
Collaborator
Author
There was a problem hiding this comment.
white-space: nowrap isn't desirable because we still want content to wrap.
micahgodbolt
approved these changes
Jun 7, 2018
oengusmacinog-zz
added a commit
that referenced
this pull request
Jun 11, 2018
* TeachingBubble/Coachmark: Fix TeachingBubble content wrapping to next line unnecessarily (#5121) * Fix teaching bubble breaking text into next line. * Add change file * Fix isWide variation of teaching bubble not inheriting max-width. * Customizable styles update (#5134) * @Customizable add styles to args * change log * Adds webpack-utils package; a fabric-optimized async loader (#5122) * adding a new fabric webpack plugin * adds fabric webpack-utils package * adds a peer dep definition * revert office-ui-fabric-react changes and adds a change file * addressing PR comments * moving down versions * api-extractor isn't needed * added some documentation for the loader * make sure not to publish for now, will publish after an initial manual push * adding some non-consequential prettier changes * Updated README.md so that the instruction is correct * Update npm version to 5.4.0 (#5137) * Website: Fix sideEffects for website tree shaking and add notes about testing (#5133) * Fix sideEffects * Update readme and add comments for testing minified files process * Added change files * Adding built in local check for index and removing webpack.config bits. * Fix example app base (#5139) * Fixing example app base. * updating change file * ContextualMenu: fix hover click submenu behavior (#5141) * ContextualMenu: Remove the ability for click to close a submenu. This aligns with windows behavior * rush change * Dropdown accessibility (#5138) * add listener in Callout for blur * Revert "add listener in Callout for blur" This reverts commit bb9c01a. * add option to active descendant and aria-label to option * change request file * update Dropdown snapshot tests after adding aria-label * Shimmer: adding new component to OUFR (#5067) * Brings an initial full copy of Shimmer from experiments. * Fix all imports. Remove ShimmerTile. * Rename IStyleFunction to IStyleFunctonOrObject * Renames getStyles to styles * Removes all deprecated props and warnings inherited from experiments package. * Adds markdown documentation. Adds 1 snapshot test. * Updates snapshot tests. * Adds a functional test to Shimmer * Write a test story-book * Story-book. * Adds more stories to the screener tests. * Adds one more story for custom elements. * Adds Shimmer to Fabric-website * Rush change logs. * Fixes a visual bug noticed in Fabric website. * Upsss... updates snapshots. * Formats everything according to new prettier rules. * More fixes for prettier formating rules. * Removes enum for verticalAlign prop and replaces it with strings. * Refactor the width prop to adress feedback. * Updates the snapshots. * Removes global styles for examples. * Fixes screener story for Shimmer. * Adds native props to the outer container. * Updates snapshots. * Fixes CI release job that passes --production flag to webpack-utils' tsc call (#5147) * adding a build script for webpack-utils because it builds differently than all other packages * adding change file * Revert back to npm 5.3.0 * basic setup for Fluent Styles page
2 tasks
dzearing
pushed a commit
that referenced
this pull request
Jul 24, 2018
…5656) * Cherry pick Coachmark: Positioning fixes (#4995) e87289b * Cherry pick TeachingBubble/Coachmark: Fix TeachingBubble content wrapping to next line unnecessarily (#5121) 72bab3c * Cherrry pick Fix import paths to use relative paths in product code (#5338) e2076e1 * Cherry pick Coachmark accessibility #5155 7a36bb9 * Revert formatting back to 5.0 in Coachmark.tsx * Fix unnecessary ; and change " to ' * Fix merge conflicts for Coachmark.Basic.Example.tsx * " to ' * Fix imports for TeachingBubble.tsx * Update TeachinBubbleContent, update TeachingBubble snapshot * Update snapshot. Fix TeachingBubble.types * Fix import for RefObject * Fix some inadvertent formatting from prettier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
TeachingBubble breaks the text intermittently to the next line, which sends an incorrect final height to the PositioningContainer and cuts off the TeachingBubble content.
Before:
After:
Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow