Fix import paths to use relative paths in product code#5338
Merged
dzearing merged 3 commits intomicrosoft:masterfrom Jun 26, 2018
leddie24:fixImportPaths
Merged
Fix import paths to use relative paths in product code#5338dzearing merged 3 commits intomicrosoft:masterfrom leddie24:fixImportPaths
dzearing merged 3 commits intomicrosoft:masterfrom
leddie24:fixImportPaths
Conversation
dzearing
requested changes
Jun 25, 2018
| import { IPositioningContainerTypes } from './PositioningContainer.types'; | ||
| import { getClassNames } from './PositioningContainer.styles'; | ||
| import { Layer } from 'office-ui-fabric-react/lib/Layer'; | ||
| import { Layer } from './../../Layer'; |
dzearing
approved these changes
Jun 26, 2018
2 tasks
dzearing
pushed a commit
that referenced
this pull request
Jul 24, 2018
…5656) * Cherry pick Coachmark: Positioning fixes (#4995) e87289b * Cherry pick TeachingBubble/Coachmark: Fix TeachingBubble content wrapping to next line unnecessarily (#5121) 72bab3c * Cherrry pick Fix import paths to use relative paths in product code (#5338) e2076e1 * Cherry pick Coachmark accessibility #5155 7a36bb9 * Revert formatting back to 5.0 in Coachmark.tsx * Fix unnecessary ; and change " to ' * Fix merge conflicts for Coachmark.Basic.Example.tsx * " to ' * Fix imports for TeachingBubble.tsx * Update TeachinBubbleContent, update TeachingBubble snapshot * Update snapshot. Fix TeachingBubble.types * Fix import for RefObject * Fix some inadvertent formatting from prettier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Fix import paths in product code to point to relative paths instead of 'office-ui-fabric-react/lib...' paths
Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow