Adds webpack-utils package; a fabric-optimized async loader by kenotron · Pull Request #5122 · microsoft/fluentui

kenotron · 2018-06-06T20:48:44Z

Pull request checklist

Addresses an existing issue: Fixes #0000
Include a change request file using $ npm run change
Microsoft Alias (if you have one):

Description of changes

With this change, I will add a new package dedicated to anything that we would do to optimize webpack usage with fabric. The first of these utils is the fabricAsyncLoader - it will allow apps to save on bundle size by move non-boot controls to be loaded asynchronously (e.g. ContextualMenu inside Button).

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

Markionium · 2018-06-06T21:01:49Z

packages/webpack-utils/tslint.json

+  "extends": ["office-ui-fabric-react-tslint"],
+  "rules": {
+    "deprecation": false,
+    "prefer-const": false


Why is this turned off? :)

Just copied from utilities :P

Markionium · 2018-06-06T21:02:20Z

packages/webpack-utils/jest.config.js

@@ -0,0 +1,7 @@
+let path = require('path');
+let { createConfig } = require('../../scripts/tasks/jest-resources');


Both of these can be consts?

yes - again, copied from utilities :)

Markionium · 2018-06-06T21:02:42Z

packages/webpack-utils/README.md

+`yarn add -D @uifabric/webpack-utils`
+
+
+## Fabric Async Loader


Super cool! :D

Markionium · 2018-06-06T21:03:28Z

packages/webpack-utils/.npmrc

@@ -0,0 +1,2 @@
+registry=https://registry.npmjs.org/


Isn't this the default? If so, do we need this?

oh wow, I keep copying stuff that I don't really need!

cliffkoh

Need more time to review..

cliffkoh · 2018-06-06T20:59:09Z

packages/webpack-utils/config/api-extractor.json.disabled

@@ -0,0 +1,6 @@
+{


API extractor isn't currently running and besides the entries in here are wrong.. :)

The build script is geared towards building lib and lib-commonjs which isn't desired in webpack utils

So I will delete this file then.

cliffkoh · 2018-06-07T02:20:54Z

common/changes/@uifabric/webpack-utils/loader_2018-06-06-20-44.json

+    {
+      "packageName": "@uifabric/webpack-utils",
+      "comment": "Creates a new webpack-utils package",
+      "type": "major"


Your first version published is going to be 2.0.0...

yeah maybe update the version to a 0, and do minor bumps until you're ready to do 1.0

I cranked it down to 0.0.1 with a minor change file

cliffkoh · 2018-06-07T03:00:50Z

packages/webpack-utils/src/fabricAsyncLoader.ts

+  ].join('');
+};
+
+export = fabricAsyncLoader;


Please add documentation to this file and also just use es6 syntax please :) (be consistent with rest of repo)

I can't use es6 syntax. Loaders need to be exported this way. I can add a little bit of doc but this loader doesn't do much yet (if ever?)

I had thought though that the .ts file is not used as the loader immediately, and in the compilation to js, this will turn into commonjs syntax and thereby become compatible...?

…l push

@Customizable

* TeachingBubble/Coachmark: Fix TeachingBubble content wrapping to next line unnecessarily (#5121) * Fix teaching bubble breaking text into next line. * Add change file * Fix isWide variation of teaching bubble not inheriting max-width. * Customizable styles update (#5134) * @Customizable add styles to args * change log * Adds webpack-utils package; a fabric-optimized async loader (#5122) * adding a new fabric webpack plugin * adds fabric webpack-utils package * adds a peer dep definition * revert office-ui-fabric-react changes and adds a change file * addressing PR comments * moving down versions * api-extractor isn't needed * added some documentation for the loader * make sure not to publish for now, will publish after an initial manual push * adding some non-consequential prettier changes * Updated README.md so that the instruction is correct * Update npm version to 5.4.0 (#5137) * Website: Fix sideEffects for website tree shaking and add notes about testing (#5133) * Fix sideEffects * Update readme and add comments for testing minified files process * Added change files * Adding built in local check for index and removing webpack.config bits. * Fix example app base (#5139) * Fixing example app base. * updating change file * ContextualMenu: fix hover click submenu behavior (#5141) * ContextualMenu: Remove the ability for click to close a submenu. This aligns with windows behavior * rush change * Dropdown accessibility (#5138) * add listener in Callout for blur * Revert "add listener in Callout for blur" This reverts commit bb9c01a. * add option to active descendant and aria-label to option * change request file * update Dropdown snapshot tests after adding aria-label * Shimmer: adding new component to OUFR (#5067) * Brings an initial full copy of Shimmer from experiments. * Fix all imports. Remove ShimmerTile. * Rename IStyleFunction to IStyleFunctonOrObject * Renames getStyles to styles * Removes all deprecated props and warnings inherited from experiments package. * Adds markdown documentation. Adds 1 snapshot test. * Updates snapshot tests. * Adds a functional test to Shimmer * Write a test story-book * Story-book. * Adds more stories to the screener tests. * Adds one more story for custom elements. * Adds Shimmer to Fabric-website * Rush change logs. * Fixes a visual bug noticed in Fabric website. * Upsss... updates snapshots. * Formats everything according to new prettier rules. * More fixes for prettier formating rules. * Removes enum for verticalAlign prop and replaces it with strings. * Refactor the width prop to adress feedback. * Updates the snapshots. * Removes global styles for examples. * Fixes screener story for Shimmer. * Adds native props to the outer container. * Updates snapshots. * Fixes CI release job that passes --production flag to webpack-utils' tsc call (#5147) * adding a build script for webpack-utils because it builds differently than all other packages * adding change file * Revert back to npm 5.3.0 * basic setup for Fluent Styles page

kenotron added 5 commits June 5, 2018 11:18

adding a new fabric webpack plugin

d572361

Merge branch 'master' into loader

7e503b1

adds fabric webpack-utils package

02a2582

adds a peer dep definition

ddf8717

revert office-ui-fabric-react changes and adds a change file

7456d77

kenotron requested a review from dzearing June 6, 2018 20:59

Markionium reviewed Jun 6, 2018

View reviewed changes

kenotron added 2 commits June 6, 2018 15:53

addressing PR comments

dd239ec

Merge remote-tracking branch 'origin/master' into loader

13faf8a

cliffkoh reviewed Jun 7, 2018

View reviewed changes

kenotron added 2 commits June 6, 2018 19:47

moving down versions

2db5bd7

api-extractor isn't needed

35c29f4

cliffkoh suggested changes Jun 7, 2018

View reviewed changes

added some documentation for the loader

4098e70

cliffkoh approved these changes Jun 7, 2018

View reviewed changes

kenotron added 3 commits June 7, 2018 09:56

make sure not to publish for now, will publish after an initial manua…

4bb196a

…l push

merge with master

ce9c73f

adding some non-consequential prettier changes

5861cb9

kenotron merged commit 08cd29e into microsoft:master Jun 7, 2018

kenotron deleted the loader branch June 7, 2018 22:05

microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019

		@@ -0,0 +1,7 @@
		let path = require('path');
		let { createConfig } = require('../../scripts/tasks/jest-resources');

Conversation

kenotron commented Jun 6, 2018 • edited by fabricteam Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request checklist

Description of changes

Focus areas to test

Microsoft Reviewers: Open in CodeFlow

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cliffkoh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kenotron commented Jun 6, 2018 •

edited by fabricteam

Loading