Experiments: moves ShimmerTile from Shimmer to Tile.#5090
Merged
dzearing merged 3 commits intomicrosoft:masterfrom Jun 5, 2018
Merged
Experiments: moves ShimmerTile from Shimmer to Tile.#5090dzearing merged 3 commits intomicrosoft:masterfrom
dzearing merged 3 commits intomicrosoft:masterfrom
Conversation
Contributor
Author
|
@ThomasMichon @atneik Can you guys give it a quick look? Thanks! |
dzearing
approved these changes
Jun 5, 2018
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Jun 6, 2018
* master: (31 commits) Charting (microsoft#4954) Deprecation lint rule! (microsoft#5109) Implement selection for selected items list (microsoft#5036) Ignore common/changes and don't prettify json files (microsoft#5112) Part 2 of demo page refactor (microsoft#5089) Update jest.js fixing official example page and datepicker/calendar components using… (microsoft#5108) Don't run prettier and tslint in parallel as it might cause conflicts (microsoft#5100) FocusTrapZone - restore last focused descendant element (microsoft#5103) Coachmark/TeachingBubble: Fix SCSS selectors for buttons and Close Icon (microsoft#4835) HoverCard: IE11 fix (microsoft#5105) FocusTrapZone bug allows breaking out of the trap (microsoft#4898) Applying package updates. Update ISSUE_TEMPLATE.md Experiment/Nav component: hide nav group header if all the links under it are hidden (microsoft#5095) Add optional prop to not dismiss Callout on focus loss (microsoft#5092) Experiments: moves ShimmerTile from Shimmer to Tile. (microsoft#5090) Run jest in parallel on Windows (microsoft#5096) Applying package updates. Major bump jest-serializer-merge-styles ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Due to Shimmer migration to OUFR it will eventually be removed from experiments package. Moving ShimmerTile to Tile component as it has a direct dependency on it and couldn't be migrated along with the rest of Shimmer control to OUFR because of it. Additionally I think it makes more sense to have it as a part of Tile, mostly because it's basically a mock of a Tile and itself alone will never render a shimmering animation.
When Shimmer is successfully merged into OUFR will get back to it to change some imports for a safe future removal of Shimmer from experiments.
Microsoft Reviewers: Open in CodeFlow