Charting by kkjeer · Pull Request #4954 · microsoft/fluentui

kkjeer · 2018-05-22T23:28:50Z

Pull request checklist

Addresses an existing issue: Fixes #0000
Include a change request file using $ npm run change

Description of changes

New experimental charting package with VerticalBarChart component.

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

…dd comments to interfaces

micahgodbolt · 2018-06-01T22:53:32Z

Would you have a chance to give us 30 min demo of the work you've done here?

dzearing · 2018-06-03T20:27:13Z

Can you merge master and rerun shrinkwrap?

…c-react into charting # Conflicts: # common/config/rush/npm-shrinkwrap.json

…c-react into charting # Conflicts: # common/changes/@uifabric/example-app-base/applied-prettier_2018-06-02-22-17.json # common/changes/@uifabric/experiments/applied-prettier_2018-06-02-22-17.json # common/changes/@uifabric/fabric-website/applied-prettier_2018-06-02-22-17.json # common/changes/@uifabric/file-type-icons/applied-prettier_2018-06-02-22-17.json # common/changes/@uifabric/icons/applied-prettier_2018-06-02-22-17.json # common/changes/@uifabric/jest-serializer-merge-styles/applied-prettier_2018-06-02-22-17.json # common/changes/@uifabric/merge-styles/applied-prettier_2018-06-02-22-17.json # common/changes/@uifabric/styling/applied-prettier_2018-06-02-22-17.json # common/changes/@uifabric/utilities/applied-prettier_2018-06-02-22-17.json # common/changes/@uifabric/variants/applied-prettier_2018-06-02-22-17.json # common/changes/office-ui-fabric-react/applied-prettier_2018-06-02-22-17.json # common/changes/office-ui-fabric-react/commandbar-fabricjs_2018-06-04-19-00.json

cliffkoh · 2018-06-05T18:29:23Z

common/changes/@uifabric/example-app-base/applied-prettier_2018-06-02-22-17.json

@@ -0,0 +1,11 @@
+{
+  "changes": [


This file should not be showing up as a new file created by you..

I pulled upstream/master into my local branch, committed, and then pushed to origin. I'd definitely appreciate tips for how to avoid having these files show up in my PRs.

cliffkoh · 2018-06-05T18:30:51Z

packages/charting/src/components/VerticalBarChart/VerticalBarChart.types.ts

+import { ITheme, IStyle } from '../../Styling';
+import { IStyleFunctionOrObject } from '../../Utilities';
+
+export interface IVerticalBarChart {


IVerticalBarChart [](start = 17, length = 17)

Empty interface?

Oh I see this is sort of a pattern we have at least in some places atm, although it is a little weird to see it.

It provides a place to add a public interface. I am ok with it, moreso than people not realizing there should be one.

cliffkoh · 2018-06-05T18:32:22Z

packages/charting/src/components/VerticalBarChart/VerticalBarChart.types.ts

+  theme: ITheme;
+  className?: string;
+  width: number;
+  height: number;


We should jsdoc all these (I looked at other *StyleProps and they were documented)

can be done in a future pr, but agree.

cliffkoh · 2018-06-05T18:36:09Z

packages/charting/src/demo/GettingStartedPage.tsx

+        <p>Within an npm project, you should install the package and save it as a dependency:</p>
+
+        <div className="ms-GettingStartedPage-code">
+          <Highlight className="bash">npm install --save office-ui-fabric-react</Highlight>


office-ui-fabric-react [](start = 57, length = 22)

A lot of the things on this page is not in sync with the package/page title..

This is the same as the Getting Started page from the experiments package, which also doesn't seem to match up with what's in experiments. I think updating these pages to match their packages is a separate work item.

cliffkoh · 2018-06-05T18:41:38Z

There is something wrong with the way master was merged into this branch and as such there are a lot of files that incorrectly show up as your changes.. :\

dzearing · 2018-06-06T04:55:45Z

packages/charting/src/components/VerticalBarChart/VerticalBarChartPage.tsx

+
+import { VerticalBarChartBasicExample } from './examples/VerticalBarChart.Basic.Example';
+
+const VerticalBarChartBasicExampleCode = require('!raw-loader!@uifabric/charting/src/components/VerticalBarChart/examples/VerticalBarChart.Basic.Example.tsx') as string;


may conflict with @kenotron pr.

This happens to be okay because it is not OUFR package itself. So it will need to be refactored before being promoted to OUFR.

* master: Part 2 of demo page refactor (microsoft#5089) Update jest.js fixing official example page and datepicker/calendar components using… (microsoft#5108) Don't run prettier and tslint in parallel as it might cause conflicts (microsoft#5100) FocusTrapZone - restore last focused descendant element (microsoft#5103) Coachmark/TeachingBubble: Fix SCSS selectors for buttons and Close Icon (microsoft#4835) HoverCard: IE11 fix (microsoft#5105)

Cleanup my mess

kenotron

Since this is mostly an experimental package, I think it's okay to get in a rough cut.

kenotron · 2018-06-06T17:02:53Z

packages/charting/src/components/VerticalBarChart/VerticalBarChartPage.tsx

+
+import { VerticalBarChartBasicExample } from './examples/VerticalBarChart.Basic.Example';
+
+const VerticalBarChartBasicExampleCode = require('!raw-loader!@uifabric/charting/src/components/VerticalBarChart/examples/VerticalBarChart.Basic.Example.tsx') as string;


This happens to be okay because it is not OUFR package itself. So it will need to be refactored before being promoted to OUFR.

kenotron · 2018-06-06T17:05:22Z

packages/charting/src/Styling.ts

@@ -0,0 +1 @@
+export * from 'office-ui-fabric-react/lib/Styling';


This and the Utilities.ts don't seem to be needed - perhaps we can just remove these?

They're used in VerticalBarChart.types.ts

* master: Charting (microsoft#4954) Deprecation lint rule! (microsoft#5109) Implement selection for selected items list (microsoft#5036) Ignore common/changes and don't prettify json files (microsoft#5112) Part 2 of demo page refactor (microsoft#5089) Update jest.js fixing official example page and datepicker/calendar components using… (microsoft#5108) Don't run prettier and tslint in parallel as it might cause conflicts (microsoft#5100) FocusTrapZone - restore last focused descendant element (microsoft#5103) Coachmark/TeachingBubble: Fix SCSS selectors for buttons and Close Icon (microsoft#4835) HoverCard: IE11 fix (microsoft#5105)

* master: Charting (microsoft#4954) Deprecation lint rule! (microsoft#5109) Implement selection for selected items list (microsoft#5036) Ignore common/changes and don't prettify json files (microsoft#5112)

* master: (31 commits) Charting (microsoft#4954) Deprecation lint rule! (microsoft#5109) Implement selection for selected items list (microsoft#5036) Ignore common/changes and don't prettify json files (microsoft#5112) Part 2 of demo page refactor (microsoft#5089) Update jest.js fixing official example page and datepicker/calendar components using… (microsoft#5108) Don't run prettier and tslint in parallel as it might cause conflicts (microsoft#5100) FocusTrapZone - restore last focused descendant element (microsoft#5103) Coachmark/TeachingBubble: Fix SCSS selectors for buttons and Close Icon (microsoft#4835) HoverCard: IE11 fix (microsoft#5105) FocusTrapZone bug allows breaking out of the trap (microsoft#4898) Applying package updates. Update ISSUE_TEMPLATE.md Experiment/Nav component: hide nav group header if all the links under it are hidden (microsoft#5095) Add optional prop to not dismiss Callout on focus loss (microsoft#5092) Experiments: moves ShimmerTile from Shimmer to Tile. (microsoft#5090) Run jest in parallel on Windows (microsoft#5096) Applying package updates. Major bump jest-serializer-merge-styles ...

Katherine Kjeer added 4 commits May 22, 2018 14:21

Add VerticalBarChart

c186b97

Update webpack config

f316614

Add source code to example page now that webpack config is working, a…

496dd00

…dd comments to interfaces

Add change file

e117482

Katherine Kjeer added 2 commits June 4, 2018 16:04

Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…

42437f6

…c-react into charting # Conflicts: # common/config/rush/npm-shrinkwrap.json

Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…

d5996e9

…c-react into charting # Conflicts: # common/config/rush/npm-shrinkwrap.json

kkjeer requested a review from dzearing as a code owner June 4, 2018 23:48

kkjeer requested a review from joschect as a code owner June 5, 2018 16:53

Update shrinkwrap

6c40d5e

cliffkoh reviewed Jun 5, 2018

View reviewed changes

Revert to master

e742738

kkjeer force-pushed the charting branch from a55c2e7 to e742738 Compare June 5, 2018 23:55

dzearing reviewed Jun 6, 2018

View reviewed changes

Markionium and others added 8 commits June 6, 2018 16:28

Revert change files

bf2673c

Remove change files

86efa77

Re-add charting change file

1ec8511

Reset more json

a01ee26

Reset common/changes to master

74b477d

Revert more conflicts?

681551b

Merge pull request #1 from Markionium/mark/charting

87017e2

Cleanup my mess

kenotron approved these changes Jun 6, 2018

View reviewed changes

kenotron merged commit 0d91de6 into microsoft:master Jun 6, 2018

kkjeer deleted the charting branch June 15, 2018 22:06

microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019


		import { VerticalBarChartBasicExample } from './examples/VerticalBarChart.Basic.Example';

		const VerticalBarChartBasicExampleCode = require('!raw-loader!@uifabric/charting/src/components/VerticalBarChart/examples/VerticalBarChart.Basic.Example.tsx') as string;

		@@ -0,0 +1 @@
		export * from 'office-ui-fabric-react/lib/Styling';

Conversation

kkjeer commented May 22, 2018 • edited by fabricteam Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request checklist

Description of changes

Focus areas to test

Microsoft Reviewers: Open in CodeFlow

Uh oh!

micahgodbolt commented Jun 1, 2018

Uh oh!

dzearing commented Jun 3, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cliffkoh commented Jun 5, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kenotron left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

kkjeer commented May 22, 2018 •

edited by fabricteam

Loading