Coachmark/TeachingBubble: Fix SCSS selectors for buttons and Close Icon#4835
Merged
kenotron merged 6 commits intomicrosoft:masterfrom Jun 5, 2018
leddie24:coachmarkSCSSFixes
Merged
Coachmark/TeachingBubble: Fix SCSS selectors for buttons and Close Icon#4835kenotron merged 6 commits intomicrosoft:masterfrom leddie24:coachmarkSCSSFixes
kenotron merged 6 commits intomicrosoft:masterfrom
leddie24:coachmarkSCSSFixes
Conversation
…n to Coachmark basic example
Member
|
Can you add a basic Coachmark snapshot test (from master before your PR), switch to your branch (with new test and snapshot present), then confirm the differences in the snapshot introduced by your PR make sense? Thanks |
dzearing
reviewed
May 15, 2018
|
|
||
| //Primary button style override | ||
| .root .primaryButton { | ||
| .primaryButton { |
Member
There was a problem hiding this comment.
removing specificity here could cause issues.
Member
There was a problem hiding this comment.
agreed...i'm guessing these styles are overriding previous styles...probably applied via a classname, so any change in load order could break this.
Member
There was a problem hiding this comment.
If you want to simplify this, you could pass the styles into the button styles prop
…c-react into coachmarkSCSSFixes # Conflicts: # packages/office-ui-fabric-react/src/components/Coachmark/examples/Coachmark.Basic.Example.tsx # packages/office-ui-fabric-react/src/components/TeachingBubble/TeachingBubble.scss
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Jun 6, 2018
* master: Part 2 of demo page refactor (microsoft#5089) Update jest.js fixing official example page and datepicker/calendar components using… (microsoft#5108) Don't run prettier and tslint in parallel as it might cause conflicts (microsoft#5100) FocusTrapZone - restore last focused descendant element (microsoft#5103) Coachmark/TeachingBubble: Fix SCSS selectors for buttons and Close Icon (microsoft#4835) HoverCard: IE11 fix (microsoft#5105)
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Jun 6, 2018
* master: Charting (microsoft#4954) Deprecation lint rule! (microsoft#5109) Implement selection for selected items list (microsoft#5036) Ignore common/changes and don't prettify json files (microsoft#5112) Part 2 of demo page refactor (microsoft#5089) Update jest.js fixing official example page and datepicker/calendar components using… (microsoft#5108) Don't run prettier and tslint in parallel as it might cause conflicts (microsoft#5100) FocusTrapZone - restore last focused descendant element (microsoft#5103) Coachmark/TeachingBubble: Fix SCSS selectors for buttons and Close Icon (microsoft#4835) HoverCard: IE11 fix (microsoft#5105)
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Jun 6, 2018
* master: (31 commits) Charting (microsoft#4954) Deprecation lint rule! (microsoft#5109) Implement selection for selected items list (microsoft#5036) Ignore common/changes and don't prettify json files (microsoft#5112) Part 2 of demo page refactor (microsoft#5089) Update jest.js fixing official example page and datepicker/calendar components using… (microsoft#5108) Don't run prettier and tslint in parallel as it might cause conflicts (microsoft#5100) FocusTrapZone - restore last focused descendant element (microsoft#5103) Coachmark/TeachingBubble: Fix SCSS selectors for buttons and Close Icon (microsoft#4835) HoverCard: IE11 fix (microsoft#5105) FocusTrapZone bug allows breaking out of the trap (microsoft#4898) Applying package updates. Update ISSUE_TEMPLATE.md Experiment/Nav component: hide nav group header if all the links under it are hidden (microsoft#5095) Add optional prop to not dismiss Callout on focus loss (microsoft#5092) Experiments: moves ShimmerTile from Shimmer to Tile. (microsoft#5090) Run jest in parallel on Windows (microsoft#5096) Applying package updates. Major bump jest-serializer-merge-styles ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Updates SCSS selectors to properly show teaching bubble close icon and primary/secondary button styles.
Old:
New:
I'm working on a separate PR for a lot of positioning fixes with Coachmark/TeachingBubble that will fix the cut off. It will be a big PR, so I wanted to separate this small style change in this PR first.
Focus areas to test
(optional)