ComboBox: Fix styling when navigating menu with single select #5017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… "selected" look when navigating through the potential options.
christiango
approved these changes
May 29, 2018
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
May 29, 2018
* master: ComboBox: Fix styling when navigating menu with single select (microsoft#5017) Use require.resolve logic in builds & watch .js files from node_modules (microsoft#5007) Fix onitem click for contextual menu with anchor item (microsoft#5003) CommandBar example: fix link color on website (microsoft#4975)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
The comboBox should not show a "selected" item other than the hovered/focused item. When the multiselect functionality was added a regression was introduced where the currently "selected" item could show the "selected" look even when it was not hovered/focused
The fix is to make sure we don't attempt to set a selected look if we are not multiselect and any other item has been hovered/focused
Focus areas to test
Verified that the hover/focus styling is behaving correctly again and multiselect was not affected
Microsoft Reviewers: Open in CodeFlow