Skip to content

ComboBox: Fix styling when navigating menu with single select #5017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jspurlin merged 3 commits into from
May 29, 2018
Merged

ComboBox: Fix styling when navigating menu with single select #5017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e9f714
ComboBox: Update styling so that the "selected" item does not get the…
jspurlin May 29, 2018
6906273
rush change
jspurlin May 29, 2018
450fc15
remove unneeded line change
jspurlin May 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...ice-ui-fabric-react/jspurlin-ComboBoxFixSelectedStylingSingleSelect_2018-05-29-20-33.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "ComboBox: Update styling so that the \"selected\" item does not get the \"selected\" look when navigating through the potential options.",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "[email protected]"
}
2 changes: 1 addition & 1 deletion packages/office-ui-fabric-react/src/components/ComboBox/ComboBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1177,7 +1177,7 @@ export class ComboBox extends BaseComponent<IComboBoxProps, IComboBoxState> {
}

let idxOfSelectedIndex = -1;
if ((index !== undefined) && this.state.selectedIndices) {
if (this.props.multiSelect && (index !== undefined) && this.state.selectedIndices) {
idxOfSelectedIndex = this.state.selectedIndices.indexOf(index);
}
return (idxOfSelectedIndex >= 0);
Expand Down