Use require.resolve logic in builds & watch .js files from node_modules #5007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssumptions of where node_modules is installed
JasonGore
reviewed
May 29, 2018
| const requireResolveCwd = require('../require-resolve-cwd'); | ||
|
|
||
| if (!pattern) { | ||
| return null; |
Member
There was a problem hiding this comment.
Would a build error be useful here or does this result in an error?
Contributor
Author
There was a problem hiding this comment.
It'll throw something like this:
TypeError: glob pattern string required
Now, I don't think we can ever get into this situation really because pattern is passed in from a key of a json object. I suppose I'm trying to be too cautious here.
JasonGore
approved these changes
May 29, 2018
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
May 29, 2018
* master: ComboBox: Fix styling when navigating menu with single select (microsoft#5017) Use require.resolve logic in builds & watch .js files from node_modules (microsoft#5007) Fix onitem click for contextual menu with anchor item (microsoft#5003) CommandBar example: fix link color on website (microsoft#4975)
kenotron
added a commit
to kenotron/fluentui
that referenced
this pull request
May 29, 2018
…de_modules (microsoft#5007)" This reverts commit 779932c.
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Lots of the scripts in the build tasks are doing so with a lot of assumptions on where the node_modules will end up. This change restores the use of the require.resolve logic. Several of the scripts deps have to be done by using require.resolve from scripts while others like copy & sass tasks have to use a "cwd" version.
Another issue addressed here is address
npm startalong with a dependent package. All this is needed to split up demo from components in a follow up PR.Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow