Fix bug for OWA+Safari+popup #4681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentBailly
requested review from
aditima,
cschleiden,
joschect and
micahgodbolt
as code owners
Member
|
You can remove the empty change files :) [edit] I mean the the ones with empty comments. |
dzearing
approved these changes
Apr 27, 2018
Member
|
Thanks! |
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Apr 27, 2018
* master: Added className to Calendar component (microsoft#4680) Fix bug for OWA+Safari+popup (microsoft#4681) Add optional props for custom divider rendering (microsoft#4687) Update package.json Add isEqual and isNotEqual utility (microsoft#4603) Fix minor typos (microsoft#4683) Allow function to be passed to Customizer settings/scopedSettings (microsoft#4677)
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Apr 27, 2018
* master: Added className to Calendar component (microsoft#4680) Fix bug for OWA+Safari+popup (microsoft#4681) Add optional props for custom divider rendering (microsoft#4687) Update package.json Add isEqual and isNotEqual utility (microsoft#4603) Fix minor typos (microsoft#4683) Allow function to be passed to Customizer settings/scopedSettings (microsoft#4677)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
In OWA, safari, popup buttons have grey background (instead of transparent).
This is because the logic OWA relies on to copy the style over to the popup window have a bug:
.h1{background: none} is added in the popup as .h1{background-image: none}.
The bug has been submitted to the Safari team, but we have no guaranty that they are going to fix it.
Repro of the Safari bug: https://codepen.io/VincentBailly/pen/pVbgob
