Skip to content

Fix bug for OWA+Safari+popup #4681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 2 commits into from
Apr 27, 2018
Merged

Fix bug for OWA+Safari+popup #4681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
290cac0
fix OWA-LPC-Safari bug
Apr 25, 2018
54badeb
fix tests and add change files
Apr 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/fabric-website/src/components/DOSearchBox/DOSearchBox.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@

.od-SearchBox-button {
background: none;
background-color: transparent;
border: 0;
color: transparent;
position: absolute;
Expand Down
11 changes: 11 additions & 0 deletions common/changes/@uifabric/example-app-base/master_2018-04-26-07-20.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "",
"packageName": "@uifabric/example-app-base",
"type": "none"
}
],
"packageName": "@uifabric/example-app-base",
"email": "vibailly@microsoft.com"
}
11 changes: 11 additions & 0 deletions common/changes/@uifabric/experiments/master_2018-04-26-07-20.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "",
"packageName": "@uifabric/experiments",
"type": "none"
}
],
"packageName": "@uifabric/experiments",
"email": "vibailly@microsoft.com"
}
11 changes: 11 additions & 0 deletions common/changes/@uifabric/fabric-website/master_2018-04-26-07-20.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "fix corner case bug with Safari",
"packageName": "@uifabric/fabric-website",
"type": "none"
}
],
"packageName": "@uifabric/fabric-website",
"email": "vibailly@microsoft.com"
}
1 change: 1 addition & 0 deletions packages/example-app-base/src/components/ExampleCard/ExampleCard.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
.ms-Button.ExampleCard-codeButton {
@include ms-margin-right(0);
background: none;
background-color: transparent;
border: 1px solid $ms-color-neutralTertiary;
border-bottom: 0;
border-top-left-radius: 4px;
Expand Down
1 change: 1 addition & 0 deletions packages/example-app-base/src/components/Header/Header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ $Header-fabricWebsiteHeaderColor: #272630;
position: relative;
text-decoration: none;
background: none;
background-color: transparent;
border: none;
padding: 0;
padding: 0px 10px;
Expand Down
1 change: 1 addition & 0 deletions packages/experiments/src/components/FloatingPicker/Suggestions/SuggestionsControl.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

.actionButton {
background: none;
background-color: transparent;
border: 0;
cursor: pointer;
margin: 0;
Expand Down
1 change: 1 addition & 0 deletions packages/experiments/src/components/Shimmer/Shimmer.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ export function getStyles(props: IShimmerStyleProps): IShimmerStyles {
opacity: '0',
lineHeight: '1',
background: 'none',
backgroundColor: 'transparent',
border: 'none',
transition: 'opacity 200ms'
},
Expand Down
1 change: 1 addition & 0 deletions packages/experiments/src/components/Tile/Tile.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@
@include right(0);
border: none;
background: none;
background-color: transparent;
opacity: 0;
box-sizing: border-box;
padding: 6px;
Expand Down
1 change: 1 addition & 0 deletions packages/office-ui-fabric-react/src/components/Checkbox/Checkbox.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ export const getStyles = memoizeFunction((
padding: '0',
border: 'none',
background: 'none',
backgroundColor: 'transparent',
margin: '0',
outline: 'none',
display: 'block',
Expand Down
1 change: 1 addition & 0 deletions packages/office-ui-fabric-react/src/components/Checkbox/__snapshots__/Checkbox.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ exports[`Checkbox renders Checkbox correctly 1`] = `
{
-moz-osx-font-smoothing: grayscale;
-webkit-font-smoothing: antialiased;
background-color: transparent;
background: none;
border: none;
cursor: pointer;
Expand Down
3 changes: 2 additions & 1 deletion packages/office-ui-fabric-react/src/components/CommandBar/CommandBar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ $SearchBox-sidePadding: 8px; // padding in input on left and right sides without

position: relative;
background: none;
background-color: transparent;
border: none;
line-height: $CommandBarItem-height;
min-width: 20px;
Expand Down Expand Up @@ -172,7 +173,7 @@ $SearchBox-sidePadding: 8px; // padding in input on left and right sides without
&.itemLinkIsExpanded:hover {
background-color: $ms-color-neutralQuaternary;
}

&.inactive {
color: $ms-color-neutralTertiaryAlt;
cursor: default;
Expand Down
1 change: 1 addition & 0 deletions packages/office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ export const getStyles = memoizeFunction((
fontWeight: FontWeights.semibold,
color: ContextualMenuHeaderColor,
background: 'none',
backgroundColor: 'transparent',
border: 'none',
height: ContextualMenuItemHeight,
lineHeight: ContextualMenuItemHeight,
Expand Down
1 change: 1 addition & 0 deletions packages/office-ui-fabric-react/src/components/DetailsList/DetailsRowCheck.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
box-sizing: border-box;
vertical-align: top;
background: none;
background-color: transparent;
border: none;
opacity: 0;

Expand Down
1 change: 1 addition & 0 deletions packages/office-ui-fabric-react/src/components/Dropdown/Dropdown.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,7 @@ $DropDown-item-height: 32px;
font-weight: $ms-font-weight-semibold;
color: $ms-color-themePrimary;
background: none;
background-color: transparent;
border: none;
height: $DropDown-item-height;
line-height: $DropDown-item-height;
Expand Down
1 change: 1 addition & 0 deletions packages/office-ui-fabric-react/src/components/Facepile/Facepile.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ $spacingAroundItemButton: 2px;
button.itemButton {
display: inline;
background: none;
background-color: transparent;
padding: 0;
cursor: pointer;
border: none;
Expand Down
1 change: 1 addition & 0 deletions packages/office-ui-fabric-react/src/components/GroupedList/GroupHeader.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ $groupHeader-ease-in-back: cubic-bezier(0.600, -0.280, 0.735, 0.045);
@include focus-border();
cursor: default;
background: none;
background-color: transparent;
border: none;
font-size: $ms-icon-size-l;
}
Expand Down
1 change: 1 addition & 0 deletions ...ffice-ui-fabric-react/src/components/GroupedList/examples/GroupedList.Custom.Example.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
box-sizing: border-box;
vertical-align: top;
background: none;
background-color: transparent;
border: none;
padding-left: 32px;
}
Expand Down
1 change: 1 addition & 0 deletions packages/office-ui-fabric-react/src/components/Link/Link.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ export const getStyles = (props: ILinkStyleProps): ILinkStyles => {
},
isButton && {
background: 'none',
backgroundColor: 'transparent',
border: 'none',
cursor: 'pointer',
display: 'inline',
Expand Down
2 changes: 2 additions & 0 deletions packages/office-ui-fabric-react/src/components/Link/__snapshots__/Link.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ exports[`Link renders Link with no href as a button 1`] = `
className=
ms-Link
{
background-color: transparent;
background: none;
border: none;
color: #0078d4;
Expand Down Expand Up @@ -177,6 +178,7 @@ exports[`Link renders disabled Link with no href as a button correctly 1`] = `
ms-Link
is-disabled
{
background-color: transparent;
background: none;
border: none;
color: #a6a6a6;
Expand Down
2 changes: 2 additions & 0 deletions packages/office-ui-fabric-react/src/components/MarqueeSelection/MarqueeSelection.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

@include high-contrast {
background: none;
background-color: transparent;
}
}

Expand Down Expand Up @@ -42,5 +43,6 @@

@include high-contrast {
background: none;
background-color: transparent;
}
}
1 change: 1 addition & 0 deletions packages/office-ui-fabric-react/src/components/Rating/Rating.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ export function getStyles(props: IRatingStyleProps): IRatingStyles {
'ms-Rating-button',
{
background: 'none',
backgroundColor: 'transparent',
margin: '3px 3px 0px 0px',
padding: '0px',
border: 'none',
Expand Down
5 changes: 5 additions & 0 deletions packages/office-ui-fabric-react/src/components/Rating/__snapshots__/Rating.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ exports[`Rating Renders Rating correctly 1`] = `
ms-Rating-button
ms-Rating--small
{
background-color: transparent;
background: none;
border: none;
cursor: pointer;
Expand Down Expand Up @@ -153,6 +154,7 @@ exports[`Rating Renders Rating correctly 1`] = `
ms-Rating-button
ms-Rating--small
{
background-color: transparent;
background: none;
border: none;
cursor: pointer;
Expand Down Expand Up @@ -276,6 +278,7 @@ exports[`Rating Renders Rating correctly 1`] = `
ms-Rating-button
ms-Rating--small
{
background-color: transparent;
background: none;
border: none;
cursor: pointer;
Expand Down Expand Up @@ -399,6 +402,7 @@ exports[`Rating Renders Rating correctly 1`] = `
ms-Rating-button
ms-Rating--small
{
background-color: transparent;
background: none;
border: none;
cursor: pointer;
Expand Down Expand Up @@ -522,6 +526,7 @@ exports[`Rating Renders Rating correctly 1`] = `
ms-Rating-button
ms-Rating--small
{
background-color: transparent;
background: none;
border: none;
cursor: pointer;
Expand Down
1 change: 1 addition & 0 deletions packages/office-ui-fabric-react/src/components/TextField/TextField.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ $field-error-color: $errorTextColor;
border-radius: 0;
border: none;
background: none;
background-color: transparent;
color: $field-text-color;
@include ms-padding(0, 12px, 0, 12px);
width: 100%;
Expand Down
1 change: 1 addition & 0 deletions packages/office-ui-fabric-react/src/components/pickers/Suggestions/Suggestions.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@

.actionButton {
background: none;
background-color: transparent;
border: 0;
cursor: pointer;
margin: 0;
Expand Down
2 changes: 2 additions & 0 deletions packages/office-ui-fabric-react/src/utilities/selection/examples/Selection.Example.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
box-sizing: border-box;
vertical-align: top;
background: none;
background-color: transparent;
border: none;
}

Expand All @@ -24,6 +25,7 @@
box-sizing: border-box;
vertical-align: top;
background: none;
background-color: transparent;
border: none;
}

Expand Down