Allow function to be passed to Customizer settings/scopedSettings #4677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cliffkoh
reviewed
Apr 25, 2018
| return mergeSettingsWith(oldSettings); | ||
| } | ||
|
|
||
| function isSettingsFunction(settings?: Settings | SettingsFunction): settings is SettingsFunction { |
| export type Settings = { [key: string]: any }; | ||
| export type SettingsFunction = (settings: Settings) => Settings; | ||
|
|
||
| export type ICustomizerProps = Partial<{ |
Contributor
There was a problem hiding this comment.
ICustomizations is now unused? Should you delete it?
Member
Author
There was a problem hiding this comment.
It's not really unused as the type is still used for the CustomizerContext and GlobalSettings.getValue. But we could indeed do a bit of cleanup, so i made some minor changes.
| export type SettingsFunction = (settings: Settings) => Settings; | ||
|
|
||
| export type ICustomizerProps = Partial<{ | ||
| settings: Settings | SettingsFunction; |
Contributor
There was a problem hiding this comment.
Could you please add jsdoc to these?
Member
Author
cliffkoh
approved these changes
Apr 26, 2018
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Apr 27, 2018
* master: Added className to Calendar component (microsoft#4680) Fix bug for OWA+Safari+popup (microsoft#4681) Add optional props for custom divider rendering (microsoft#4687) Update package.json Add isEqual and isNotEqual utility (microsoft#4603) Fix minor typos (microsoft#4683) Allow function to be passed to Customizer settings/scopedSettings (microsoft#4677)
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Apr 27, 2018
* master: Added className to Calendar component (microsoft#4680) Fix bug for OWA+Safari+popup (microsoft#4681) Add optional props for custom divider rendering (microsoft#4687) Update package.json Add isEqual and isNotEqual utility (microsoft#4603) Fix minor typos (microsoft#4683) Allow function to be passed to Customizer settings/scopedSettings (microsoft#4677)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Allows a function to be passed to the
<Customizer />This enables you to do the following
Bar would receive field="HelloWorld".
Focus areas to test
(optional)