Theme designer: Move colors to local files #27191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahgodbolt
changed the title
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: b6fd0db0a8c5553f9d4a84fcf9cd9a0ae97dea48 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f8b6903:
|
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1301 | 1324 | 5000 | |
| Button | mount | 955 | 958 | 5000 | |
| Field | mount | 2023 | 2055 | 5000 | |
| FluentProvider | mount | 1650 | 1658 | 5000 | |
| FluentProviderWithTheme | mount | 639 | 629 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 600 | 595 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 618 | 634 | 10 | |
| InfoButton | mount | 574 | 562 | 5000 | |
| MakeStyles | mount | 1893 | 1907 | 50000 | |
| Persona | mount | 3058 | 3084 | 5000 | |
| SpinButton | mount | 2439 | 2469 | 5000 |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
🕵 FluentUI-v0 No visual regressions between this PR and main |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1410 | 1413 | 5000 | |
| Breadcrumb | mount | 3557 | 3562 | 1000 | |
| Checkbox | mount | 3167 | 3187 | 5000 | |
| CheckboxBase | mount | 2896 | 2802 | 5000 | |
| ChoiceGroup | mount | 5361 | 5318 | 5000 | |
| ComboBox | mount | 1448 | 1510 | 1000 | |
| CommandBar | mount | 11593 | 11594 | 1000 | |
| ContextualMenu | mount | 16753 | 17075 | 1000 | |
| DefaultButton | mount | 1690 | 1671 | 5000 | |
| DetailsRow | mount | 4098 | 4194 | 5000 | |
| DetailsRowFast | mount | 4047 | 4068 | 5000 | |
| DetailsRowNoStyles | mount | 3988 | 3919 | 5000 | |
| Dialog | mount | 3678 | 3684 | 1000 | |
| DocumentCardTitle | mount | 688 | 686 | 1000 | |
| Dropdown | mount | 3832 | 3875 | 5000 | |
| FocusTrapZone | mount | 2410 | 2410 | 5000 | |
| FocusZone | mount | 2296 | 2385 | 5000 | |
| GroupedList | mount | 60232 | 66882 | 2 | |
| GroupedList | virtual-rerender | 28753 | 28157 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 106896 | 107843 | 2 | |
| GroupedListV2 | mount | 692 | 689 | 2 | |
| GroupedListV2 | virtual-rerender | 642 | 648 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 672 | 673 | 2 | |
| IconButton | mount | 2272 | 2253 | 5000 | |
| Label | mount | 868 | 890 | 5000 | |
| Layer | mount | 5201 | 5161 | 5000 | |
| Link | mount | 1029 | 963 | 5000 | |
| MenuButton | mount | 1984 | 1984 | 5000 | |
| MessageBar | mount | 2726 | 2895 | 5000 | |
| Nav | mount | 3923 | 3826 | 1000 | |
| OverflowSet | mount | 1641 | 1696 | 5000 | |
| Panel | mount | 3028 | 3000 | 1000 | |
| Persona | mount | 1554 | 1595 | 1000 | |
| Pivot | mount | 1962 | 1980 | 1000 | |
| PrimaryButton | mount | 1869 | 1839 | 5000 | |
| Rating | mount | 8243 | 8313 | 5000 | |
| SearchBox | mount | 1764 | 1801 | 5000 | |
| Shimmer | mount | 3348 | 3453 | 5000 | |
| Slider | mount | 2624 | 2689 | 5000 | |
| SpinButton | mount | 5476 | 5584 | 5000 | |
| Spinner | mount | 950 | 972 | 5000 | |
| SplitButton | mount | 3629 | 3687 | 5000 | |
| Stack | mount | 977 | 1005 | 5000 | |
| StackWithIntrinsicChildren | mount | 2722 | 2721 | 5000 | |
| StackWithTextChildren | mount | 5632 | 5687 | 5000 | |
| SwatchColorPicker | mount | 12118 | 12261 | 5000 | |
| TagPicker | mount | 3051 | 3091 | 5000 | |
| TeachingBubble | mount | 103702 | 103344 | 5000 | |
| Text | mount | 928 | 972 | 5000 | |
| TextField | mount | 1944 | 1914 | 5000 | |
| ThemeProvider | mount | 1892 | 1876 | 5000 | |
| ThemeProvider | virtual-rerender | 1301 | 1333 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2534 | 2576 | 5000 | |
| Toggle | mount | 1351 | 1340 | 5000 | |
| buttonNative | mount | 643 | 671 | 5000 |
TristanWatanabe
approved these changes
Mar 14, 2023
GeoffCoxMSFT
pushed a commit
to GeoffCoxMSFT/fluentui
that referenced
this pull request
Mar 14, 2023
* move colors code locally to allow for customization * clean up files
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Mar 15, 2023
* master: (141 commits) chore: prerequisite changes before migrating v9 packages to SWC based transpilation (microsoft#26965) feat: Add InfoLabel component (microsoft#27118) fix(tools): update migrate-converged generator to add node field to package.json exports map (microsoft#27152) applying package updates fix: Embed play/pause indicator should render correctly in high contrast mode (microsoft#27213) feat(tokens): Add colorNeutralBackgroundAlpha and colorNeutralStrokeAlpha tokens (microsoft#27034) chore: Prepare release 0.66.4 (microsoft#27163) fix(react-datepicker-compat): Fix text entry issues with input (microsoft#27204) fix: Smooth out animation of indeterminate progress bar (microsoft#27201) Add cxe-red as a codeowner of react-file-type-icons (microsoft#27147) Added documentation about custom style hooks (microsoft#27087) Custom style react-text (microsoft#27078) Custom style react-image (microsoft#27066) Add JSDoc for tabster focus indicator selector (microsoft#27041) Theme designer: Move colors to local files (microsoft#27191) docs(react-card): move card out of preview (microsoft#27185) Include values in typography table (microsoft#27189) feat: accept a className in `mountNode` in `Portal` (microsoft#27008) RFC: Extend `mountNode` prop in `Portal` (microsoft#27009) applying package updates ...
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Mar 15, 2023
* master: (141 commits) chore: prerequisite changes before migrating v9 packages to SWC based transpilation (microsoft#26965) feat: Add InfoLabel component (microsoft#27118) fix(tools): update migrate-converged generator to add node field to package.json exports map (microsoft#27152) applying package updates fix: Embed play/pause indicator should render correctly in high contrast mode (microsoft#27213) feat(tokens): Add colorNeutralBackgroundAlpha and colorNeutralStrokeAlpha tokens (microsoft#27034) chore: Prepare release 0.66.4 (microsoft#27163) fix(react-datepicker-compat): Fix text entry issues with input (microsoft#27204) fix: Smooth out animation of indeterminate progress bar (microsoft#27201) Add cxe-red as a codeowner of react-file-type-icons (microsoft#27147) Added documentation about custom style hooks (microsoft#27087) Custom style react-text (microsoft#27078) Custom style react-image (microsoft#27066) Add JSDoc for tabster focus indicator selector (microsoft#27041) Theme designer: Move colors to local files (microsoft#27191) docs(react-card): move card out of preview (microsoft#27185) Include values in typography table (microsoft#27189) feat: accept a className in `mountNode` in `Portal` (microsoft#27008) RFC: Extend `mountNode` prop in `Portal` (microsoft#27009) applying package updates ...
TristanWatanabe
pushed a commit
to TristanWatanabe/fluentui
that referenced
this pull request
Dec 7, 2023
* move colors code locally to allow for customization * clean up files
TristanWatanabe
added a commit
that referenced
this pull request
Dec 13, 2023
* chore: migrate to node 18 (#29598) * chore: migrate to node 18 * chore: bump eslint-plugin-jsdoc which support node 18 * generate changefile * chore: ignore plugin-jsdoc from syncpack * chore(utilities): use Timers types based on environment to avoid TS failures introduced with node 18 types * chore: bump babel-loader to mitigate '0308010c:digital envelope routines::unsupported' webpack error within local-sandbox * generate changefiles * restrict node version * update yarn.lock * ci: bump devcontainer to node 18 (#29759) * deduplicate semver * theme designers: changes based on dan and daisy's feedback (#24038) * for daisy: Can the default theme be the Web one (not Teams)? Web should be the first one selected by default. Teams is one option in the menu. * suggestion from dan: when he inputted his own custom Hex#, the color indicator to the right didn't change -- added rules to hex input * remove teams theme * capitalize for consistency * custom theme now applies to sidebar per dan's request * uppercase consistency * revert sidebar change * theme designer: make name editable (#24098) * add dropdown * Update yarn.lock * cleanup dropdown use * lock update * remove unread values * use dropdown + add avatar * add editable name * palette change * force alphanumeric * filter input name string * update name * revert palette change Co-authored-by: Micah Godbolt <[email protected]> * Theme designer: Move colors to local files (#27191) * move colors code locally to allow for customization * clean up files * deduplicate prettier * fix: UseNode@1 instead of NodeTool * format files * chore: bump babel-loader to mitigate '0308010c:digital envelope routines::unsupported' webpack error within local-sandbox * update yarn.lock * chore: comment out unused codeblock to fix TS transpile errors --------- Co-authored-by: Martin Hochel <[email protected]> Co-authored-by: Emma Jiang <[email protected]> Co-authored-by: Micah Godbolt <[email protected]>
chrisdholt
pushed a commit
that referenced
this pull request
Apr 29, 2024
* chore: migrate to node 18 (#29598) * chore: migrate to node 18 * chore: bump eslint-plugin-jsdoc which support node 18 * generate changefile * chore: ignore plugin-jsdoc from syncpack * chore(utilities): use Timers types based on environment to avoid TS failures introduced with node 18 types * chore: bump babel-loader to mitigate '0308010c:digital envelope routines::unsupported' webpack error within local-sandbox * generate changefiles * restrict node version * update yarn.lock * ci: bump devcontainer to node 18 (#29759) * deduplicate semver * theme designers: changes based on dan and daisy's feedback (#24038) * for daisy: Can the default theme be the Web one (not Teams)? Web should be the first one selected by default. Teams is one option in the menu. * suggestion from dan: when he inputted his own custom Hex#, the color indicator to the right didn't change -- added rules to hex input * remove teams theme * capitalize for consistency * custom theme now applies to sidebar per dan's request * uppercase consistency * revert sidebar change * theme designer: make name editable (#24098) * add dropdown * Update yarn.lock * cleanup dropdown use * lock update * remove unread values * use dropdown + add avatar * add editable name * palette change * force alphanumeric * filter input name string * update name * revert palette change Co-authored-by: Micah Godbolt <[email protected]> * Theme designer: Move colors to local files (#27191) * move colors code locally to allow for customization * clean up files * deduplicate prettier * fix: UseNode@1 instead of NodeTool * format files * chore: bump babel-loader to mitigate '0308010c:digital envelope routines::unsupported' webpack error within local-sandbox * update yarn.lock * chore: comment out unused codeblock to fix TS transpile errors --------- Co-authored-by: Martin Hochel <[email protected]> Co-authored-by: Emma Jiang <[email protected]> Co-authored-by: Micah Godbolt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Soon we'll be making some adjustments to how our colors are calculated. This will require the logic used to calculate colors to be easier to modify. This PR pulls in all of the color files from the @fluentblocks/colors package https://github.com/OfficeDev/fluent-blocks/tree/next/packages/colors