Skip to content

fix(Dialog): Add displayName for dialog footer and content #28939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sopranopillow merged 4 commits into from
Aug 24, 2023
Merged

fix(Dialog): Add displayName for dialog footer and content #28939

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9bb0f80
add displayName for dialog footer and content
Aug 22, 2023
ecd72ab
yarn change
Aug 23, 2023
86991e5
Update change/@fluentui-react-e393acc7-f1bd-4632-9c6d-359924839807.json
ymyqwe Aug 24, 2023
30fd864
Merge branch 'master' into add_dialog_name
sopranopillow Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-e393acc7-f1bd-4632-9c6d-359924839807.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "add displayName to dialog footer and content",
Comment thread
ymyqwe marked this conversation as resolved.
Outdated
"packageName": "@fluentui/react",
"email": "mingyuanyu@microsoft.com",
"dependentChangeType": "patch"
}
2 changes: 2 additions & 0 deletions packages/react/src/components/Dialog/DialogContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,5 @@ export const DialogContent: React.FunctionComponent<IDialogContentProps> = style
IDialogContentStyleProps,
IDialogContentStyles
>(DialogContentBase, getStyles, undefined, { scope: 'DialogContent' });

DialogContent.displayName = 'DialogContent';
2 changes: 2 additions & 0 deletions packages/react/src/components/Dialog/DialogFooter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,5 @@ export const DialogFooter: React.FunctionComponent<IDialogFooterProps> = styled<
IDialogFooterStyleProps,
IDialogFooterStyles
>(DialogFooterBase, getStyles, undefined, { scope: 'DialogFooter' });

DialogFooter.displayName = 'DialogFooter';