chore: Updating @fluentui/react-icons to version 2.0.207 #28590

tomi-msft · 2023-07-19T22:07:26Z

This PR is to update the version of @fluentui/react-icons in the repo to pick up ref forwarding.

change/@fluentui-react-avatar-b5fcd0d1-345c-4e84-9715-df646c74a3c9.json

codesandbox-ci · 2023-07-19T22:19:43Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3b89957:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2023-07-19T22:35:58Z

Perf Analysis (`@fluentui/react-components`)

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
FluentProviderWithTheme	mount	72	71	10	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
Avatar	mount	603	597	5000
Button	mount	297	295	5000
Field	mount	1054	1056	5000
FluentProvider	mount	645	660	5000
FluentProviderWithTheme	mount	72	71	10	Possible regression
FluentProviderWithTheme	virtual-rerender	69	68	10
FluentProviderWithTheme	virtual-rerender-with-unmount	70	77	10
InfoButton	mount	12	8	5000
MakeStyles	mount	842	871	50000
Persona	mount	1615	1642	5000
SpinButton	mount	1320	1316	5000

fabricteam · 2023-07-19T22:38:26Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
SegmentMinimalPerf.default	208	192	1.08:1
IconMinimalPerf.default	390	362	1.08:1
PortalMinimalPerf.default	89	83	1.07:1
TreeWith60ListItems.default	94	88	1.07:1
ChatWithPopoverPerf.default	191	181	1.06:1
LabelMinimalPerf.default	224	212	1.06:1
RefMinimalPerf.default	115	109	1.06:1
RosterPerf.default	1574	1497	1.05:1
RadioGroupMinimalPerf.default	276	263	1.05:1
TableMinimalPerf.default	246	235	1.05:1
DatepickerMinimalPerf.default	3732	3601	1.04:1
FlexMinimalPerf.default	163	156	1.04:1
ListNestedPerf.default	336	322	1.04:1
ListWith60ListItems.default	377	362	1.04:1
AlertMinimalPerf.default	152	148	1.03:1
ListCommonPerf.default	403	391	1.03:1
SplitButtonMinimalPerf.default	2342	2275	1.03:1
TextAreaMinimalPerf.default	302	294	1.03:1
TooltipMinimalPerf.default	1282	1247	1.03:1
ButtonMinimalPerf.default	91	89	1.02:1
CheckboxMinimalPerf.default	1177	1158	1.02:1
LayoutMinimalPerf.default	214	209	1.02:1
SkeletonMinimalPerf.default	206	202	1.02:1
TableManyItemsPerf.default	1132	1110	1.02:1
AnimationMinimalPerf.default	308	305	1.01:1
AttachmentMinimalPerf.default	85	84	1.01:1
ChatMinimalPerf.default	433	427	1.01:1
DialogMinimalPerf.default	459	453	1.01:1
DropdownMinimalPerf.default	1433	1421	1.01:1
EmbedMinimalPerf.default	1911	1896	1.01:1
HeaderMinimalPerf.default	212	209	1.01:1
HeaderSlotsPerf.default	468	463	1.01:1
ProviderMinimalPerf.default	202	200	1.01:1
StatusMinimalPerf.default	400	395	1.01:1
AccordionMinimalPerf.default	85	85	1:1
AttachmentSlotsPerf.default	643	640	1:1
AvatarMinimalPerf.default	116	116	1:1
FormMinimalPerf.default	231	232	1:1
ImageMinimalPerf.default	233	234	1:1
ItemLayoutMinimalPerf.default	710	712	1:1
ListMinimalPerf.default	302	301	1:1
MenuMinimalPerf.default	498	497	1:1
MenuButtonMinimalPerf.default	968	972	1:1
ToolbarMinimalPerf.default	532	533	1:1
TreeMinimalPerf.default	481	481	1:1
CardMinimalPerf.default	310	312	0.99:1
CarouselMinimalPerf.default	257	260	0.99:1
SliderMinimalPerf.default	741	750	0.99:1
ButtonOverridesMissPerf.default	656	670	0.98:1
ProviderMergeThemesPerf.default	670	687	0.98:1
CustomToolbarPrototype.default	1478	1506	0.98:1
VideoMinimalPerf.default	433	443	0.98:1
DividerMinimalPerf.default	201	208	0.97:1
DropdownManyItemsPerf.default	382	392	0.97:1
GridMinimalPerf.default	185	191	0.97:1
TextMinimalPerf.default	191	196	0.97:1
PopupMinimalPerf.default	345	358	0.96:1
ReactionMinimalPerf.default	210	218	0.96:1
InputMinimalPerf.default	524	551	0.95:1
BoxMinimalPerf.default	188	200	0.94:1
ButtonSlotsPerf.default	308	327	0.94:1
ChatDuplicateMessagesPerf.default	140	150	0.93:1
LoaderMinimalPerf.default	195	210	0.93:1

fabricteam · 2023-07-19T22:39:00Z

🕵 fluentuiv8 No visual regressions between this PR and main

fabricteam · 2023-07-19T22:44:42Z

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam · 2023-07-19T22:45:07Z

📊 Bundle size report

Package & Exports	Baseline (minified/GZIP)	PR	Change
`react-accordion` Accordion (including children components)	`88.26 kB` `26.718 kB`	`88.286 kB` `26.724 kB`	`26 B` `6 B`
`react-alert` Alert	`84.966 kB` `22.022 kB`	`84.992 kB` `22.03 kB`	`26 B` `8 B`
`react-avatar` Avatar	`47.713 kB` `14.513 kB`	`47.739 kB` `14.521 kB`	`26 B` `8 B`
`react-avatar` AvatarGroupItem	`63.889 kB` `18.993 kB`	`63.915 kB` `19.001 kB`	`26 B` `8 B`
`react-badge` PresenceBadge	`22.227 kB` `7.881 kB`	`22.253 kB` `7.891 kB`	`26 B` `10 B`
`react-button` MenuButton	`43.527 kB` `10.967 kB`	`43.553 kB` `10.979 kB`	`26 B` `12 B`
`react-button` SplitButton	`51.732 kB` `12.563 kB`	`51.758 kB` `12.571 kB`	`26 B` `8 B`
`react-checkbox` Checkbox	`33.198 kB` `10.718 kB`	`33.224 kB` `10.727 kB`	`26 B` `9 B`
`react-combobox` Combobox (including child components)	`87.173 kB` `28.125 kB`	`87.199 kB` `28.143 kB`	`26 B` `18 B`
`react-combobox` Dropdown (including child components)	`85.576 kB` `27.723 kB`	`85.602 kB` `27.746 kB`	`26 B` `23 B`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`213.085 kB` `59.114 kB`	`213.111 kB` `59.12 kB`	`26 B` `6 B`
`react-datepicker-compat` DatePicker Compat	`223.368 kB` `59.265 kB`	`223.394 kB` `59.277 kB`	`26 B` `12 B`
`react-dialog` Dialog (including children components)	`92.736 kB` `27.579 kB`	`92.762 kB` `27.587 kB`	`26 B` `8 B`
`react-field` Field	`18.148 kB` `6.97 kB`	`18.174 kB` `6.977 kB`	`26 B` `7 B`
`react-infobutton` InfoButton	`131.335 kB` `40.311 kB`	`131.361 kB` `40.326 kB`	`26 B` `15 B`
`react-infobutton` InfoLabel	`134.94 kB` `41.443 kB`	`134.966 kB` `41.462 kB`	`26 B` `19 B`
`react-menu` Menu (including children components)	`132.677 kB` `40.613 kB`	`132.703 kB` `40.62 kB`	`26 B` `7 B`
`react-menu` Menu (including selectable components)	`135.441 kB` `41.106 kB`	`135.467 kB` `41.115 kB`	`26 B` `9 B`
`react-persona` Persona	`55.267 kB` `16.525 kB`	`55.293 kB` `16.535 kB`	`26 B` `10 B`
`react-radio` Radio	`26.991 kB` `8.626 kB`	`27.017 kB` `8.638 kB`	`26 B` `12 B`
`react-select` Select	`24.929 kB` `8.713 kB`	`24.955 kB` `8.722 kB`	`26 B` `9 B`
`react-spinbutton` SpinButton	`33.73 kB` `10.337 kB`	`33.756 kB` `10.35 kB`	`26 B` `13 B`
`react-switch` Switch	`29.485 kB` `9.228 kB`	`29.511 kB` `9.239 kB`	`26 B` `11 B`
`react-table` DataGrid	`158.282 kB` `43.276 kB`	`158.308 kB` `43.284 kB`	`26 B` `8 B`
`react-table` Table (Primitives only)	`44.666 kB` `12.442 kB`	`44.692 kB` `12.447 kB`	`26 B` `5 B`
`react-table` Table as DataGrid	`132.365 kB` `33.849 kB`	`132.392 kB` `33.862 kB`	`27 B` `13 B`
`react-table` Table (Selection only)	`77.993 kB` `19.245 kB`	`78.019 kB` `19.252 kB`	`26 B` `7 B`
`react-table` Table (Sort only)	`76.978 kB` `18.973 kB`	`77.004 kB` `18.981 kB`	`26 B` `8 B`
`react-tags-preview` InteractionTag	`34.145 kB` `9.188 kB`	`34.171 kB` `9.199 kB`	`26 B` `11 B`
`react-tags-preview` Tag	`25.936 kB` `8.483 kB`	`25.962 kB` `8.49 kB`	`26 B` `7 B`

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`510 B` `330 B`
`global-context` createContextSelector	`537 B` `342 B`
`priority-overflow` createOverflowManager	`4.248 kB` `1.671 kB`
`react-avatar` AvatarGroup	`15.695 kB` `6.314 kB`
`react-badge` Badge	`23.604 kB` `7.272 kB`
`react-badge` CounterBadge	`24.506 kB` `7.574 kB`
`react-button` Button	`39.193 kB` `9.743 kB`
`react-button` CompoundButton	`46.661 kB` `11.257 kB`
`react-button` ToggleButton	`57.629 kB` `11.645 kB`
`react-card` Card - All	`89.36 kB` `25.284 kB`
`react-card` Card	`83.778 kB` `23.685 kB`
`react-card` CardFooter	`9.24 kB` `3.907 kB`
`react-card` CardHeader	`11.652 kB` `4.741 kB`
`react-card` CardPreview	`10.048 kB` `4.254 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`67.576 kB` `18.225 kB`
`react-components` react-components: FluentProvider & webLightTheme	`36.409 kB` `12.003 kB`
`react-divider` Divider	`17.49 kB` `6.364 kB`
`react-image` Image	`11.561 kB` `4.637 kB`
`react-input` Input	`24.232 kB` `7.781 kB`
`react-label` Label	`10.186 kB` `4.253 kB`
`react-link` Link	`12.782 kB` `5.247 kB`
`react-overflow` hooks only	`12.505 kB` `4.626 kB`
`react-popover` Popover	`119.925 kB` `36.895 kB`
`react-portal` Portal	`11.935 kB` `4.421 kB`
`react-portal-compat` PortalCompatProvider	`6.48 kB` `2.203 kB`
`react-positioning` usePositioning	`24.272 kB` `8.866 kB`
`react-progress` ProgressBar	`13.941 kB` `5.498 kB`
`react-provider` FluentProvider	`18.129 kB` `6.73 kB`
`react-radio` RadioGroup	`11.376 kB` `4.763 kB`
`react-slider` Slider	`34.87 kB` `11.178 kB`
`react-spinner` Spinner	`21.77 kB` `7.134 kB`
`react-tags-preview` TagGroup	`69.142 kB` `20.294 kB`
`react-text` Text - Default	`12.574 kB` `4.982 kB`
`react-text` Text - Wrappers	`15.726 kB` `5.302 kB`
`react-textarea` Textarea	`27.703 kB` `9.126 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`31.987 kB` `6.85 kB`
`react-theme` Teams: Light theme	`18.121 kB` `5.194 kB`
`react-toast` Toast (including Toaster)	`78.365 kB` `23.67 kB`
`react-tooltip` Tooltip	`47.463 kB` `16.655 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against 5a4b16715e8e929f11d8113f710e578ca73acaa6}

apps/recipes-react-components/package.json

size-auditor · 2023-07-19T22:46:48Z

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: bc5c683

Possible causes

The baseline build bc5c683 is broken
The Size Auditor run for the baseline build bc5c683 was not triggered

Recommendations

Please merge your branch for this Pull request with the latest master build and commit your changes once again

fabricteam · 2023-07-19T22:50:48Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	623	631	5000
Breadcrumb	mount	1639	1668	1000
Checkbox	mount	1684	1681	5000
CheckboxBase	mount	1492	1480	5000
ChoiceGroup	mount	2885	2898	5000
ComboBox	mount	640	655	1000
CommandBar	mount	6293	6267	1000
ContextualMenu	mount	13041	12948	1000
DefaultButton	mount	757	745	5000
DetailsRow	mount	2174	2158	5000
DetailsRowFast	mount	2158	2172	5000
DetailsRowNoStyles	mount	2009	1972	5000
Dialog	mount	2751	2719	1000
DocumentCardTitle	mount	223	233	1000
Dropdown	mount	1959	2003	5000
FocusTrapZone	mount	1129	1119	5000
FocusZone	mount	1067	1072	5000
GroupedList	mount	41321	41077	2
GroupedList	virtual-rerender	19800	20007	2
GroupedList	virtual-rerender-with-unmount	51161	50413	2
GroupedListV2	mount	219	228	2
GroupedListV2	virtual-rerender	207	214	2
GroupedListV2	virtual-rerender-with-unmount	221	221	2
IconButton	mount	1055	1083	5000
Label	mount	332	348	5000
Layer	mount	2737	2698	5000
Link	mount	379	411	5000
MenuButton	mount	944	941	5000
MessageBar	mount	21313	21408	5000
Nav	mount	1926	1948	1000
OverflowSet	mount	778	769	5000
Panel	mount	1800	1787	1000
Persona	mount	724	759	1000
Pivot	mount	864	856	1000
PrimaryButton	mount	869	852	5000
Rating	mount	4456	4506	5000
SearchBox	mount	920	904	5000
Shimmer	mount	1853	1846	5000
Slider	mount	1337	1347	5000
SpinButton	mount	2931	2871	5000
Spinner	mount	385	394	5000
SplitButton	mount	1797	1816	5000
Stack	mount	401	418	5000
StackWithIntrinsicChildren	mount	833	865	5000
StackWithTextChildren	mount	2628	2618	5000
SwatchColorPicker	mount	6060	6088	5000
TagPicker	mount	1455	1465	5000
Text	mount	385	368	5000
TextField	mount	930	924	5000
ThemeProvider	mount	833	834	5000
ThemeProvider	virtual-rerender	587	585	5000
ThemeProvider	virtual-rerender-with-unmount	1266	1264	5000
Toggle	mount	617	603	5000
buttonNative	mount	192	195	5000

* master: (32 commits) chore: remove @fluentui/bundle-size (microsoft#28601) Breadcrumb UI adjustments (microsoft#28578) feat(tools): re-generate react-components.api.md when preparing 1st stable release (microsoft#28561) perf(tools): make dependency-mismatch execution 90% faster and ignore */>=9.0.0-alpha versions (microsoft#28597) Table/DataGrid: keyboard resizing improvements (microsoft#28493) docs(react-tooltip): Add info icon + tooltip story to Tooltip stories (microsoft#28611) chore: Updating @fluentui/react-icons to version 2.0.207 (microsoft#28590) feat: allSelectedRows and someSelectedRows should be more reliable (microsoft#28577) add vr test to react-tags (microsoft#28484) applying package updates chore: migrate to monosize (microsoft#26826) fix(react-conformance): add @swc/helpers to deps instead of tslib as we use swc for transpilation (microsoft#28599) fix: MenuItem content should be spaced 12px from the boundary (microsoft#28162) feat: implements selection (microsoft#28497) bugfix: moves handleBackdropClick from defaultProps to an override (microsoft#28579) Fix empty CSS creation (microsoft#28566) chore: replace plop with nx within create-* aliases in root package.json (microsoft#28575) applying package updates fix: High contrast mode hover style icon fixes in react-button components (microsoft#28156) SplitButton: updated border right token for primary variant (microsoft#28555) ...

tomi-msft added 2 commits July 19, 2023 15:03

update react-icons version in repo

8bcbf50

change files

1735b3f

tomi-msft requested review from a team, GeoffCoxMSFT, behowell, khmakoto, micahgodbolt, ms-acalzaretto, smhigley, sopranopillow and spmonahan as code owners July 19, 2023 22:07

github-actions bot added this to the July Project Cycle Q3 2023 milestone Jul 19, 2023

sopranopillow approved these changes Jul 19, 2023

View reviewed changes

change/@fluentui-react-avatar-b5fcd0d1-345c-4e84-9715-df646c74a3c9.json Outdated Show resolved Hide resolved

lockfile update

f41bbe3

fabricteam reviewed Jul 19, 2023

View reviewed changes

apps/recipes-react-components/package.json Show resolved Hide resolved

khmakoto changed the title ~~React icons 207 update~~ chore: Updating @fluentui/react-icons to version 2.0.207 Jul 19, 2023

khmakoto approved these changes Jul 19, 2023

View reviewed changes

tomi-msft and others added 2 commits July 19, 2023 16:14

Change file cleanup

72ffac1

Merge branch 'master' into react-icons-207-update

351a2d3

tudorpopams approved these changes Jul 20, 2023

View reviewed changes

tomi-msft added 4 commits July 20, 2023 14:24

merge with master

e1109ae

update lock file

5d9123a

dependency mismatch fix

91b79a6

lock file

3b89957

tomi-msft enabled auto-merge (squash) July 20, 2023 21:54

ling1726 approved these changes Jul 21, 2023

View reviewed changes

tomi-msft merged commit 1082207 into microsoft:master Jul 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Updating @fluentui/react-icons to version 2.0.207 #28590

chore: Updating @fluentui/react-icons to version 2.0.207 #28590

Uh oh!

tomi-msft commented Jul 19, 2023

Uh oh!

Uh oh!

codesandbox-ci bot commented Jul 19, 2023 •

edited

Loading

Uh oh!

fabricteam commented Jul 19, 2023 •

edited

Loading

Uh oh!

fabricteam commented Jul 19, 2023 •

edited

Loading

Uh oh!

fabricteam commented Jul 19, 2023 •

edited

Loading

Uh oh!

fabricteam commented Jul 19, 2023 •

edited

Loading

Uh oh!

fabricteam commented Jul 19, 2023 •

edited

Loading

Uh oh!

Uh oh!

size-auditor bot commented Jul 19, 2023 •

edited

Loading

Uh oh!

fabricteam commented Jul 19, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

chore: Updating @fluentui/react-icons to version 2.0.207 #28590

chore: Updating @fluentui/react-icons to version 2.0.207 #28590

Uh oh!

Conversation

tomi-msft commented Jul 19, 2023

Uh oh!

Uh oh!

codesandbox-ci bot commented Jul 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabricteam commented Jul 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Jul 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Jul 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

fabricteam commented Jul 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 FluentUIV0 No visual regressions between this PR and main

Uh oh!

fabricteam commented Jul 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

Uh oh!

size-auditor bot commented Jul 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

fabricteam commented Jul 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codesandbox-ci bot commented Jul 19, 2023 •

edited

Loading

fabricteam commented Jul 19, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Jul 19, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Jul 19, 2023 •

edited

Loading

fabricteam commented Jul 19, 2023 •

edited

Loading

fabricteam commented Jul 19, 2023 •

edited

Loading

size-auditor bot commented Jul 19, 2023 •

edited

Loading

fabricteam commented Jul 19, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react`)