Skip to content

Conversation

@ValentinaKozlova
Copy link
Contributor

@ValentinaKozlova ValentinaKozlova commented Jul 19, 2023

Previous Behavior

  • removed custom divider because it's not recommended to use these kinds of dividers: image
  • removed paddings from BreadcrumbLink and BreadcrumbButton:
    image

New Behavior

  • Divider:
    image
  • BreadcumbButton (looks almost the same, but there are no paddings)
    image

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 19, 2023

📊 Bundle size report

🤖 This report was generated against 5a4b16715e8e929f11d8113f710e578ca73acaa6

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 19, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 51ec5b0:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Jul 19, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 5a4b16715e8e929f11d8113f710e578ca73acaa6 (build)

@ValentinaKozlova ValentinaKozlova force-pushed the fix/breadcrumb-spacing branch from e88f1b2 to 51ec5b0 Compare July 20, 2023 16:59
@ValentinaKozlova ValentinaKozlova marked this pull request as ready for review July 20, 2023 17:48
@ValentinaKozlova ValentinaKozlova requested a review from a team as a code owner July 20, 2023 17:48
@ValentinaKozlova ValentinaKozlova merged commit 312d1b3 into microsoft:master Jul 24, 2023
@ValentinaKozlova ValentinaKozlova deleted the fix/breadcrumb-spacing branch July 24, 2023 11:45
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Jul 25, 2023
* master: (32 commits)
  chore: remove @fluentui/bundle-size (microsoft#28601)
  Breadcrumb UI adjustments (microsoft#28578)
  feat(tools): re-generate react-components.api.md when preparing 1st stable release (microsoft#28561)
  perf(tools): make dependency-mismatch execution 90% faster and ignore */>=9.0.0-alpha versions (microsoft#28597)
  Table/DataGrid: keyboard resizing improvements (microsoft#28493)
  docs(react-tooltip): Add info icon + tooltip story to Tooltip stories (microsoft#28611)
  chore: Updating @fluentui/react-icons to version 2.0.207 (microsoft#28590)
  feat: allSelectedRows and someSelectedRows should be more reliable (microsoft#28577)
  add vr test to react-tags (microsoft#28484)
  applying package updates
  chore: migrate to monosize (microsoft#26826)
  fix(react-conformance): add @swc/helpers to deps instead of tslib as we use swc for transpilation (microsoft#28599)
  fix: MenuItem content should be spaced 12px from the boundary (microsoft#28162)
  feat: implements selection (microsoft#28497)
  bugfix: moves handleBackdropClick from defaultProps to an override (microsoft#28579)
  Fix empty CSS creation (microsoft#28566)
  chore: replace plop with nx within create-* aliases in root package.json (microsoft#28575)
  applying package updates
  fix: High contrast mode hover style icon fixes in react-button components (microsoft#28156)
  SplitButton: updated border right token for primary variant (microsoft#28555)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants