chore: migrate to monosize #26826
Merged
chore: migrate to monosize #26826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
force-pushed
the
chore/replace-bundlesize
branch
from
6187ca8 to
47cbe74
Compare
Collaborator
📊 Bundle size reportUnchanged fixtures
|
layershifter
force-pushed
the
chore/replace-bundlesize
branch
from
47cbe74 to
b171227
Compare
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d803aee2490d42f147906333f70f9867eafd452d (build) |
layershifter
force-pushed
the
chore/replace-bundlesize
branch
from
b171227 to
31f2857
Compare
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | mount | 76 | 79 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 589 | 608 | 5000 | |
| Button | mount | 299 | 291 | 5000 | |
| Field | mount | 1053 | 1045 | 5000 | |
| FluentProvider | mount | 643 | 649 | 5000 | |
| FluentProviderWithTheme | mount | 76 | 79 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender | 57 | 62 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 72 | 71 | 10 | |
| InfoButton | mount | 11 | 10 | 5000 | |
| MakeStyles | mount | 857 | 874 | 50000 | |
| Persona | mount | 1606 | 1572 | 5000 | |
| SpinButton | mount | 1260 | 1326 | 5000 |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 625 | 636 | 5000 | |
| Breadcrumb | mount | 1638 | 1671 | 1000 | |
| Checkbox | mount | 1693 | 1683 | 5000 | |
| CheckboxBase | mount | 1487 | 1472 | 5000 | |
| ChoiceGroup | mount | 2926 | 2931 | 5000 | |
| ComboBox | mount | 670 | 631 | 1000 | |
| CommandBar | mount | 6184 | 6199 | 1000 | |
| ContextualMenu | mount | 13034 | 13619 | 1000 | |
| DefaultButton | mount | 771 | 736 | 5000 | |
| DetailsRow | mount | 2156 | 2174 | 5000 | |
| DetailsRowFast | mount | 2145 | 2174 | 5000 | |
| DetailsRowNoStyles | mount | 1966 | 2021 | 5000 | |
| Dialog | mount | 2585 | 2732 | 1000 | |
| DocumentCardTitle | mount | 228 | 222 | 1000 | |
| Dropdown | mount | 1969 | 1961 | 5000 | |
| FocusTrapZone | mount | 1123 | 1138 | 5000 | |
| FocusZone | mount | 1073 | 1049 | 5000 | |
| GroupedList | mount | 41373 | 41591 | 2 | |
| GroupedList | virtual-rerender | 17781 | 19741 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 50724 | 50308 | 2 | |
| GroupedListV2 | mount | 233 | 223 | 2 | |
| GroupedListV2 | virtual-rerender | 203 | 205 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 215 | 226 | 2 | |
| IconButton | mount | 1099 | 1075 | 5000 | |
| Label | mount | 343 | 329 | 5000 | |
| Layer | mount | 2688 | 2704 | 5000 | |
| Link | mount | 387 | 392 | 5000 | |
| MenuButton | mount | 954 | 954 | 5000 | |
| MessageBar | mount | 21294 | 21313 | 5000 | |
| Nav | mount | 1922 | 1954 | 1000 | |
| OverflowSet | mount | 781 | 762 | 5000 | |
| Panel | mount | 2036 | 1792 | 1000 | |
| Persona | mount | 762 | 746 | 1000 | |
| Pivot | mount | 854 | 878 | 1000 | |
| PrimaryButton | mount | 836 | 829 | 5000 | |
| Rating | mount | 4554 | 4673 | 5000 | |
| SearchBox | mount | 875 | 888 | 5000 | |
| Shimmer | mount | 1820 | 1871 | 5000 | |
| Slider | mount | 1325 | 1339 | 5000 | |
| SpinButton | mount | 2862 | 2872 | 5000 | |
| Spinner | mount | 386 | 375 | 5000 | |
| SplitButton | mount | 1809 | 1816 | 5000 | |
| Stack | mount | 402 | 407 | 5000 | |
| StackWithIntrinsicChildren | mount | 847 | 854 | 5000 | |
| StackWithTextChildren | mount | 2618 | 2634 | 5000 | |
| SwatchColorPicker | mount | 6102 | 6041 | 5000 | |
| TagPicker | mount | 1427 | 1447 | 5000 | |
| Text | mount | 379 | 375 | 5000 | |
| TextField | mount | 926 | 929 | 5000 | |
| ThemeProvider | mount | 827 | 822 | 5000 | |
| ThemeProvider | virtual-rerender | 584 | 588 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1257 | 1281 | 5000 | |
| Toggle | mount | 614 | 604 | 5000 | |
| buttonNative | mount | 188 | 192 | 5000 |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| AccordionMinimalPerf.default | 84 | 84 | 1:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ChatWithPopoverPerf.default | 200 | 174 | 1.15:1 |
| TreeWith60ListItems.default | 89 | 82 | 1.09:1 |
| DropdownManyItemsPerf.default | 406 | 377 | 1.08:1 |
| TextAreaMinimalPerf.default | 296 | 274 | 1.08:1 |
| FormMinimalPerf.default | 222 | 210 | 1.06:1 |
| ImageMinimalPerf.default | 237 | 224 | 1.06:1 |
| AvatarMinimalPerf.default | 112 | 107 | 1.05:1 |
| BoxMinimalPerf.default | 203 | 194 | 1.05:1 |
| ChatMinimalPerf.default | 448 | 428 | 1.05:1 |
| TextMinimalPerf.default | 192 | 183 | 1.05:1 |
| ButtonMinimalPerf.default | 86 | 83 | 1.04:1 |
| HeaderSlotsPerf.default | 470 | 454 | 1.04:1 |
| ListMinimalPerf.default | 313 | 302 | 1.04:1 |
| ListNestedPerf.default | 328 | 314 | 1.04:1 |
| RadioGroupMinimalPerf.default | 262 | 253 | 1.04:1 |
| CardMinimalPerf.default | 314 | 306 | 1.03:1 |
| FlexMinimalPerf.default | 153 | 148 | 1.03:1 |
| LayoutMinimalPerf.default | 204 | 198 | 1.03:1 |
| RosterPerf.default | 1518 | 1480 | 1.03:1 |
| ReactionMinimalPerf.default | 213 | 207 | 1.03:1 |
| SliderMinimalPerf.default | 749 | 726 | 1.03:1 |
| StatusMinimalPerf.default | 401 | 388 | 1.03:1 |
| TableManyItemsPerf.default | 1111 | 1082 | 1.03:1 |
| AnimationMinimalPerf.default | 300 | 295 | 1.02:1 |
| ButtonOverridesMissPerf.default | 676 | 662 | 1.02:1 |
| CheckboxMinimalPerf.default | 1162 | 1138 | 1.02:1 |
| HeaderMinimalPerf.default | 206 | 201 | 1.02:1 |
| ListWith60ListItems.default | 374 | 367 | 1.02:1 |
| AttachmentMinimalPerf.default | 84 | 83 | 1.01:1 |
| AttachmentSlotsPerf.default | 639 | 635 | 1.01:1 |
| CarouselMinimalPerf.default | 267 | 265 | 1.01:1 |
| EmbedMinimalPerf.default | 1897 | 1869 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 699 | 692 | 1.01:1 |
| PopupMinimalPerf.default | 346 | 341 | 1.01:1 |
| ProviderMergeThemesPerf.default | 666 | 658 | 1.01:1 |
| ProviderMinimalPerf.default | 200 | 199 | 1.01:1 |
| VideoMinimalPerf.default | 430 | 426 | 1.01:1 |
| DropdownMinimalPerf.default | 1403 | 1404 | 1:1 |
| MenuMinimalPerf.default | 502 | 501 | 1:1 |
| SplitButtonMinimalPerf.default | 2228 | 2217 | 1:1 |
| CustomToolbarPrototype.default | 1505 | 1510 | 1:1 |
| InputMinimalPerf.default | 531 | 536 | 0.99:1 |
| ListCommonPerf.default | 392 | 395 | 0.99:1 |
| MenuButtonMinimalPerf.default | 947 | 961 | 0.99:1 |
| PortalMinimalPerf.default | 85 | 86 | 0.99:1 |
| SegmentMinimalPerf.default | 193 | 194 | 0.99:1 |
| TableMinimalPerf.default | 238 | 241 | 0.99:1 |
| ButtonSlotsPerf.default | 328 | 333 | 0.98:1 |
| ChatDuplicateMessagesPerf.default | 140 | 143 | 0.98:1 |
| DividerMinimalPerf.default | 200 | 205 | 0.98:1 |
| GridMinimalPerf.default | 193 | 197 | 0.98:1 |
| RefMinimalPerf.default | 108 | 110 | 0.98:1 |
| ToolbarMinimalPerf.default | 533 | 546 | 0.98:1 |
| DialogMinimalPerf.default | 436 | 451 | 0.97:1 |
| LabelMinimalPerf.default | 212 | 219 | 0.97:1 |
| LoaderMinimalPerf.default | 184 | 189 | 0.97:1 |
| TooltipMinimalPerf.default | 1224 | 1257 | 0.97:1 |
| IconMinimalPerf.default | 374 | 390 | 0.96:1 |
| TreeMinimalPerf.default | 463 | 482 | 0.96:1 |
| DatepickerMinimalPerf.default | 3673 | 3851 | 0.95:1 |
| AlertMinimalPerf.default | 156 | 166 | 0.94:1 |
| SkeletonMinimalPerf.default | 185 | 196 | 0.94:1 |
layershifter
force-pushed
the
chore/replace-bundlesize
branch
from
31f2857 to
d751cf0
Compare
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4735f18:
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
layershifter
force-pushed
the
chore/replace-bundlesize
branch
from
d751cf0 to
27320a9
Compare
Hotell
reviewed
Feb 13, 2023
fabricteam
reviewed
Feb 13, 2023
layershifter
force-pushed
the
chore/replace-bundlesize
branch
from
27320a9 to
a5d4c8d
Compare
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
layershifter
requested review from
a team,
behowell,
khmakoto,
sopranopillow and
tomi-msft
as code owners
layershifter
requested review from
a team,
micahgodbolt,
smhigley and
spmonahan
as code owners
behowell
approved these changes
Jul 17, 2023
Hotell
reviewed
Jul 18, 2023
Hotell
approved these changes
Jul 18, 2023
Contributor
Hotell
left a comment
Hotell
left a comment
There was a problem hiding this comment.
lets admin merge once conversations are resolved.
I added reference to existing issue planned for FY24 on v-build roadmap. ty
ling1726
approved these changes
Jul 18, 2023
layershifter
force-pushed
the
chore/replace-bundlesize
branch
from
a5d4c8d to
4735f18
Compare
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jul 25, 2023
* master: (32 commits) chore: remove @fluentui/bundle-size (microsoft#28601) Breadcrumb UI adjustments (microsoft#28578) feat(tools): re-generate react-components.api.md when preparing 1st stable release (microsoft#28561) perf(tools): make dependency-mismatch execution 90% faster and ignore */>=9.0.0-alpha versions (microsoft#28597) Table/DataGrid: keyboard resizing improvements (microsoft#28493) docs(react-tooltip): Add info icon + tooltip story to Tooltip stories (microsoft#28611) chore: Updating @fluentui/react-icons to version 2.0.207 (microsoft#28590) feat: allSelectedRows and someSelectedRows should be more reliable (microsoft#28577) add vr test to react-tags (microsoft#28484) applying package updates chore: migrate to monosize (microsoft#26826) fix(react-conformance): add @swc/helpers to deps instead of tslib as we use swc for transpilation (microsoft#28599) fix: MenuItem content should be spaced 12px from the boundary (microsoft#28162) feat: implements selection (microsoft#28497) bugfix: moves handleBackdropClick from defaultProps to an override (microsoft#28579) Fix empty CSS creation (microsoft#28566) chore: replace plop with nx within create-* aliases in root package.json (microsoft#28575) applying package updates fix: High contrast mode hover style icon fixes in react-button components (microsoft#28156) SplitButton: updated border right token for primary variant (microsoft#28555) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
This PR replaces
@fluentui/bundle-sizewithmonosize. At current moment, it's the same code except the adapters feature:monosizesupports different storage adapters that makes it really reusable.This PR:
package.jsonfiles to updatebundlesizescript (& includes a lot of changefiles because of that)monosize/monosize.config.mjsthat contains a config for a storage adapter (credentials are the same as we use currently)/packages/react-components/global-context/monosize.config.mjsto replacepackages/react-components/global-context/bundle-size.config.jsworkspace-tools,cli-table3&ci-infoas a side-effect to avoid duplicatesFixes partially #27934