Skip to content

Conversation

@bsunderhus
Copy link
Contributor

New Behavior

TreeItemAside has been released on @fluentui/react-tree package but not on @fluentui/react-components.

  1. Exports TreeItemAside on @fluentui/react-components

@bsunderhus bsunderhus self-assigned this May 16, 2023
@bsunderhus bsunderhus marked this pull request as ready for review May 16, 2023 08:47
@bsunderhus bsunderhus requested a review from a team as a code owner May 16, 2023 08:47
@github-actions github-actions bot added this to the May Project Cycle Q2 2023 milestone May 16, 2023
@fabricteam
Copy link
Collaborator

fabricteam commented May 16, 2023

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
64.855 kB
17.852 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
203.937 kB
57.086 kB
react-components
react-components: FluentProvider & webLightTheme
36.086 kB
11.9 kB
react-portal-compat
PortalCompatProvider
6.446 kB
2.186 kB
🤖 This report was generated against 37159cd67f8698ba8d5b3bf7327801495979beb5

@size-auditor
Copy link

size-auditor bot commented May 16, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 37159cd67f8698ba8d5b3bf7327801495979beb5 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented May 16, 2023

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 673 694 5000
Button mount 372 378 5000
Field mount 1261 1266 5000
FluentProvider mount 929 911 5000
FluentProviderWithTheme mount 113 116 10
FluentProviderWithTheme virtual-rerender 99 106 10
FluentProviderWithTheme virtual-rerender-with-unmount 100 105 10
InfoButton mount 19 16 5000
MakeStyles mount 1123 1109 50000
Persona mount 2035 1991 5000
SpinButton mount 1543 1553 5000

@bsunderhus bsunderhus force-pushed the react-tree/chore--adds-TreeItemAside-to-react-components branch from 932d5d7 to 16404a9 Compare May 16, 2023 09:10
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 16404a9:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@bsunderhus bsunderhus merged commit 322ee9a into microsoft:master May 16, 2023
@bsunderhus bsunderhus deleted the react-tree/chore--adds-TreeItemAside-to-react-components branch May 16, 2023 10:29
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request May 18, 2023
* master: (24 commits)
  chore(react-tabster): upgrade tabster to v4.4.2 (microsoft#27540)
  feat(react-tags): Add TagGroup with context (microsoft#27886)
  applying package updates
  fix(react-infobutton): Add aria-owns to InfoLabel (microsoft#27834)
  fix(recipes-react-components): Add a FluentProvider to the local storybook (microsoft#27746)
  chore: update RFC template (microsoft#27880)
  applying package updates
  feat: implement Toaster offset (microsoft#27854)
  feat(react-drawer): create DrawerFooter component (microsoft#27583)
  Make getKey and selection props mutually exclusive (microsoft#24048)
  Added MIGRATION.md to the Breadcrumb (microsoft#27846)
  update Github CODEOWNERS file (microsoft#27849)
  feat(react-tags): make basic Tag a button instead of div (microsoft#27858)
  chore: add test-ssr script to v9 packages (microsoft#27690)
  chore(react-tree): exports TreeItemAside unstable (microsoft#27856)
  bugfix(react-dialog): removes unnecessary grid gaps (microsoft#27845)
  applying package updates
  fix(react-textarea): Don't remove outline when filled and disabled and apply correct disabled color to text (microsoft#27837)
  feat: Implement limit for toast stacking (microsoft#27848)
  Update README.md for fluent 2 theme to include import instructions (microsoft#27847)
  ...
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request May 18, 2023
* feat/drawer-header: (24 commits)
  chore(react-tabster): upgrade tabster to v4.4.2 (microsoft#27540)
  feat(react-tags): Add TagGroup with context (microsoft#27886)
  applying package updates
  fix(react-infobutton): Add aria-owns to InfoLabel (microsoft#27834)
  fix(recipes-react-components): Add a FluentProvider to the local storybook (microsoft#27746)
  chore: update RFC template (microsoft#27880)
  applying package updates
  feat: implement Toaster offset (microsoft#27854)
  feat(react-drawer): create DrawerFooter component (microsoft#27583)
  Make getKey and selection props mutually exclusive (microsoft#24048)
  fix: move style override to outside the component
  Added MIGRATION.md to the Breadcrumb (microsoft#27846)
  update Github CODEOWNERS file (microsoft#27849)
  feat(react-tags): make basic Tag a button instead of div (microsoft#27858)
  chore: add test-ssr script to v9 packages (microsoft#27690)
  chore(react-tree): exports TreeItemAside unstable (microsoft#27856)
  bugfix(react-dialog): removes unnecessary grid gaps (microsoft#27845)
  applying package updates
  fix(react-textarea): Don't remove outline when filled and disabled and apply correct disabled color to text (microsoft#27837)
  feat: Implement limit for toast stacking (microsoft#27848)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants