chore(react-tabster): upgrade tabster to v4.4.2 #27540

bsunderhus · 2023-04-13T09:40:21Z

New Behavior

Bumps tabster version to 4.4.2

Related Issue(s)

Fixes [Bug]: Dialog will blur incorrectly with React 18.2.0 and tabster 4.1.1, please upgrade tabster to v4.2.0+ to solve it #27487
Fixes [Bug]: dialog directly mounted with open=true could not get focus #26824

codesandbox-ci · 2023-04-13T09:51:33Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e77a962:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration
billowing-leaf-mfvcg5	Issue #26824
quiet-fast-1106pn	Issue #27487

fabricteam · 2023-04-13T09:51:36Z

Perf Analysis (`@fluentui/react-components`)

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
InfoButton	mount	24	22	5000	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
Avatar	mount	686	698	5000
Button	mount	379	366	5000
Field	mount	1282	1302	5000
FluentProvider	mount	904	921	5000
FluentProviderWithTheme	mount	115	113	10
FluentProviderWithTheme	virtual-rerender	101	102	10
FluentProviderWithTheme	virtual-rerender-with-unmount	110	109	10
InfoButton	mount	24	22	5000	Possible regression
MakeStyles	mount	1119	1104	50000
Persona	mount	1986	1954	5000
SpinButton	mount	1572	1569	5000

size-auditor · 2023-04-13T09:52:28Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 31930f6a77d0473edea5eefef5acc63c78ff9de1 (build)

fabricteam · 2023-04-13T09:55:22Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario	Current PR Ticks	Baseline Ticks	Ratio	Regression Analysis
AttachmentMinimalPerf.default	108	98	1.1:1	analysis

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
AvatarMinimalPerf.default	141	128	1.1:1
ChatMinimalPerf.default	559	516	1.08:1
ButtonMinimalPerf.default	110	103	1.07:1
CardMinimalPerf.default	399	374	1.07:1
ChatWithPopoverPerf.default	260	246	1.06:1
FlexMinimalPerf.default	205	194	1.06:1
LoaderMinimalPerf.default	246	231	1.06:1
SliderMinimalPerf.default	949	903	1.05:1
AttachmentSlotsPerf.default	842	807	1.04:1
InputMinimalPerf.default	733	708	1.04:1
ListWith60ListItems.default	498	478	1.04:1
PopupMinimalPerf.default	456	438	1.04:1
ToolbarMinimalPerf.default	668	643	1.04:1
AlertMinimalPerf.default	195	189	1.03:1
HeaderSlotsPerf.default	584	566	1.03:1
ListNestedPerf.default	403	392	1.03:1
MenuMinimalPerf.default	632	611	1.03:1
TextMinimalPerf.default	256	248	1.03:1
AnimationMinimalPerf.default	367	361	1.02:1
CheckboxMinimalPerf.default	1567	1540	1.02:1
DialogMinimalPerf.default	576	566	1.02:1
DropdownMinimalPerf.default	1830	1799	1.02:1
EmbedMinimalPerf.default	2411	2372	1.02:1
GridMinimalPerf.default	252	246	1.02:1
RefMinimalPerf.default	141	138	1.02:1
SkeletonMinimalPerf.default	258	253	1.02:1
StatusMinimalPerf.default	507	495	1.02:1
ButtonOverridesMissPerf.default	843	836	1.01:1
CarouselMinimalPerf.default	344	339	1.01:1
MenuButtonMinimalPerf.default	1262	1246	1.01:1
ProviderMinimalPerf.default	273	270	1.01:1
ReactionMinimalPerf.default	269	267	1.01:1
SegmentMinimalPerf.default	251	249	1.01:1
TextAreaMinimalPerf.default	352	350	1.01:1
CustomToolbarPrototype.default	1903	1881	1.01:1
ButtonSlotsPerf.default	404	402	1:1
DropdownManyItemsPerf.default	503	504	1:1
ItemLayoutMinimalPerf.default	902	904	1:1
ListMinimalPerf.default	384	384	1:1
ProviderMergeThemesPerf.default	967	966	1:1
TableManyItemsPerf.default	1418	1412	1:1
TooltipMinimalPerf.default	1597	1592	1:1
BoxMinimalPerf.default	251	253	0.99:1
DatepickerMinimalPerf.default	4525	4577	0.99:1
ImageMinimalPerf.default	268	270	0.99:1
LabelMinimalPerf.default	279	283	0.99:1
LayoutMinimalPerf.default	260	262	0.99:1
RadioGroupMinimalPerf.default	323	327	0.99:1
TableMinimalPerf.default	292	294	0.99:1
TreeMinimalPerf.default	597	606	0.99:1
ChatDuplicateMessagesPerf.default	194	198	0.98:1
DividerMinimalPerf.default	262	266	0.98:1
ListCommonPerf.default	481	492	0.98:1
SplitButtonMinimalPerf.default	3011	3088	0.98:1
VideoMinimalPerf.default	513	523	0.98:1
FormMinimalPerf.default	266	273	0.97:1
RosterPerf.default	1767	1821	0.97:1
PortalMinimalPerf.default	112	117	0.96:1
IconMinimalPerf.default	459	481	0.95:1
AccordionMinimalPerf.default	100	107	0.93:1
HeaderMinimalPerf.default	257	277	0.93:1
TreeWith60ListItems.default	104	118	0.88:1

fabricteam · 2023-04-13T09:58:36Z

📊 Bundle size report

Package & Exports	Baseline (minified/GZIP)	PR	Change
`react-accordion` Accordion (including children components)	`86.064 kB` `26.1 kB`	`88.201 kB` `26.692 kB`	`2.137 kB` `592 B`
`react-card` Card - All	`86.061 kB` `24.345 kB`	`88.428 kB` `25.004 kB`	`2.367 kB` `659 B`
`react-card` Card	`80.997 kB` `22.895 kB`	`83.363 kB` `23.556 kB`	`2.366 kB` `661 B`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`203.937 kB` `57.086 kB`	`205.795 kB` `57.705 kB`	`1.858 kB` `619 B`
`react-datepicker-compat` DatePicker Compat	`220.303 kB` `58.486 kB`	`222.161 kB` `59.087 kB`	`1.858 kB` `601 B`
`react-dialog` Dialog (including children components)	`90.204 kB` `26.857 kB`	`91.892 kB` `27.42 kB`	`1.688 kB` `563 B`
`react-infobutton` InfoButton	`127.977 kB` `39.012 kB`	`129.664 kB` `39.571 kB`	`1.687 kB` `559 B`
`react-infobutton` InfoLabel	`131.447 kB` `40.071 kB`	`133.133 kB` `40.658 kB`	`1.686 kB` `587 B`
`react-menu` Menu (including children components)	`128.254 kB` `39.184 kB`	`130.392 kB` `39.788 kB`	`2.138 kB` `604 B`
`react-menu` Menu (including selectable components)	`131.238 kB` `39.7 kB`	`133.376 kB` `40.307 kB`	`2.138 kB` `607 B`
`react-popover` Popover	`114.969 kB` `35.392 kB`	`116.655 kB` `35.952 kB`	`1.686 kB` `560 B`
`react-table` DataGrid	`147.583 kB` `40.523 kB`	`149.721 kB` `41.154 kB`	`2.138 kB` `631 B`
`react-table` Table as DataGrid	`130.142 kB` `33.083 kB`	`132.279 kB` `33.668 kB`	`2.137 kB` `585 B`

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`560 B` `352 B`
`priority-overflow` createOverflowManager	`3.194 kB` `1.315 kB`
`react-alert` Alert	`93.534 kB` `22.497 kB`
`react-avatar` Avatar	`57.754 kB` `15.041 kB`
`react-avatar` AvatarGroup	`15.632 kB` `6.258 kB`
`react-avatar` AvatarGroupItem	`73.968 kB` `19.552 kB`
`react-badge` Badge	`23.512 kB` `7.197 kB`
`react-badge` CounterBadge	`24.416 kB` `7.506 kB`
`react-badge` PresenceBadge	`32.094 kB` `8.367 kB`
`react-button` Button	`36.724 kB` `9.458 kB`
`react-button` CompoundButton	`43.873 kB` `10.939 kB`
`react-button` MenuButton	`41.411 kB` `10.791 kB`
`react-button` SplitButton	`49.635 kB` `12.364 kB`
`react-button` ToggleButton	`54.866 kB` `11.367 kB`
`react-card` CardFooter	`9.158 kB` `3.844 kB`
`react-card` CardHeader	`11.048 kB` `4.538 kB`
`react-card` CardPreview	`9.963 kB` `4.192 kB`
`react-checkbox` Checkbox	`34.268 kB` `10.793 kB`
`react-combobox` Combobox (including child components)	`87.251 kB` `28.1 kB`
`react-combobox` Dropdown (including child components)	`85.635 kB` `27.697 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`64.855 kB` `17.852 kB`
`react-components` react-components: FluentProvider & webLightTheme	`36.086 kB` `11.9 kB`
`react-divider` Divider	`17.399 kB` `6.298 kB`
`react-field` Field	`18.864 kB` `7.004 kB`
`react-image` Image	`11.479 kB` `4.573 kB`
`react-input` Input	`24.024 kB` `7.682 kB`
`react-label` Label	`10.104 kB` `4.185 kB`
`react-link` Link	`12.304 kB` `5.061 kB`
`react-overflow` hooks only	`11.214 kB` `4.271 kB`
`react-persona` Persona	`64.675 kB` `16.968 kB`
`react-portal` Portal	`11.649 kB` `4.262 kB`
`react-portal-compat` PortalCompatProvider	`6.446 kB` `2.186 kB`
`react-positioning` usePositioning	`24.008 kB` `8.798 kB`
`react-progress` ProgressBar	`13.856 kB` `5.434 kB`
`react-provider` FluentProvider	`18.033 kB` `6.666 kB`
`react-radio` Radio	`27.282 kB` `8.661 kB`
`react-radio` RadioGroup	`11.312 kB` `4.71 kB`
`react-select` Select	`25.357 kB` `8.798 kB`
`react-slider` Slider	`34.164 kB` `11.024 kB`
`react-spinbutton` SpinButton	`33.934 kB` `10.328 kB`
`react-spinner` Spinner	`20.882 kB` `6.798 kB`
`react-switch` Switch	`29.806 kB` `9.274 kB`
`react-table` Table (Primitives only)	`44.348 kB` `12.347 kB`
`react-table` Table (Selection only)	`78.056 kB` `19.084 kB`
`react-table` Table (Sort only)	`77.386 kB` `18.896 kB`
`react-tags` Tag	`20.916 kB` `7.449 kB`
`react-text` Text - Default	`12.492 kB` `4.92 kB`
`react-text` Text - Wrappers	`15.624 kB` `5.232 kB`
`react-textarea` Textarea	`27.545 kB` `9.064 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`31.33 kB` `6.764 kB`
`react-theme` Teams: Light theme	`17.895 kB` `5.162 kB`
`react-tooltip` Tooltip	`46.708 kB` `16.376 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against 31930f6a77d0473edea5eefef5acc63c78ff9de1}

fabricteam · 2023-04-13T10:03:58Z

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam · 2023-04-13T10:04:11Z

🕵 FluentUI-v0 No visual regressions between this PR and main

fabricteam · 2023-04-13T10:13:09Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	958	970	5000
Breadcrumb	mount	2634	2636	1000
Checkbox	mount	2540	2574	5000
CheckboxBase	mount	2250	2304	5000
ChoiceGroup	mount	4405	4347	5000
ComboBox	mount	1054	1082	1000
CommandBar	mount	9548	9683	1000
ContextualMenu	mount	19990	20503	1000
DefaultButton	mount	1171	1164	5000
DetailsRow	mount	3500	3481	5000
DetailsRowFast	mount	3591	3427	5000
DetailsRowNoStyles	mount	3166	3156	5000
Dialog	mount	4082	4061	1000
DocumentCardTitle	mount	361	389	1000
Dropdown	mount	2980	3039	5000
FocusTrapZone	mount	1744	1767	5000
FocusZone	mount	1718	1733	5000
GroupedList	mount	58107	67197	2
GroupedList	virtual-rerender	28438	28480	2
GroupedList	virtual-rerender-with-unmount	86446	85747	2
GroupedListV2	mount	378	379	2
GroupedListV2	virtual-rerender	352	353	2
GroupedListV2	virtual-rerender-with-unmount	386	386	2
IconButton	mount	1694	1678	5000
Label	mount	550	557	5000
Layer	mount	4264	4327	5000
Link	mount	624	634	5000
MenuButton	mount	1404	1485	5000
MessageBar	mount	33031	33135	5000
Nav	mount	3011	2981	1000
OverflowSet	mount	1209	1220	5000
Panel	mount	2611	2664	1000
Persona	mount	1194	1151	1000
Pivot	mount	1394	1415	1000
PrimaryButton	mount	1318	1270	5000
Rating	mount	6877	6868	5000
SearchBox	mount	1379	1383	5000
Shimmer	mount	2736	2790	5000
Slider	mount	2047	2078	5000
SpinButton	mount	4407	4446	5000
Spinner	mount	599	612	5000
SplitButton	mount	2881	2873	5000
Stack	mount	646	647	5000
StackWithIntrinsicChildren	mount	1344	1348	5000
StackWithTextChildren	mount	3863	3819	5000
SwatchColorPicker	mount	9611	9588	5000
TagPicker	mount	2352	2353	5000
Text	mount	593	599	5000
TextField	mount	1427	1413	5000
ThemeProvider	mount	1408	1395	5000
ThemeProvider	virtual-rerender	931	903	5000
ThemeProvider	virtual-rerender-with-unmount	2068	2076	5000
Toggle	mount	944	946	5000
buttonNative	mount	324	340	5000

layershifter · 2023-04-14T14:06:35Z

Is it real increase? 💥

bsunderhus · 2023-05-18T09:54:41Z

Is it real increase? 💥

yes, it is. modalizer has more scenarios covered

change/@fluentui-react-tabster-15456040-19ed-4576-b0d5-918ea610f2dd.json

msft-fluent-ui-bot · 2023-05-19T07:42:11Z