bugfix(react-dialog): removes unnecessary grid gaps #27845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 30ff8c1f8364df94fc10c4f26c88e495cb44dd2e (build) |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b3edaf9:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 718 | 682 | 5000 | |
| Button | mount | 389 | 376 | 5000 | |
| Field | mount | 1254 | 1320 | 5000 | |
| FluentProvider | mount | 889 | 904 | 5000 | |
| FluentProviderWithTheme | mount | 118 | 118 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 104 | 94 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 107 | 110 | 10 | |
| InfoButton | mount | 25 | 18 | 5000 | |
| MakeStyles | mount | 1116 | 1130 | 50000 | |
| Persona | mount | 2067 | 1992 | 5000 | |
| SpinButton | mount | 1563 | 1578 | 5000 |
fabricteam
reviewed
May 15, 2023
bsunderhus
commented
May 15, 2023
layershifter
approved these changes
May 16, 2023
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
2 tasks
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
May 18, 2023
* master: (24 commits) chore(react-tabster): upgrade tabster to v4.4.2 (microsoft#27540) feat(react-tags): Add TagGroup with context (microsoft#27886) applying package updates fix(react-infobutton): Add aria-owns to InfoLabel (microsoft#27834) fix(recipes-react-components): Add a FluentProvider to the local storybook (microsoft#27746) chore: update RFC template (microsoft#27880) applying package updates feat: implement Toaster offset (microsoft#27854) feat(react-drawer): create DrawerFooter component (microsoft#27583) Make getKey and selection props mutually exclusive (microsoft#24048) Added MIGRATION.md to the Breadcrumb (microsoft#27846) update Github CODEOWNERS file (microsoft#27849) feat(react-tags): make basic Tag a button instead of div (microsoft#27858) chore: add test-ssr script to v9 packages (microsoft#27690) chore(react-tree): exports TreeItemAside unstable (microsoft#27856) bugfix(react-dialog): removes unnecessary grid gaps (microsoft#27845) applying package updates fix(react-textarea): Don't remove outline when filled and disabled and apply correct disabled color to text (microsoft#27837) feat: Implement limit for toast stacking (microsoft#27848) Update README.md for fluent 2 theme to include import instructions (microsoft#27847) ...
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
May 18, 2023
* feat/drawer-header: (24 commits) chore(react-tabster): upgrade tabster to v4.4.2 (microsoft#27540) feat(react-tags): Add TagGroup with context (microsoft#27886) applying package updates fix(react-infobutton): Add aria-owns to InfoLabel (microsoft#27834) fix(recipes-react-components): Add a FluentProvider to the local storybook (microsoft#27746) chore: update RFC template (microsoft#27880) applying package updates feat: implement Toaster offset (microsoft#27854) feat(react-drawer): create DrawerFooter component (microsoft#27583) Make getKey and selection props mutually exclusive (microsoft#24048) fix: move style override to outside the component Added MIGRATION.md to the Breadcrumb (microsoft#27846) update Github CODEOWNERS file (microsoft#27849) feat(react-tags): make basic Tag a button instead of div (microsoft#27858) chore: add test-ssr script to v9 packages (microsoft#27690) chore(react-tree): exports TreeItemAside unstable (microsoft#27856) bugfix(react-dialog): removes unnecessary grid gaps (microsoft#27845) applying package updates fix(react-textarea): Don't remove outline when filled and disabled and apply correct disabled color to text (microsoft#27837) feat: Implement limit for toast stacking (microsoft#27848) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dialog, but technically this visual regression is a bugfix! As that space should never be there in the first place!New Behavior
grid-template-*andgrid-areacss styles since they generate a pre-defined "space" on the grid (meaning that this pre-defined space will introduce gaps around of it)grid-column-*andgrid-row-*css styles to properly position every single area of the grid without generating pre-defined spacesRelated Issue(s)