feat(react-datepicker-compat): Add error handling to DatePicker and update popup's padding #27637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopranopillow
added
Fluent UI react-components (v9)
Component: DatePickerCompat
sopranopillow
modified the milestones:
December Project Cycle Q4 2022,
April Project Cycle Q2 2023
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cc9f4f2:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 37e17afbfa3bc7c1c4aeb5823a44ccf81870e67f (build) |
Collaborator
📊 Bundle size report
🤖 This report was generated against 37e17afbfa3bc7c1c4aeb5823a44ccf81870e67f |
fabricteam
reviewed
Apr 19, 2023
change/@fluentui-react-datepicker-compat-59a888f8-093f-449c-b49e-4f580894da5e.json
Show resolved
Hide resolved
sopranopillow
changed the title
khmakoto
reviewed
Apr 20, 2023
packages/react-components/react-datepicker-compat/src/components/DatePicker/defaults.ts
Outdated
Show resolved
Hide resolved
...ct-components/react-datepicker-compat/stories/DatePicker/DatePickerErrorHandling.stories.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-datepicker-compat/src/components/DatePicker/useDatePicker.tsx
Show resolved
Hide resolved
khmakoto
approved these changes
Apr 20, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 24, 2023
* master: (58 commits) fix(react-datepicker-compat): Make onValidationError onValidationResult so the error is updated when there's no longer an error (microsoft#27655) Fix `@fluentui/react-portal-compat`: to be compatible with React 18 (microsoft#27577) chore: fix versions of @fluentui/react-datepicker-compat (microsoft#27666) applying package updates applying package updates Make line chart screen reader accessible (microsoft#27632) fix(react-examples): Improve keyboard navigation in ContextualMenu.CustomMenuList (microsoft#25172) docs(react-textarea): Update examples to use Field (microsoft#27644) bugfix(react-dialog): `DialogTitle` root as `h2` by default (microsoft#27555) applying package updates chore: restructure stories, add separate category for flat tree (microsoft#27586) fix document link (microsoft#27499) fix(react): exclude React.HTMLAttributes defined `content` prop for Tooltip and TooltipHost Prop types to mitigate @types/react breaking changes (microsoft#27467) chore(react-tabs): adopts custom JSX pragma (microsoft#27640) fix: ContextualMenuSplitButton always sets aria-checked (does not leave it undefined) when it is checkable (microsoft#27650) feat(react-datepicker-compat): Move DatePicker compat to stable (microsoft#27378) bugfix(react-tree): fix parent navigation after independency from id (microsoft#27642) applying package updates feat(react-datepicker-compat): Add error handling to DatePicker and update popup's padding (microsoft#27637) feat(public-docsite): Add banner to React component pages to promote v9 (microsoft#27557) ...
marcosmoura
pushed a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 25, 2023
…pdate popup's padding (microsoft#27637)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
DatePicker would validate and format dates by default, but this didn't come with a way to handle errors when validating the input.
DatePicker adds a padding to the popup and therefore the padding within calendar clashes and makes the padding look too large:
New Behavior
DatePicker now offers
onValidateErrorto provide the dev a way to know when there's an error in the validation of the input. The error may be of timerequired-input,out-of-bounds, andinvalid-input.without padding:
Related issues
Fixes #27643