Skip to content

Conversation

@sopranopillow
Copy link
Contributor

@sopranopillow sopranopillow commented Mar 30, 2023

This PR moves DatePicker compat to stable. Note that this process is different from react-components since we are not re-exporting DatePicker in react-components. We will simply make the package public and have the first version be 0.0.0.

@sopranopillow sopranopillow self-assigned this Mar 30, 2023
@size-auditor
Copy link

size-auditor bot commented Apr 20, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: acbc5fcb1381e9adcc4e1fa678a374d42a79438b (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 20, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f9fc66a:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 20, 2023

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-datepicker-compat
DatePicker Compat
223.13 kB
58.944 kB
🤖 This report was generated against acbc5fcb1381e9adcc4e1fa678a374d42a79438b

@sopranopillow
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 20, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@sopranopillow sopranopillow marked this pull request as ready for review April 20, 2023 16:31
@sopranopillow sopranopillow requested review from a team and khmakoto as code owners April 20, 2023 16:31
@sopranopillow sopranopillow merged commit bb8dfe0 into microsoft:master Apr 20, 2023
@sopranopillow sopranopillow deleted the react-datepicker-compat/stable branch April 20, 2023 18:14
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Apr 24, 2023
* master: (58 commits)
  fix(react-datepicker-compat): Make onValidationError onValidationResult so the error is updated when there's no longer an error (microsoft#27655)
  Fix `@fluentui/react-portal-compat`: to be compatible with React 18 (microsoft#27577)
  chore: fix versions of @fluentui/react-datepicker-compat (microsoft#27666)
  applying package updates
  applying package updates
  Make line chart screen reader accessible (microsoft#27632)
  fix(react-examples): Improve keyboard navigation in ContextualMenu.CustomMenuList (microsoft#25172)
  docs(react-textarea): Update examples to use Field (microsoft#27644)
  bugfix(react-dialog): `DialogTitle` root as `h2` by default (microsoft#27555)
  applying package updates
  chore: restructure stories, add separate category for flat tree (microsoft#27586)
  fix document link (microsoft#27499)
  fix(react): exclude React.HTMLAttributes defined `content` prop for Tooltip and TooltipHost Prop types to mitigate @types/react breaking changes (microsoft#27467)
  chore(react-tabs): adopts custom JSX pragma (microsoft#27640)
  fix: ContextualMenuSplitButton always sets aria-checked (does not leave it undefined) when it is checkable (microsoft#27650)
  feat(react-datepicker-compat): Move DatePicker compat to stable (microsoft#27378)
  bugfix(react-tree): fix parent navigation after independency from id (microsoft#27642)
  applying package updates
  feat(react-datepicker-compat): Add error handling to DatePicker and update popup's padding (microsoft#27637)
  feat(public-docsite): Add banner to React component pages to promote v9 (microsoft#27557)
  ...
marcosmoura pushed a commit to marcosmoura/fluentui that referenced this pull request Apr 25, 2023
…osoft#27378)

* moving react-datepicker-compat to stable

* change file

* reverting charting change

* changing change files type to none for beachball issues

* requested changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants