Skip to content

Conversation

@raylax
Copy link
Contributor

@raylax raylax commented Apr 10, 2023

New Behavior

Fix colors page link

@size-auditor
Copy link

size-auditor bot commented Apr 10, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: ebffada49e572de35e971ba5deea456bffb2f9c8 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 10, 2023

📊 Bundle size report

🤖 This report was generated against ebffada49e572de35e971ba5deea456bffb2f9c8

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 10, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit eb8a0fe:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@spmonahan
Copy link
Contributor

Thanks for the PR @raylax! Can you please address add:

  1. Previous/new behavior descriptions
  2. Link to the issue this PR fixes if one exists. If not, it's okay to leave that part off
  3. Ensure any change files are added by running yarn change.

@raylax
Copy link
Contributor Author

raylax commented Apr 11, 2023

So sorry, I am not familiar with the submission process

Nothing happens after running yarn change

Is this okay now?

@spmonahan
Copy link
Contributor

So sorry, I am not familiar with the submission process

Nothing happens after running yarn change

Is this okay now?

Yeah, I'll kick off the workflow now. Most documentation changes don't create a change file (this is what yarn change does) but I wasn't sure if the docsite would need one or not.

@Hotell Hotell changed the title fix document link docs(public-docsite-v9): fix document link Apr 12, 2023
@Hotell Hotell changed the title docs(public-docsite-v9): fix document link docs(public-docsite-v9): fix document link to theme colors page Apr 12, 2023
@tudorpopams tudorpopams self-requested a review April 12, 2023 12:11
@ling1726
Copy link
Contributor

/azp run Fluent UI React - PR and CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ling1726 ling1726 enabled auto-merge (squash) April 21, 2023 04:13
@ling1726 ling1726 merged commit edc7d50 into microsoft:master Apr 21, 2023
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Apr 24, 2023
* master: (58 commits)
  fix(react-datepicker-compat): Make onValidationError onValidationResult so the error is updated when there's no longer an error (microsoft#27655)
  Fix `@fluentui/react-portal-compat`: to be compatible with React 18 (microsoft#27577)
  chore: fix versions of @fluentui/react-datepicker-compat (microsoft#27666)
  applying package updates
  applying package updates
  Make line chart screen reader accessible (microsoft#27632)
  fix(react-examples): Improve keyboard navigation in ContextualMenu.CustomMenuList (microsoft#25172)
  docs(react-textarea): Update examples to use Field (microsoft#27644)
  bugfix(react-dialog): `DialogTitle` root as `h2` by default (microsoft#27555)
  applying package updates
  chore: restructure stories, add separate category for flat tree (microsoft#27586)
  fix document link (microsoft#27499)
  fix(react): exclude React.HTMLAttributes defined `content` prop for Tooltip and TooltipHost Prop types to mitigate @types/react breaking changes (microsoft#27467)
  chore(react-tabs): adopts custom JSX pragma (microsoft#27640)
  fix: ContextualMenuSplitButton always sets aria-checked (does not leave it undefined) when it is checkable (microsoft#27650)
  feat(react-datepicker-compat): Move DatePicker compat to stable (microsoft#27378)
  bugfix(react-tree): fix parent navigation after independency from id (microsoft#27642)
  applying package updates
  feat(react-datepicker-compat): Add error handling to DatePicker and update popup's padding (microsoft#27637)
  feat(public-docsite): Add banner to React component pages to promote v9 (microsoft#27557)
  ...
marcosmoura pushed a commit to marcosmoura/fluentui that referenced this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants