chore(react-table): use Iterable instead of a Set for table selection API surface
#26892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsunderhus
force-pushed
the
react-table--chore---exports-UseTableSelectionOptions-type
branch
from
c481621 to
161105d
Compare
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 103b8977f8d5f8dd8c430bab46ff5308a2c76371 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1301 | 1290 | 5000 | |
| Button | mount | 924 | 916 | 5000 | |
| Field | mount | 1941 | 1898 | 5000 | |
| FluentProvider | mount | 1571 | 1521 | 5000 | |
| FluentProviderWithTheme | mount | 581 | 580 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 540 | 547 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 585 | 575 | 10 | |
| InfoButton | mount | 517 | 517 | 5000 | |
| MakeStyles | mount | 1959 | 1945 | 50000 | |
| Persona | mount | 2833 | 2822 | 5000 | |
| SpinButton | mount | 2293 | 2270 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b93dca8:
|
bsunderhus
force-pushed
the
react-table--chore---exports-UseTableSelectionOptions-type
branch
from
161105d to
3b1513a
Compare
Collaborator
📊 Bundle size report
Unchanged fixtures
|
ling1726
approved these changes
Feb 20, 2023
Contributor
ling1726
left a comment
ling1726
left a comment
There was a problem hiding this comment.
Let's use the Iterable change as the PR title and changefile message
ling1726
reviewed
Feb 20, 2023
packages/react-components/react-table/src/hooks/useTableSelection.ts
Outdated
Show resolved
Hide resolved
bsunderhus
force-pushed
the
react-table--chore---exports-UseTableSelectionOptions-type
branch
from
8dce0be to
0593d60
Compare
- Converts types to allow Iterable instead of Set
bsunderhus
force-pushed
the
react-table--chore---exports-UseTableSelectionOptions-type
branch
from
0593d60 to
6bb6ba1
Compare
bsunderhus
force-pushed
the
react-table--chore---exports-UseTableSelectionOptions-type
branch
from
6bb6ba1 to
0b43add
Compare
bsunderhus
changed the title
Iterable instead of a Set for table selection API surface
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Feb 24, 2023
* master: (93 commits) chore: migrate to jest 27 (microsoft#26835) chore: make lint task run without need of build (microsoft#26872) chore(react-table): exports UseTableSelectionOptions (microsoft#26892) applying package updates fix(react-card): allow elements to grow to fill the available space (microsoft#26616) fix: Popover without focus trap should not be aria-hidden (microsoft#26932) applying package updates applying package updates fix(react-combobox): Remove _getAriaActiveDescendantValue, compute aria-activedescendantvalue in state, and update currentPendingValue when the options change (microsoft#26574) fix: v8 Combobox role and accname for non-hidden icon button (microsoft#26905) fix: Removing possible recursive loop in Coachmark (microsoft#26934) Combobox: Fix cursor jumping to the end of input (microsoft#26931) Fix missing icons on website (microsoft#26797) fix: Fix the width of Input's focus border with appearance=underline (microsoft#26881) chore: Clean up Input's interactive styles (microsoft#26865) Remove codeowners from change files (microsoft#26935) chore: add splitbutton error warning to docs, remove button ariaDescription example (microsoft#26904) docs: Remove testing code from MenuList example (microsoft#26929) chore: refactor SpinButton to use makeResetStyles (microsoft#26867) feat: Set overflow on positioned element when `autosize` is applied (microsoft#26868) ...
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Mar 15, 2023
…r-component * feat/drawer-base-component: (141 commits) remove DrawerContainer feat: WIP add initial draft for Drawer and DrawerContainer chore: migrate to jest 27 (microsoft#26835) chore: make lint task run without need of build (microsoft#26872) chore(react-table): exports UseTableSelectionOptions (microsoft#26892) applying package updates fix(react-card): allow elements to grow to fill the available space (microsoft#26616) fix: Popover without focus trap should not be aria-hidden (microsoft#26932) applying package updates applying package updates fix(react-combobox): Remove _getAriaActiveDescendantValue, compute aria-activedescendantvalue in state, and update currentPendingValue when the options change (microsoft#26574) fix: v8 Combobox role and accname for non-hidden icon button (microsoft#26905) fix: Removing possible recursive loop in Coachmark (microsoft#26934) Combobox: Fix cursor jumping to the end of input (microsoft#26931) Fix missing icons on website (microsoft#26797) fix: Fix the width of Input's focus border with appearance=underline (microsoft#26881) chore: Clean up Input's interactive styles (microsoft#26865) Remove codeowners from change files (microsoft#26935) chore: add splitbutton error warning to docs, remove button ariaDescription example (microsoft#26904) docs: Remove testing code from MenuList example (microsoft#26929) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
UseTableSelectionOptionsselectedItemswas based on receiving aSetfrom the userNew Behavior
selectedItemsanddefaultSelectedItemsnow accepts aIterableinstead of aSet, which internally will be converted to aSetUseTableSelectionOptionstype.