fix(react-card): allow elements to grow to fill the available space #26616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1689 | 1656 | 5000 | |
| Button | mount | 1137 | 1150 | 5000 | |
| Field | mount | 2642 | 2605 | 5000 | |
| FluentProvider | mount | 2058 | 2038 | 5000 | |
| FluentProviderWithTheme | mount | 741 | 725 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 681 | 686 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 729 | 732 | 10 | |
| InfoButton | mount | 651 | 651 | 5000 | |
| MakeStyles | mount | 2315 | 2311 | 50000 | |
| Persona | mount | 4054 | 3911 | 5000 | |
| SpinButton | mount | 3148 | 3244 | 5000 |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cd1c0ef:
|
ValentinaKozlova
approved these changes
Feb 3, 2023
Hotell
reviewed
Feb 6, 2023
packages/react-components/react-card/src/components/Card/useCardStyles.ts
Show resolved
Hide resolved
Hotell
approved these changes
Feb 6, 2023
* master: Added information about `Open in CodeSandbox` button repo (microsoft#26536) fix(Dropdown): Allow clear on Enter/Space press (microsoft#26685) RFC: Styling Handbook for Fluent UI React v9 (microsoft#26148) Table - Column resizing (microsoft#26477) applying package updates Sankey revisit ankit (microsoft#25455) removed disabled property from Label (microsoft#26658) Updated description for spin button (microsoft#26659) fix: react-button high contrast mode primary variant (microsoft#26623) fix: Using correct icon and color for away + out-of-office PresenceBadge (microsoft#26655) fix: Dropdown/Combobox checkboxes have double swipe stops for some screen readers (microsoft#26566) scaffold react-skeleton components (microsoft#26640) fix: HoverCard example adjusts to viewport, add docs (microsoft#26624) chore: export SlotRenderFunction type (microsoft#26600) fix(createPositionManager): computePosition should not apply styles after destruction (microsoft#26593) fix: New overflow items all always dispatch updates to subscriber (microsoft#26565) fix: Remove ReallyClean from CI pipelines (microsoft#26637) chore(react-infobutton): Making InfoButton's content focusable and update example's text (microsoft#26596) applying package updates
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 8ed653213848b19ea55f8e0e7b09523c8c16e9fc (build) |
fabricteam
reviewed
Feb 8, 2023
auto-merge was automatically disabled
February 13, 2023 13:08
Merge queue setting changed
marcosmoura
changed the title
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Feb 24, 2023
* master: (93 commits) chore: migrate to jest 27 (microsoft#26835) chore: make lint task run without need of build (microsoft#26872) chore(react-table): exports UseTableSelectionOptions (microsoft#26892) applying package updates fix(react-card): allow elements to grow to fill the available space (microsoft#26616) fix: Popover without focus trap should not be aria-hidden (microsoft#26932) applying package updates applying package updates fix(react-combobox): Remove _getAriaActiveDescendantValue, compute aria-activedescendantvalue in state, and update currentPendingValue when the options change (microsoft#26574) fix: v8 Combobox role and accname for non-hidden icon button (microsoft#26905) fix: Removing possible recursive loop in Coachmark (microsoft#26934) Combobox: Fix cursor jumping to the end of input (microsoft#26931) Fix missing icons on website (microsoft#26797) fix: Fix the width of Input's focus border with appearance=underline (microsoft#26881) chore: Clean up Input's interactive styles (microsoft#26865) Remove codeowners from change files (microsoft#26935) chore: add splitbutton error warning to docs, remove button ariaDescription example (microsoft#26904) docs: Remove testing code from MenuList example (microsoft#26929) chore: refactor SpinButton to use makeResetStyles (microsoft#26867) feat: Set overflow on positioned element when `autosize` is applied (microsoft#26868) ...
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Mar 15, 2023
…r-component * feat/drawer-base-component: (141 commits) remove DrawerContainer feat: WIP add initial draft for Drawer and DrawerContainer chore: migrate to jest 27 (microsoft#26835) chore: make lint task run without need of build (microsoft#26872) chore(react-table): exports UseTableSelectionOptions (microsoft#26892) applying package updates fix(react-card): allow elements to grow to fill the available space (microsoft#26616) fix: Popover without focus trap should not be aria-hidden (microsoft#26932) applying package updates applying package updates fix(react-combobox): Remove _getAriaActiveDescendantValue, compute aria-activedescendantvalue in state, and update currentPendingValue when the options change (microsoft#26574) fix: v8 Combobox role and accname for non-hidden icon button (microsoft#26905) fix: Removing possible recursive loop in Coachmark (microsoft#26934) Combobox: Fix cursor jumping to the end of input (microsoft#26931) Fix missing icons on website (microsoft#26797) fix: Fix the width of Input's focus border with appearance=underline (microsoft#26881) chore: Clean up Input's interactive styles (microsoft#26865) Remove codeowners from change files (microsoft#26935) chore: add splitbutton error warning to docs, remove button ariaDescription example (microsoft#26904) docs: Remove testing code from MenuList example (microsoft#26929) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title