docs: Improves Table documentation
#25787
Conversation
ling1726
commented
Nov 25, 2022
ling1726
commented
- Cleanup docstrings
- Adds main component description
- Adds descriptions to relevant examples
- Adds subcomponent props
- Reorders examples
- Cleanup docstrings - Adds main component description - Adds descriptions to relevant examples - Adds subcomponent props - Reorders examples
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 56a61fc731fa4ca6440eb78629c1e38b26154ffa (build) |
📊 Bundle size reportUnchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9d2768b:
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1306 | 1321 | 5000 | |
| Button | mount | 945 | 942 | 5000 | |
| FluentProvider | mount | 1569 | 1581 | 5000 | |
| FluentProviderWithTheme | mount | 627 | 623 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 590 | 583 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 627 | 616 | 10 | |
| MakeStyles | mount | 1914 | 1911 | 50000 | |
| SpinButton | mount | 2495 | 2552 | 5000 |
🕵 fluentuiv9 Open the Visual Regressions report to inspect the 2 screenshots✅ There was 0 screenshots added, 0 screenshots removed, 1749 screenshots unchanged, 0 screenshots with different dimensions and 2 screenshots with visible difference. unknown 2 screenshots
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 05ab7ad:
|
packages/react-components/react-table/stories/Table/CellActions.stories.tsx
Outdated
Show resolved
Hide resolved
| </Table> | ||
| ); | ||
| }; | ||
|
|
There was a problem hiding this comment.
TableCellActions overlaps TableCellLayout. Is that expected?
packages/react-components/react-table/stories/Table/CellNavigation.stories.tsx
Outdated
Show resolved
Hide resolved
| ); | ||
| }; | ||
|
|
||
| CellNavigation.parameters = { |
There was a problem hiding this comment.
not related to the PR, but the fact that storybook shows only the exported component source code makes the examples really hard to read - I do not know what the columns and items are, where you import useArrowNavigationGroup from... :/
There was a problem hiding this comment.
yeah we've had an open issue on it for a while #20046
| </Table> | ||
| ); | ||
| }; | ||
|
|
There was a problem hiding this comment.
Please double check keyboard navigation - I can select the row checkbox by both Enter and Space but Space scrolls.
For the uber checkbox for all lines I can only select it using Space (without scroll) cannot select it using Enter.
There was a problem hiding this comment.
Good point, I've made it behave consistently to uber checkbox and added preventDefault to stop the scrolling
* master: (34 commits) chore(react-tooltip): migrate to new package structure (microsoft#25818) chore(react-field): migrate to new package structure (microsoft#25817) Update vr screenshotdiff lib to accept vr host url as param (microsoft#25772) feat(scripts): enable strict checking for additional sub-folders(packages) v4 (microsoft#25710) fix(tools): bump norhtstar packages v9 deps on dep mismatch resolution (microsoft#25806) feat: remove react-storybook and replace its functionality via standard react-storybook-addon package (microsoft#25786) applying package updates chore(react-spinbutton): migrate to new package structure (microsoft#25813) chore(react-spinner): migrate to new package structure (microsoft#25814) chore(react-provider): migrate to new package structure (microsoft#25809) chore(react-radio, shared-contexts): migrate to new package structure (microsoft#25810) chore(react-theme): migrate to new package structure (microsoft#25812) docs: add Fluent UI Insights EP04 to README (microsoft#25775) chore(react-migration-v8-v9): use same build process/setup as v9/ts-solution packages (microsoft#25679) docs: Improves `Table` documentation (microsoft#25787) feat: improve react-18 tests (microsoft#25758) docs: Add examples for DataGrid (microsoft#25783) chore(react-tree): scaffold TreeItemLayout (microsoft#25781) perf: make ts-minbar test compilation faster and asset preparation simpler (microsoft#25754) chore: creates TreeItem and basic Tree (microsoft#25742) ...
* docs: Improves `Table` documentation - Cleanup docstrings - Adds main component description - Adds descriptions to relevant examples - Adds subcomponent props - Reorders examples * changefile * suggestions * suggestions * Add story for DataGrid implementation
3 participants
