-
Notifications
You must be signed in to change notification settings - Fork 2.9k
docs: Improves Table documentation
#25787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "prerelease", | ||
| "comment": "docs: Update docstrings for props", | ||
| "packageName": "@fluentui/react-table", | ||
| "email": "lingfangao@hotmail.com", | ||
| "dependentChangeType": "patch" | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -108,3 +108,15 @@ export const CellNavigation = () => { | |
| </Table> | ||
| ); | ||
| }; | ||
|
|
||
| CellNavigation.parameters = { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not related to the PR, but the fact that storybook shows only the exported component source code makes the examples really hard to read - I do not know what the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah we've had an open issue on it for a while #20046 |
||
| docs: { | ||
| description: { | ||
| story: [ | ||
| 'The `Table` primitive components do not support keyboard navigation. This should be added by users.', | ||
| 'Cell navigation can be achieved simply using the `useArrowNavigationGroup` utility provided by the Library.', | ||
| 'user state.', | ||
|
ling1726 marked this conversation as resolved.
Outdated
|
||
| ].join('\n'), | ||
| }, | ||
| }, | ||
| }; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -184,3 +184,15 @@ export const MultipleSelect = () => { | |
| </Table> | ||
| ); | ||
| }; | ||
|
|
||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please double check keyboard navigation - I can select the row checkbox by both Enter and Space but Space scrolls.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good point, I've made it behave consistently to uber checkbox and added |
||
| MultipleSelect.parameters = { | ||
| docs: { | ||
| description: { | ||
| story: [ | ||
| 'Selection can be achieved easily by combining the `TableSelectionCell` component along with', | ||
| 'other primitive components. The hook can handle state management for selection, although its use is not', | ||
| 'necessary if users already have their own state management.', | ||
| ].join('\n'), | ||
| }, | ||
| }, | ||
| }; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TableCellActionsoverlapsTableCellLayout. Is that expected?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submitted a bug for this #25789