feat: remove react-storybook and replace its functionality via standard react-storybook-addon package #25786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
changed the title
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 56a61fc731fa4ca6440eb78629c1e38b26154ffa (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1301 | 1256 | 5000 | |
| Button | mount | 939 | 919 | 5000 | |
| FluentProvider | mount | 1487 | 1471 | 5000 | |
| FluentProviderWithTheme | mount | 576 | 568 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 543 | 548 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 573 | 573 | 10 | |
| MakeStyles | mount | 1928 | 1936 | 50000 | |
| SpinButton | mount | 2327 | 2351 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1c73089:
|
Collaborator
🕵 fluentuiv8 Open the Visual Regressions report to inspect the 2 screenshots✅ There was 2 screenshots added, 0 screenshots removed, 1037 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference. unknown 2 screenshots
|
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ButtonMinimalPerf.default | 143 | 128 | 1.12:1 |
| ListCommonPerf.default | 537 | 490 | 1.1:1 |
| AccordionMinimalPerf.default | 123 | 113 | 1.09:1 |
| PortalMinimalPerf.default | 149 | 137 | 1.09:1 |
| ChatWithPopoverPerf.default | 316 | 295 | 1.07:1 |
| RefMinimalPerf.default | 186 | 175 | 1.06:1 |
| SkeletonMinimalPerf.default | 292 | 276 | 1.06:1 |
| FormMinimalPerf.default | 316 | 301 | 1.05:1 |
| TextAreaMinimalPerf.default | 395 | 377 | 1.05:1 |
| ButtonSlotsPerf.default | 470 | 451 | 1.04:1 |
| CardMinimalPerf.default | 439 | 424 | 1.04:1 |
| FlexMinimalPerf.default | 242 | 232 | 1.04:1 |
| ListMinimalPerf.default | 429 | 412 | 1.04:1 |
| ListNestedPerf.default | 454 | 435 | 1.04:1 |
| BoxMinimalPerf.default | 278 | 270 | 1.03:1 |
| CarouselMinimalPerf.default | 388 | 377 | 1.03:1 |
| DropdownManyItemsPerf.default | 543 | 529 | 1.03:1 |
| ImageMinimalPerf.default | 325 | 317 | 1.03:1 |
| StatusMinimalPerf.default | 566 | 548 | 1.03:1 |
| TreeWith60ListItems.default | 136 | 132 | 1.03:1 |
| DatepickerMinimalPerf.default | 4809 | 4735 | 1.02:1 |
| DialogMinimalPerf.default | 648 | 636 | 1.02:1 |
| DividerMinimalPerf.default | 291 | 285 | 1.02:1 |
| InputMinimalPerf.default | 943 | 929 | 1.02:1 |
| LoaderMinimalPerf.default | 265 | 261 | 1.02:1 |
| MenuMinimalPerf.default | 703 | 690 | 1.02:1 |
| ProviderMergeThemesPerf.default | 1069 | 1053 | 1.02:1 |
| CustomToolbarPrototype.default | 2246 | 2212 | 1.02:1 |
| ToolbarMinimalPerf.default | 763 | 749 | 1.02:1 |
| AlertMinimalPerf.default | 214 | 211 | 1.01:1 |
| AttachmentSlotsPerf.default | 920 | 915 | 1.01:1 |
| AvatarMinimalPerf.default | 156 | 155 | 1.01:1 |
| ButtonOverridesMissPerf.default | 1103 | 1088 | 1.01:1 |
| EmbedMinimalPerf.default | 3046 | 3007 | 1.01:1 |
| LayoutMinimalPerf.default | 283 | 279 | 1.01:1 |
| MenuButtonMinimalPerf.default | 1418 | 1401 | 1.01:1 |
| PopupMinimalPerf.default | 523 | 520 | 1.01:1 |
| ReactionMinimalPerf.default | 303 | 299 | 1.01:1 |
| SegmentMinimalPerf.default | 277 | 275 | 1.01:1 |
| SplitButtonMinimalPerf.default | 3665 | 3639 | 1.01:1 |
| TextMinimalPerf.default | 276 | 274 | 1.01:1 |
| AnimationMinimalPerf.default | 442 | 440 | 1:1 |
| AttachmentMinimalPerf.default | 120 | 120 | 1:1 |
| CheckboxMinimalPerf.default | 1725 | 1726 | 1:1 |
| DropdownMinimalPerf.default | 2250 | 2250 | 1:1 |
| GridMinimalPerf.default | 269 | 270 | 1:1 |
| ItemLayoutMinimalPerf.default | 964 | 964 | 1:1 |
| ListWith60ListItems.default | 513 | 512 | 1:1 |
| RosterPerf.default | 1793 | 1791 | 1:1 |
| TooltipMinimalPerf.default | 1962 | 1969 | 1:1 |
| ChatMinimalPerf.default | 587 | 591 | 0.99:1 |
| HeaderMinimalPerf.default | 286 | 289 | 0.99:1 |
| LabelMinimalPerf.default | 306 | 310 | 0.99:1 |
| ProviderMinimalPerf.default | 328 | 330 | 0.99:1 |
| SliderMinimalPerf.default | 1324 | 1333 | 0.99:1 |
| TableManyItemsPerf.default | 1536 | 1552 | 0.99:1 |
| HeaderSlotsPerf.default | 620 | 630 | 0.98:1 |
| RadioGroupMinimalPerf.default | 353 | 360 | 0.98:1 |
| IconMinimalPerf.default | 529 | 542 | 0.98:1 |
| TreeMinimalPerf.default | 659 | 674 | 0.98:1 |
| VideoMinimalPerf.default | 585 | 597 | 0.98:1 |
| TableMinimalPerf.default | 313 | 324 | 0.97:1 |
| ChatDuplicateMessagesPerf.default | 204 | 212 | 0.96:1 |
Collaborator
🕵 fluentuiv9 Open the Visual Regressions report to inspect the 2 screenshots✅ There was 0 screenshots added, 0 screenshots removed, 1749 screenshots unchanged, 0 screenshots with different dimensions and 2 screenshots with visible difference. unknown 2 screenshots
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| GroupedList | mount | 1872 | 2065 | 2 | Possible regression |
| TeachingBubble | mount | 80535 | 82253 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1156 | 1160 | 5000 | |
| Breadcrumb | mount | 2699 | 2944 | 1000 | |
| Checkbox | mount | 2640 | 2393 | 5000 | |
| CheckboxBase | mount | 2303 | 2245 | 5000 | |
| ChoiceGroup | mount | 4264 | 4279 | 5000 | |
| ComboBox | mount | 1213 | 1207 | 1000 | |
| CommandBar | mount | 9385 | 9268 | 1000 | |
| ContextualMenu | mount | 10070 | 10168 | 1000 | |
| DefaultButton | mount | 1352 | 1341 | 5000 | |
| DetailsRow | mount | 3580 | 3559 | 5000 | |
| DetailsRowFast | mount | 3534 | 3535 | 5000 | |
| DetailsRowNoStyles | mount | 3493 | 3469 | 5000 | |
| Dialog | mount | 3012 | 3046 | 1000 | |
| DocumentCardTitle | mount | 563 | 553 | 1000 | |
| Dropdown | mount | 2974 | 3212 | 5000 | |
| FocusTrapZone | mount | 1913 | 1995 | 5000 | |
| FocusZone | mount | 1929 | 1952 | 5000 | |
| GroupedList | mount | 1872 | 2065 | 2 | Possible regression |
| GroupedList | virtual-rerender | 1108 | 1128 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 1495 | 1644 | 2 | |
| GroupedListV2 | mount | 544 | 533 | 2 | |
| GroupedListV2 | virtual-rerender | 547 | 535 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 533 | 542 | 2 | |
| IconButton | mount | 1861 | 1792 | 5000 | |
| Label | mount | 710 | 731 | 5000 | |
| Layer | mount | 4141 | 4158 | 5000 | |
| Link | mount | 823 | 829 | 5000 | |
| MenuButton | mount | 1619 | 1638 | 5000 | |
| MessageBar | mount | 2255 | 2277 | 5000 | |
| Nav | mount | 3268 | 3265 | 1000 | |
| OverflowSet | mount | 1341 | 1349 | 5000 | |
| Panel | mount | 2492 | 2494 | 1000 | |
| Persona | mount | 1172 | 1295 | 1000 | |
| Pivot | mount | 1588 | 1595 | 1000 | |
| PrimaryButton | mount | 1520 | 1452 | 5000 | |
| Rating | mount | 6729 | 6941 | 5000 | |
| SearchBox | mount | 1398 | 1467 | 5000 | |
| Shimmer | mount | 2687 | 2721 | 5000 | |
| Slider | mount | 1926 | 2051 | 5000 | |
| SpinButton | mount | 4628 | 4564 | 5000 | |
| Spinner | mount | 792 | 800 | 5000 | |
| SplitButton | mount | 2881 | 2973 | 5000 | |
| Stack | mount | 807 | 814 | 5000 | |
| StackWithIntrinsicChildren | mount | 2330 | 2327 | 5000 | |
| StackWithTextChildren | mount | 4787 | 4875 | 5000 | |
| SwatchColorPicker | mount | 10351 | 10432 | 5000 | |
| TagPicker | mount | 2514 | 2612 | 5000 | |
| TeachingBubble | mount | 80535 | 82253 | 5000 | Possible regression |
| Text | mount | 775 | 749 | 5000 | |
| TextField | mount | 1587 | 1557 | 5000 | |
| ThemeProvider | mount | 1461 | 1502 | 5000 | |
| ThemeProvider | virtual-rerender | 1074 | 1078 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2084 | 2136 | 5000 | |
| Toggle | mount | 1115 | 1062 | 5000 | |
| buttonNative | mount | 518 | 530 | 5000 |
… react-storybook-addon
Hotell
requested review from
a team,
JustSlone and
jurokapsiar
as code owners
JustSlone
approved these changes
Nov 28, 2022
ling1726
approved these changes
Nov 28, 2022
spmonahan
approved these changes
Nov 28, 2022
khmakoto
approved these changes
Nov 28, 2022
| @@ -1,2 +1,4 @@ | |||
| export const ADDON_ID = 'storybook/fluentui-react-addon'; | |||
| export const THEME_ID = `${ADDON_ID}/theme` as const; | |||
|
|
|||
Member
There was a problem hiding this comment.
nit: remove this extra line
Suggested change
micahgodbolt
approved these changes
Nov 28, 2022
tudorpopams
approved these changes
Nov 29, 2022
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Nov 29, 2022
* master: (34 commits) chore(react-tooltip): migrate to new package structure (microsoft#25818) chore(react-field): migrate to new package structure (microsoft#25817) Update vr screenshotdiff lib to accept vr host url as param (microsoft#25772) feat(scripts): enable strict checking for additional sub-folders(packages) v4 (microsoft#25710) fix(tools): bump norhtstar packages v9 deps on dep mismatch resolution (microsoft#25806) feat: remove react-storybook and replace its functionality via standard react-storybook-addon package (microsoft#25786) applying package updates chore(react-spinbutton): migrate to new package structure (microsoft#25813) chore(react-spinner): migrate to new package structure (microsoft#25814) chore(react-provider): migrate to new package structure (microsoft#25809) chore(react-radio, shared-contexts): migrate to new package structure (microsoft#25810) chore(react-theme): migrate to new package structure (microsoft#25812) docs: add Fluent UI Insights EP04 to README (microsoft#25775) chore(react-migration-v8-v9): use same build process/setup as v9/ts-solution packages (microsoft#25679) docs: Improves `Table` documentation (microsoft#25787) feat: improve react-18 tests (microsoft#25758) docs: Add examples for DataGrid (microsoft#25783) chore(react-tree): scaffold TreeItemLayout (microsoft#25781) perf: make ts-minbar test compilation faster and asset preparation simpler (microsoft#25754) chore: creates TreeItem and basic Tree (microsoft#25742) ...
Hotell
added a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
…rd react-storybook-addon package (microsoft#25786) * feat(react-storybook-addon): migrate react-strict mode knob to react-storybook-addon * refactor: replace react-storybook with react-storybook-addon and remove the package
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
react-storybook:
New Behavior
New manager addon to toggle strict mode:
Related Issue(s)
react-storybookand replace its functionality via standardreact-storybook-addonpackage #21906