feat: Implement child render function for DataGrid rows #25476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: e807070d2060f0003f69705b06784cd678285e5e (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6c20b4f:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1263 | 1259 | 5000 | |
| Button | mount | 913 | 918 | 5000 | |
| FluentProvider | mount | 1465 | 1473 | 5000 | |
| FluentProviderWithTheme | mount | 570 | 573 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 529 | 542 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 579 | 581 | 10 | |
| MakeStyles | mount | 1943 | 1944 | 50000 | |
| SpinButton | mount | 2357 | 2335 | 5000 |
bsunderhus
approved these changes
Nov 2, 2022
Comment on lines
+17
to
+18
| const tableState = useTable({ items, columns }, []); | ||
| const baseTableState = useTable_unstable({ ...props, as: 'div' }, ref); |
Contributor
There was a problem hiding this comment.
Yeah, the naming is very confusing.... perhaps useHeadlessTable?
Contributor
Author
There was a problem hiding this comment.
yeah I agree, but I'd rather do this later, there are more important thigns that need to be implemented right now before we do a naming pass over everything
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Nov 2, 2022
* master: (23 commits) fix(docsite-v9): move theme picker under component title so it can be visible on embedded pages (microsoft#25385) applying package updates feat: Implement child render function for DataGrid rows (microsoft#25476) fix(useTable): sort should adapt to enhanced row types (microsoft#25487) applying package updates feat: positioning should happen out of React lifecycle (microsoft#25456) applying package updates chore(react-link): migrate to new package structure (microsoft#25471) chore(react-input): migrate to new package structure (microsoft#25469) fix glob pattern for syncpack (microsoft#25465) chore(react-label): migrate to new package structure (microsoft#25470) chore: bump Griffel to latest (microsoft#25412) chore: add few small toolbar improvements (microsoft#25468) docs: fix small typos (microsoft#25464) chore: fix dependencies in @fluentui/react-toolbar (microsoft#25466) feat: v0 menu style migration from v9 (microsoft#25012) applying package updates Update List to render children on first render() call (microsoft#25331) Scaffold react-skeleton package (microsoft#25435) fix(public-docsite): Changing crossplatform urls to use 'cross' instead of 'crossplatform' (microsoft#25437) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25459