feat: replace ToolbarRadio implementation by usage of toggle button as Radio #25343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1298 | 1299 | 5000 | |
| Button | mount | 941 | 940 | 5000 | |
| FluentProvider | mount | 1580 | 1577 | 5000 | |
| FluentProviderWithTheme | mount | 632 | 631 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 590 | 585 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 623 | 619 | 10 | |
| MakeStyles | mount | 1906 | 1950 | 50000 | |
| SpinButton | mount | 2528 | 2531 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit baa788e:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 6eb171ed4de160c697f50c6ceb672d0d7d430cd9 (build) |
ling1726
reviewed
Oct 24, 2022
packages/react-components/react-toolbar/src/components/Toolbar/useToolbar.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Oct 24, 2022
packages/react-components/react-toolbar/src/components/Toolbar/useToolbar.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Oct 24, 2022
packages/react-components/react-toolbar/src/components/Toolbar/Toolbar.types.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Oct 24, 2022
packages/react-components/react-toolbar/src/components/ToolbarRadio/ToolbarRadio.types.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Oct 24, 2022
packages/react-components/react-toolbar/src/components/ToolbarRadio/ToolbarRadio.tsx
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Oct 24, 2022
packages/react-components/react-toolbar/src/components/ToolbarRadio/useToolbarRadio.ts
Outdated
Show resolved
Hide resolved
ling1726
approved these changes
Oct 24, 2022
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 25, 2022
* master: (106 commits) fix: PopoverTriggerChildProps should be exported (microsoft#25159) feat: replace ToolbarRadio implementation by usage of toggle button as Radio (microsoft#25343) docs: improve Toolbar docs examples (microsoft#25269) feat(tools): add unstable API setup updates (microsoft#25355) applying package updates Fix wrong narration when legend selected (microsoft#24903) applying package updates chore(react-persona): Update beachball settings and change file's type (microsoft#25363) chore: Refactor Field VR tests to have individual tests per component (microsoft#25263) chore(react-persona, react-components, vr-tests-v9): Reverting react-persona's version to beta (microsoft#25357) Publishing migration package (microsoft#25354) fix: Detailslist is still tabbable when isHeaderVisible=false (microsoft#25342) fix: list even/odd off-by-one issue (microsoft#25358) feat: add Dropdown a11y spec (microsoft#24917) spinbutton: update internal padding for small size (microsoft#25286) chore(global-context): migrate to new package structure (microsoft#25341) feat: Add validationState to Progress, to make the bar red or green (microsoft#25253) feat: Add accessibility scenarios for Fluent UI v9 components #3 (microsoft#23334) feat(Dropdown): Freeform search should be case insensitive (microsoft#24879) feat(what-input): Limit keyboard detection in inputs (microsoft#25087) ...
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
…s Radio (microsoft#25343) * feat: replace ToolbarRadio implementation by usage of toggle button as radio * chore: add changes * chore: remove and update api * chore: update handler types * chore: delete line * chore: update checked items type * chore: rename * chore: update api and remove disable flag from handle radio * chore: update snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix: #25154
Remove current implementation of
ToolbarRadiousingRadioand replace it by implementation usingToggleButtonwith radio Behavior.