fix: PopoverTriggerChildProps should be exported #25159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
📊 Bundle size reportUnchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 60c5d06:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: f43aae1493a49053f7fe866a5c56056e73b1d709 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1271 | 1274 | 5000 | |
| Button | mount | 919 | 943 | 5000 | |
| FluentProvider | mount | 1510 | 1496 | 5000 | |
| FluentProviderWithTheme | mount | 583 | 586 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 547 | 543 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 583 | 584 | 10 | |
| MakeStyles | mount | 1986 | 1981 | 50000 | |
| SpinButton | mount | 2357 | 2321 | 5000 |
Hotell
reviewed
Oct 11, 2022
Hotell
approved these changes
Oct 11, 2022
khmakoto
approved these changes
Oct 18, 2022
layershifter
approved these changes
Oct 18, 2022
bsunderhus
approved these changes
Oct 19, 2022
Co-authored-by: Makoto Morimoto <[email protected]>
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 25, 2022
* master: (106 commits) fix: PopoverTriggerChildProps should be exported (microsoft#25159) feat: replace ToolbarRadio implementation by usage of toggle button as Radio (microsoft#25343) docs: improve Toolbar docs examples (microsoft#25269) feat(tools): add unstable API setup updates (microsoft#25355) applying package updates Fix wrong narration when legend selected (microsoft#24903) applying package updates chore(react-persona): Update beachball settings and change file's type (microsoft#25363) chore: Refactor Field VR tests to have individual tests per component (microsoft#25263) chore(react-persona, react-components, vr-tests-v9): Reverting react-persona's version to beta (microsoft#25357) Publishing migration package (microsoft#25354) fix: Detailslist is still tabbable when isHeaderVisible=false (microsoft#25342) fix: list even/odd off-by-one issue (microsoft#25358) feat: add Dropdown a11y spec (microsoft#24917) spinbutton: update internal padding for small size (microsoft#25286) chore(global-context): migrate to new package structure (microsoft#25341) feat: Add validationState to Progress, to make the bar red or green (microsoft#25253) feat: Add accessibility scenarios for Fluent UI v9 components #3 (microsoft#23334) feat(Dropdown): Freeform search should be case insensitive (microsoft#24879) feat(what-input): Limit keyboard detection in inputs (microsoft#25087) ...
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
* fix: PopoverTriggerChildProps should be exported * changefile * Update packages/react-components/react-components/src/index.ts Co-authored-by: Makoto Morimoto <[email protected]> Co-authored-by: Makoto Morimoto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PopoverTriggerChildProps was not exported. Without this type it's not easy to now what props are being returned by the
PopoverTriggerif users want to implement their own custom trigger or use a render function to do soAlso fixes the custom trigger story for Popover to actually create a custom trigger