spinbutton: update internal padding for small size #25286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the internal left and right padding of SpinButton at "small" sizes such that there are 8 pixels of padding to align with other input controls.
Collaborator
📊 Bundle size report
Unchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1a2d7ef:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: f9436f583d3c291921fe7a4531f69551096e758c (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1811 | 1807 | 5000 | |
| Button | mount | 1221 | 1211 | 5000 | |
| FluentProvider | mount | 2108 | 2007 | 5000 | |
| FluentProviderWithTheme | mount | 817 | 757 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 717 | 704 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 749 | 733 | 10 | |
| MakeStyles | mount | 2429 | 2547 | 50000 | |
| SpinButton | mount | 3351 | 3404 | 5000 |
Visual regression testing showed that the previous padding change affected external layout (i.e., it might break an application's layout) so this update accounts for the width change internally.
behowell
approved these changes
Oct 21, 2022
packages/react-components/react-spinbutton/src/components/SpinButton/useSpinButtonStyles.ts
Outdated
Show resolved
Hide resolved
…Button/useSpinButtonStyles.ts Co-authored-by: Ben Howell <[email protected]>
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 25, 2022
* master: (106 commits) fix: PopoverTriggerChildProps should be exported (microsoft#25159) feat: replace ToolbarRadio implementation by usage of toggle button as Radio (microsoft#25343) docs: improve Toolbar docs examples (microsoft#25269) feat(tools): add unstable API setup updates (microsoft#25355) applying package updates Fix wrong narration when legend selected (microsoft#24903) applying package updates chore(react-persona): Update beachball settings and change file's type (microsoft#25363) chore: Refactor Field VR tests to have individual tests per component (microsoft#25263) chore(react-persona, react-components, vr-tests-v9): Reverting react-persona's version to beta (microsoft#25357) Publishing migration package (microsoft#25354) fix: Detailslist is still tabbable when isHeaderVisible=false (microsoft#25342) fix: list even/odd off-by-one issue (microsoft#25358) feat: add Dropdown a11y spec (microsoft#24917) spinbutton: update internal padding for small size (microsoft#25286) chore(global-context): migrate to new package structure (microsoft#25341) feat: Add validationState to Progress, to make the bar red or green (microsoft#25253) feat: Add accessibility scenarios for Fluent UI v9 components #3 (microsoft#23334) feat(Dropdown): Freeform search should be case insensitive (microsoft#24879) feat(what-input): Limit keyboard detection in inputs (microsoft#25087) ...
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
* spinbutton: update internal padding for small size Updates the internal left and right padding of SpinButton at "small" sizes such that there are 8 pixels of padding to align with other input controls. * fix typo * update internal padding so it does not affect external layout Visual regression testing showed that the previous padding change affected external layout (i.e., it might break an application's layout) so this update accounts for the width change internally. * remove negative margin * fix lint warning * Update packages/react-components/react-spinbutton/src/components/SpinButton/useSpinButtonStyles.ts Co-authored-by: Ben Howell <[email protected]> Co-authored-by: Ben Howell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Internal SpinButton padding at "small" size does not align with other small input controls.
New Behavior
Internal SpinButton padding at "small" size aligns with other small input controls.
Related Issue(s)
Fixes #24516