refactor Progress to remove label and description slots #25067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c-react into react-progress-refactor
Collaborator
📊 Bundle size report
🤖 This report was generated against 1c8b241a322ca3d2ddb5dbe78154bb7bab1271df |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 69898d9:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 1c8b241a322ca3d2ddb5dbe78154bb7bab1271df (build) |
khmakoto
reviewed
Oct 4, 2022
packages/react-components/react-progress/src/components/Progress/Progress.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/Progress.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/Progress.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/Progress.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgress.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgressStyles.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgressStyles.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgressStyles.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/stories/Progress/ProgressDeterminate.stories.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Makoto Morimoto <[email protected]>
behowell
reviewed
Oct 4, 2022
packages/react-components/react-progress/src/components/Progress/Progress.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/Progress.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/Progress.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgress.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgressStyles.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgressStyles.ts
Outdated
Show resolved
Hide resolved
Comment on lines
5
to
11
| return <Progress {...props} percentComplete={50} />; | ||
| return <Progress {...props} />; | ||
| }; | ||
|
|
||
| Default.parameters = { | ||
| docs: { | ||
| description: { | ||
| story: `Default determinate Progress bar`, | ||
| story: `Default indeterminate Progress bar`, |
Contributor
There was a problem hiding this comment.
This is a bit of a style choice, but I'd actually recommend leaving the default story showing the determinate case (i.e. with value={0.5}), and have a separate story for the indeterminate case. Even though indeterminate is the "default" with no props, the determinate case seems like a more typical scenario.
Contributor
Author
There was a problem hiding this comment.
I follow that, I'll make the default determinate and change the determinate story to indeterminate
packages/react-components/react-progress/src/components/Progress/Progress.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgressStyles.ts
Outdated
Show resolved
Hide resolved
behowell
reviewed
Oct 4, 2022
packages/react-components/react-progress/src/components/Progress/useProgressStyles.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Ben Howell <[email protected]>
behowell
reviewed
Oct 4, 2022
packages/react-components/react-progress/src/stories/Progress/ProgressIndeterminate.stories.tsx
Outdated
Show resolved
Hide resolved
behowell
reviewed
Oct 4, 2022
packages/react-components/react-progress/src/stories/Progress/ProgressDefault.stories.tsx
Outdated
Show resolved
Hide resolved
…ProgressIndeterminate.stories.tsx Co-authored-by: Ben Howell <[email protected]>
behowell
approved these changes
Oct 4, 2022
packages/react-components/react-progress/src/components/Progress/Progress.types.ts
Outdated
Show resolved
Hide resolved
…ss/Progress.types.ts Co-authored-by: Ben Howell <[email protected]>
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 5, 2022
* master: (62 commits) chore(migrate-converged): add functionality to execute various v9 package file restructuring tasks (microsoft#24458) chore(react-dialog): updates stories (microsoft#25070) refactor Progress to remove label and description slots (microsoft#25067) fix(SplitButton): Remove borders from hover and pressed state in primary split buttons (microsoft#25059) chore(react-persona): Add vr, conformance, and unit tests (microsoft#25007) (docs): update Icon docs with examples (microsoft#24768) Split button/primary hc fix (microsoft#25066) chore(react-utilities): restricts trigger API types (microsoft#25044) Add utilities export @fluentui/style-utilities v8 (microsoft#25065) chore: migrate whole repo to webpack 5 (microsoft#24542) applying package updates BREAKING: refactor `useTable` to be composable (microsoft#24947) Added shims to shim packages (microsoft#25048) Add Progress SPEC (microsoft#24418) applying package updates chore(react-persona): Add bundle-size command for bundle-size fixtures (microsoft#25055) fix(Button): Remove margin added to buttons by Safari (microsoft#25052) fix: Menu triggers no longer take focus when they are mounted (microsoft#25016) chore: deletes react-trigger package (microsoft#25042) Fixed a minor typo: immmediately => immediately (microsoft#25036) ...
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
) * refactor Progress to remove label and description slots * api and snapshot update * Apply suggestions from code review Co-authored-by: Makoto Morimoto <[email protected]> * Apply suggestions from code review Co-authored-by: Ben Howell <[email protected]> * api and stories update * Update packages/react-components/react-progress/src/stories/Progress/ProgressIndeterminate.stories.tsx Co-authored-by: Ben Howell <[email protected]> * update stories * Update packages/react-components/react-progress/src/components/Progress/Progress.types.ts Co-authored-by: Ben Howell <[email protected]> Co-authored-by: Makoto Morimoto <[email protected]> Co-authored-by: Ben Howell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a followup to #24023. As per comments in #24418,
Progresswill be changed to more match the api surface of the html element, and aProgressFieldcomponent will be added to replace thelabelanddescriptionslots