Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed rounding bug in WebSurfer contrib tests. #1417

Closed
wants to merge 2 commits into from
Closed

Conversation

afourney
Copy link
Member

@afourney afourney commented Jan 26, 2024

Why are these changes needed?

Fixes a silly rounding bug that causes some websurfer contrib tests to fail.
The bug was previously unnoticed, but the length of the remote webpage used in the test has changed, causing the page breaks to fall in different locations.

Related issue number

N/A

Checks

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1ab2354) 32.48% compared to head (9a84239) 32.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1417   +/-   ##
=======================================
  Coverage   32.48%   32.48%           
=======================================
  Files          41       41           
  Lines        4907     4907           
  Branches     1120     1120           
=======================================
  Hits         1594     1594           
  Misses       3187     3187           
  Partials      126      126           
Flag Coverage Δ
unittests 32.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@BeibinLi BeibinLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@gagb gagb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no such thing as a silly bug Adam!

@afourney
Copy link
Member Author

Code formatting shows all green for me. I've got the latest version of the repo and uninstalled / re-installed pre-commit checks:
image
I also did not edit any notebooks in this PR. It's not clear why formatting checks are failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants