Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed rounding bug in WebSurfer contrib tests. #1417

Closed
wants to merge 2 commits into from
Closed

Fixed rounding bug in WebSurfer contrib tests. #1417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
927eb38
Fixed rounding bug.
afourney Jan 26, 2024
9a84239
Attempting to manually fix formatting errors.
afourney Jan 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion notebook/agentchat_cost_token_tracking.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,6 @@
}
],
"source": [
"\n",
"assistant = AssistantAgent(\n",
" \"assistant\",\n",
" system_message=\"You are a helpful assistant.\",\n",
Expand Down
2 changes: 1 addition & 1 deletion notebook/agentchat_function_call_currency_calculator.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@
" quote_currency: Annotated[CurrencySymbol, \"Quote currency\"] = \"EUR\",\n",
") -> str:\n",
" quote_amount = exchange_rate(base_currency, quote_currency) * base_amount\n",
" return f\"{quote_amount} {quote_currency}\"\n"
" return f\"{quote_amount} {quote_currency}\""
]
},
{
Expand Down
2 changes: 1 addition & 1 deletion notebook/agentchat_oai_assistant_retrieval.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@
" \"config_list\": config_list,\n",
" \"assistant_id\": assistant_id,\n",
" \"tools\": [{\"type\": \"retrieval\"}],\n",
" \"file_ids\": [\"file-CmlT0YKLB3ZCdHmslF9FOv69\"]\n",
" \"file_ids\": [\"file-CmlT0YKLB3ZCdHmslF9FOv69\"],\n",
" # add id of an existing file in your openai account\n",
" # in this case I added the implementation of conversable_agent.py\n",
"}\n",
Expand Down
1 change: 0 additions & 1 deletion samples/apps/autogen-studio/notebooks/tutorial.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
}
],
"source": [
"\n",
"# load an agent specification in JSON\n",
"agent_spec = json.load(open(\"agent_spec.json\"))\n",
"\n",
Expand Down
3 changes: 2 additions & 1 deletion test/test_browser_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import requests
import hashlib
import re
import math

from agentchat.test_assistant_agent import KEY_LOC # noqa: E402

Expand Down Expand Up @@ -78,7 +79,7 @@ def test_simple_text_browser():
assert BLOG_POST_STRING in browser.page_content

# Check if page splitting works
approx_pages = int(len(browser.page_content) / viewport_size + 0.5) # May be fewer, since it aligns to word breaks
approx_pages = math.ceil(len(browser.page_content) / viewport_size) # May be fewer, since it aligns to word breaks
assert len(browser.viewport_pages) <= approx_pages
assert abs(len(browser.viewport_pages) - approx_pages) <= 1 # allow only a small deviation
assert browser.viewport_pages[0][0] == 0
Expand Down
Loading