-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
functionality of manual history cleaning by user proxy added #1230
functionality of manual history cleaning by user proxy added #1230
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1230 +/- ##
===========================================
+ Coverage 32.48% 45.25% +12.76%
===========================================
Files 41 41
Lines 4907 4950 +43
Branches 1120 1201 +81
===========================================
+ Hits 1594 2240 +646
+ Misses 3187 2521 -666
- Partials 126 189 +63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@microsoft-github-policy-service agree |
@sonichi what do you think now? Everything is improved, I hope I answered all questions. Can we merge? |
Thanks. Running final tests. |
Seems like a problems with web browser. Have no idea why, changes are totally unrelated. I have no expertise in web browsing functionality, please help. EDIT: I see it is a known bug with WebSurfer. |
Yeah there is a bug in of websurfer's tests. The fix is here, but can't be merged because of another bug in an unrelated notebook code formatting check: |
…ft#1230) * functionality of manual history cleaning by admin added * formatting improved * formatting improved 2 * formatting improved 3 * test function added * test code formatting * test code formatting 2 * more advanced logging. Now user can see nr of messages to preserve as confirmation * test_invalid_allow_repeat_speaker uncommented * warning when providing recepient agent and nr messages to preserve added, changed variables names * code formatting * code formatting * code formatting * added 'enable_clear_history' variable to GroupChat * 'enable_clear_history' added, better descripted * clearing groupchat history added * clearing groupchat history added * two ifs merged into one, formatting improved * two ifs merged into one, formatting improved * two ifs merged into one, formatting improved * formatting * formatting --------- Co-authored-by: Davor Runje <[email protected]> Co-authored-by: Chi Wang <[email protected]>
…ft#1230) * functionality of manual history cleaning by admin added * formatting improved * formatting improved 2 * formatting improved 3 * test function added * test code formatting * test code formatting 2 * more advanced logging. Now user can see nr of messages to preserve as confirmation * test_invalid_allow_repeat_speaker uncommented * warning when providing recepient agent and nr messages to preserve added, changed variables names * code formatting * code formatting * code formatting * added 'enable_clear_history' variable to GroupChat * 'enable_clear_history' added, better descripted * clearing groupchat history added * clearing groupchat history added * two ifs merged into one, formatting improved * two ifs merged into one, formatting improved * two ifs merged into one, formatting improved * formatting * formatting --------- Co-authored-by: Davor Runje <[email protected]> Co-authored-by: Chi Wang <[email protected]>
What is this and how to use it?
Adds ability to clear agents' message history by user proxy manually writing "clear history" within message of user feedback.
Works for a groupchat when one of the agents is user proxy, recommended human_input_mode="ALWAYS".
When user asked to provide manual feedback, he can write "clear history" in his message to remove all the messages from agents history. Writing "clear history <agent_name>" will clear the history of messages only for selected agent. Writing "clear history <nr_of messages_to_preserve>" clears all the history except of last <nr_of messages_to_preserve> messages. Writing "clear history <agent_name> <nr_of messages_to_preserve>" will clear the history for selected agent except last <nr_of messages_to_preserve> messages.
User can noramally write other things in his message. "clear history" string and parameters will cutted out from user reply before passing it to the chat.
Why are these changes needed?
History of messages tends to grow endless very fast during group conversation. According to my experience, many of old messages became useless and just provide noise. Providing unnecesary history to LLM is bad practice because of:
That's why having possibility to manage history during conversation is important.
Related issue number
It could be solution or partial solution for #156, but not only.
Checks