[Docs/Contributing] Clarification on running non-OpenAI tests #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1052 +/- ##
=======================================
Coverage 30.27% 30.27%
=======================================
Files 30 30
Lines 3980 3980
Branches 897 897
=======================================
Hits 1205 1205
Misses 2696 2696
Partials 79 79
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sonichi
reviewed
Dec 25, 2023
sonichi
approved these changes
Dec 28, 2023
ekzhu
approved these changes
Dec 28, 2023
3 tasks
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
* add agent notebook and documentation * fix bug * set flush to True when printing msg in agent * add a math problem in agent notebook * remove * header * improve notebook doc * notebook update * improve notebook example * improve doc * improve notebook doc * improve print * doc * human_input_mode * human_input_mode str * indent * indent * Update flaml/autogen/agent/user_proxy_agent.py Co-authored-by: Chi Wang <[email protected]> * Update notebook/autogen_agent.ipynb Co-authored-by: Chi Wang <[email protected]> * Update notebook/autogen_agent.ipynb Co-authored-by: Chi Wang <[email protected]> * Update notebook/autogen_agent.ipynb Co-authored-by: Chi Wang <[email protected]> * renaming and doc format * typo --------- Co-authored-by: Chi Wang <[email protected]>
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
…oft#1052) * Update Contribute.md * Removed mentioning of OAI_CONFIG_LIST --------- Co-authored-by: Qingyun Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a fresh contributor I struggled with running tests locally and it took me some time to understand that:
openaiis not installed)build.yaml(which is a mandatory checkpoint for any PR) only runs AMade a clarification to
Contributingpage.P.S.: As a follow-up it's worth to clarify how to run OpenAI tests locally. Guidance from someone is welcome. It seems there're 2 dependencies: (1) a well formed OAI_CONFIG_LIST file (there're plenty of hard-coded model names spread across tests, haven't identified the, all) and (2) Docker Desktop up-and-running
Checks