Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put all the tests requiring openai in one place and skip/run them in the pytest command in the workflow #1088

Closed
sonichi opened this issue Dec 28, 2023 · 3 comments · Fixed by #1097
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@sonichi
Copy link
Contributor

sonichi commented Dec 28, 2023

          In future, we can put all the tests requiring openai in one place and skip/run them in the pytest command in the workflow, instead of skipping each test based on whether openai is installed.

Originally posted by @sonichi in #1052 (comment)

@sonichi
Copy link
Contributor Author

sonichi commented Dec 28, 2023

Also see @maxim-saplin's followup comment

@sonichi sonichi added the documentation Improvements or additions to documentation label Dec 28, 2023
@olaoluwasalami olaoluwasalami self-assigned this Dec 29, 2023
@maxim-saplin
Copy link
Collaborator

maxim-saplin commented Dec 29, 2023

I would break it down in 2 parts:

  • support --skip-openai pytest argument to allow skipping all tests that depend on OpenAI API endpoints
  • consolidate all model endpoints used by tests in a single file and make sure tests only use models available through that file

@afourney
Copy link
Member

There may be other requirements that incur similar constraints. E.g., some agents might need the Bing API Key. Others might need access to some non-standard dependencies, etc. Whatever we do we should ensure the design is extensible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants