-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Extending inline docs for openai_utils.py
, boosting coverage in test_utils.py
, fixing #762
#1046
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1046 +/- ##
===========================================
+ Coverage 30.14% 40.96% +10.81%
===========================================
Files 30 30
Lines 4020 4028 +8
Branches 908 960 +52
===========================================
+ Hits 1212 1650 +438
+ Misses 2729 2252 -477
- Partials 79 126 +47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
… in `test_utils.py`, fixing microsoft#762 (microsoft#1046) * fix for microsoft#762 ,get_config_list/oia assetion, docs, test * Improved docstrings * test_utils using fake data and temp files * "Black" formatting applied * Fix build (KEY_LOC and OAI_CONFIG_LIST as consts in test_client) * Ramping up openai_utils coverage * Missing parameter doc. --------- Co-authored-by: Eric Zhu <[email protected]>
Why are these changes needed?
openai_utils.py
test_utils.py
has more cases tested ramping up coveragetest_utils.py
no longer depends on files that are part of .gitignore (and hence not downloaded when cloning), utilises temp files and fake dataopenai_utils.get_config_list()
has an assertion verifying that number of items in files is equal (replacing the current behaviour with out of index being thrown)Related issue number
Closes #762
Checks
P.S. settings up the full suite with all required open configs is a challenge, though I made sure the parts and tests impacted by the changes ran fine