Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift Package Manager support (Analytics & Crashes) #2039

Merged
merged 35 commits into from
May 8, 2020

Conversation

MatkovIvan
Copy link
Contributor

@MatkovIvan MatkovIvan commented Apr 24, 2020

  • Has CHANGELOG.md been updated?
  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

Swift Package Manager has become the official package manager for the third-party libraries on all platforms.

Related PRs or issues

AB#74009

@MatkovIvan MatkovIvan changed the title Swift Package Manager support Swift Package Manager support (Core & Analytics) Apr 24, 2020
russelarms
russelarms previously approved these changes Apr 24, 2020
vvechkanov
vvechkanov previously approved these changes Apr 24, 2020
Jamminroot
Jamminroot previously approved these changes Apr 24, 2020
@codecov-io

This comment has been minimized.

CHANGELOG.md Outdated Show resolved Hide resolved
Package.swift Show resolved Hide resolved
Ruslan Urmeev and others added 2 commits April 29, 2020 10:46
@MatkovIvan MatkovIvan changed the title Swift Package Manager support (Core & Analytics) Swift Package Manager support (Analytics & Crashes) May 6, 2020
@annakocheshkova
Copy link

Verified that ios/macos extensions work, but with a little workaround (see https://github.com/MicrosoftDocs/appcenter-docs-pr/pull/1900)

@MatkovIvan MatkovIvan merged commit 8ca3526 into develop May 8, 2020
@MatkovIvan MatkovIvan deleted the feature/SPM-support branch May 8, 2020 06:59
@wlisac
Copy link

wlisac commented May 18, 2020

@annakocheshkova Can you share the workaround for macOS extensions? That link does not appear to be public.

@MatkovIvan
Copy link
Contributor Author

@wlisac

If you're integrating App Center via SPM and want to use it in your app's extension target as well, make sure that you provide DISABLE_DIAMOND_PROBLEM_DIAGNOSTIC=YES in your configuration. This is necessary to avoid SPM limitations in linking a module to multiple targets.

@eljeff
Copy link

eljeff commented Oct 15, 2020

@wlisac

If you're integrating App Center via SPM and want to use it in your app's extension target as well, make sure that you provide DISABLE_DIAMOND_PROBLEM_DIAGNOSTIC=YES in your configuration. This is necessary to avoid SPM limitations in linking a module to multiple targets.

@MatkovIvan How / where do you set this?
Thanks y'all

@MatkovIvan
Copy link
Contributor Author

@eljeff Xcode target's build settings (if it cannot be found, add it with "+" menu) or xcconfig file

@eljeff
Copy link

eljeff commented Oct 16, 2020

Thanks a lot @MatkovIvan . I went to build setting, clicked the "+" button for "Add User-Defined Setting", and there I can paste in "DISABLE_DIAMOND_PROBLEM_DIAGNOSTIC", and set value to "YES"

Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants