-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/report token and failures #73
Conversation
I'm not sure what the build failure is here - any way I can re-create the build process locally to see? |
I'm having issues pulling this in via Xcode. It looks like SPM isn't getting values from
I don't see a way of incorporating the xcconfig in the SPM manifest. I think we may need to rethink how SDK_VERSION is defined - perhaps it could be a macro in a header file instead? |
@powerje I'm open to any changes we need to do. Let's look to AppCenter for how they did it. |
Added TODO to work around SDK_VERSION xcconfig issue with SPM
* @param notificationHub The instance of MSNotificationHub | ||
* @param pushToken The push token | ||
*/ | ||
- (void)notificationHub:(MSNotificationHub *)notificationHub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're going to do a rename, we should have maybe a sample linked in our Swift sample app?
@mpodwysocki apologies on not getting to the requested changes yet. Let me know if there's any urgency on Microsoft's end to get these in sooner than later. I will be able to allocate time for this around the 22nd based on my sprint schedule but could move it up in priority if need be to hit a Microsoft release target. |
@powerje We're looking to GA fairly soon, although this is not a breaking change at this point, but an addition, so it can certainly be available after that. We're also adding push to user and other features so there are opportunities forthcoming. |
As you can tell, we've made a lot of changes since your initial PR. Can you update it to reflect the newest changes? |
Adds optional delegate methods for getting the push token and any errors that occur while registering for push tokens, per discussion in #43